thermal: Allow selecting the bang-bang governor as default
Subsystems (2)
PATCH 1/1 thermal: Allow selecting the bang-bang governor as default
From: Thierry Reding <[email protected]>
For many setups the bang-bang governor is exactly what we want. Many ARM SoC-based devices use fans to cool down the entire SoC and that works well only with the bang-bang governor because it uses the hysteresis in order to let the fan run for a while to cool the SoC down below the trip point before switching it off again.
The step-wise governor will behave strangely in these situations. It doesn't use the hysteresis, so it can lead to situations where the fan is turned on for only a very brief period and then is switched back off, only to get switched back on again very quickly because the SoC hasn't cooled down very much.
--- drivers/thermal/Kconfig | 8 ++++++++ drivers/thermal/thermal_core.h | 2 ++ 2 files changed, 10 insertions(+)
drivers/thermal/Kconfig +8 -0
@@ -130,6 +130,14 @@ config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR system and device power allocation. This governor can only operate on cooling devices that implement the power API. +config THERMAL_DEFAULT_GOV_BANG_BANG + bool "bang_bang" + depends on THERMAL_GOV_BANG_BANG + help + Use the bang_bang governor as default. This throttles the + devices one step at the time, taking into account the trip + point hysteresis. + endchoice config THERMAL_GOV_FAIR_SHARE
drivers/thermal/thermal_core.h +2 -0
@@ -23,6 +23,8 @@#define DEFAULT_THERMAL_GOVERNOR "user_space"#elif defined(CONFIG_THERMAL_DEFAULT_GOV_POWER_ALLOCATOR )#define DEFAULT_THERMAL_GOVERNOR "power_allocator" +#elif defined(CONFIG_THERMAL_DEFAULT_GOV_BANG_BANG ) +#define DEFAULT_THERMAL_GOVERNOR "bang_bang"#endif /* Initial state of a cooling device during binding */
Signature · 1 line
2.40.1
Hi Thierry,
Quoted 7 lines · Thierry Reding
From: Thierry Reding <[email protected]>
For many setups the bang-bang governor is exactly what we want. Many ARM SoC-based devices use fans to cool down the entire SoC and that works well only with the bang-bang governor because it uses the hysteresis in order to let the fan run for a while to cool the SoC down below the trip point before switching it off again.
Yeah, that trip point detection is screwed up at the moment, but we are on the way to solve that. From there, we should be able to have the step_wise governor working as the bang-bang governor and remove this one.
Meanwhile, the change sounds ok for me.
Rafael, may I pick this change?
Quoted 44 lines
The step-wise governor will behave strangely in these situations. It doesn't use the hysteresis, so it can lead to situations where the fan is turned on for only a very brief period and then is switched back off, only to get switched back on again very quickly because the SoC hasn't cooled down very much.
Signed-off-by Thierry Reding <[email protected]>--- drivers/thermal/Kconfig | 8 ++++++++ drivers/thermal/thermal_core.h | 2 ++ 2 files changed, 10 insertions(+)drivers/thermal/Kconfig +8
-0@@ -130,6 +130,14 @@ config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR system and device power allocation. This governor can only operate on cooling devices that implement the power API. +config THERMAL_DEFAULT_GOV_BANG_BANG + bool "bang_bang" + depends on THERMAL_GOV_BANG_BANG + help + Use the bang_bang governor as default. This throttles the + devices one step at the time, taking into account the trip + point hysteresis. + endchoice config THERMAL_GOV_FAIR_SHAREdrivers/thermal/thermal_core.h +2
-0@@ -23,6 +23,8 @@#define DEFAULT_THERMAL_GOVERNOR "user_space"#elif defined(CONFIG_THERMAL_DEFAULT_GOV_POWER_ALLOCATOR )#define DEFAULT_THERMAL_GOVERNOR "power_allocator" +#elif defined(CONFIG_THERMAL_DEFAULT_GOV_BANG_BANG ) +#define DEFAULT_THERMAL_GOVERNOR "bang_bang"#endif /* Initial state of a cooling device during binding */
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Rafael J. Wysocki
maintainerQuoted 13 lines · Daniel Lezcano
Hi Thierry,
Quoted 7 lines · Thierry Reding
From: Thierry Reding <[email protected]>
For many setups the bang-bang governor is exactly what we want. Many ARM SoC-based devices use fans to cool down the entire SoC and that works well only with the bang-bang governor because it uses the hysteresis in order to let the fan run for a while to cool the SoC down below the trip point before switching it off again.
Quoted 7 lines
Yeah, that trip point detection is screwed up at the moment, but we are on the way to solve that. From there, we should be able to have the
step_wisegovernor working as the bang-bang governor and remove this one.Meanwhile, the change sounds ok for me.
Rafael, may I pick this change?
Please do, thank you!
Daniel Lezcano
AppliedQuoted 8 lines · Thierry Reding
From: Thierry Reding <[email protected]>
For many setups the bang-bang governor is exactly what we want. Many ARM SoC-based devices use fans to cool down the entire SoC and that works well only with the bang-bang governor because it uses the hysteresis in order to let the fan run for a while to cool the SoC down below the trip point before switching it off again.
Quoted 5 lines
The step-wise governor will behave strangely in these situations. It doesn't use the hysteresis, so it can lead to situations where the fan is turned on for only a very brief period and then is switched back off, only to get switched back on again very quickly because the SoC hasn't cooled down very much.
Applied, thanks
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog