Skip to contentSkip to conversation

regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed

PATCH In review Axel Lin 3 participants 3 messages Jun 15, 2016

Subsystems (2)
Arm Qualcomm mailing list Voltage and current regulator framework
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed

Use regulator_list_voltage_linear_range in rpm_smps_ldo_ops_fixed is wrong because it is used for fixed regulator without any linear range. The rpm_smps_ldo_ops_fixed is used for pm8941_lnldo which has fixed_uV set and n_voltages = 1. In this case, regulator_list_voltage() can return rdev->desc->fixed_uV without .list_voltage implementation.

Fixes 3bfbb4d1a480 ("regulator: qcom_smd: add list_voltage callback")
Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/qcom_smd-regulator.c | 1 -
 1 file changed, 1 deletion(-)
drivers/regulator/qcom_smd-regulator.c +0 -1
index 526bf23..6c7fe477 100644
@@ -152,7 +152,6 @@ static const struct regulator_ops rpm_smps_ldo_ops_fixed = {
 	.enable = rpm_reg_enable,
 	.disable = rpm_reg_disable,
 	.is_enabled = rpm_reg_is_enabled,
-	.list_voltage = regulator_list_voltage_linear_range,
 
 	.get_voltage = rpm_reg_get_voltage,
 	.set_voltage = rpm_reg_set_voltage,
Signature · 1 line
2.5.0
#1 lore raw

Hi Mark,

Quoted 7 lines · Axel Lin

Use regulator_list_voltage_linear_range in rpm_smps_ldo_ops_fixed is wrong because it is used for fixed regulator without any linear range. The rpm_smps_ldo_ops_fixed is used for pm8941_lnldo which has fixed_uV set and n_voltages = 1. In this case, regulator_list_voltage() can return rdev->desc->fixed_uV without .list_voltage implementation.

Fixes 3bfbb4d1a480 ("regulator: qcom_smd: add list_voltage callback")

TBH, 3bfbb4d1a480 patch was never in the mailing list, am sure there is some confusion while applying other patches.

May be a8a47540ebe3 got re-applied, without any errors/warning I guess.

These are the only 2 patches which were submitted in mailing list and which made into next.

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a8a47540ebe32f1733eebc3e5699af580ceaa3f5

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d1e44b6b2823f1751ffe7e7589f545f05cfe2095

Thanks,
srini

Quoted 18 lines
Signed-off-by Axel Lin <[email protected]>
---
  drivers/regulator/qcom_smd-regulator.c | 1 -
  1 file changed, 1 deletion(-)
drivers/regulator/qcom_smd-regulator.c +0 -1
index 526bf23..6c7fe477 100644
@@ -152,7 +152,6 @@ static const struct regulator_ops rpm_smps_ldo_ops_fixed = {
  	.enable = rpm_reg_enable,
  	.disable = rpm_reg_disable,
  	.is_enabled = rpm_reg_is_enabled,
-	.list_voltage = regulator_list_voltage_linear_range,
 
  	.get_voltage = rpm_reg_get_voltage,
  	.set_voltage = rpm_reg_set_voltage,
maintainer
#2 lore raw

Applied "regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed" to the regulator tree

In reply to Axel Lin

The patch

regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 43160ffd12c8d1d331362362eea3c70e04b6f9c4 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Wed, 15 Jun 2016 10:21:34 +0800
Subject: [PATCH] regulator: qcom_smd: Remove list_voltage callback for
rpm_smps_ldo_ops_fixed

Use regulator_list_voltage_linear_range in rpm_smps_ldo_ops_fixed is wrong because it is used for fixed regulator without any linear range. The rpm_smps_ldo_ops_fixed is used for pm8941_lnldo which has fixed_uV set and n_voltages = 1. In this case, regulator_list_voltage() can return rdev->desc->fixed_uV without .list_voltage implementation.

Fixes 3bfbb4d1a480 ("regulator: qcom_smd: add list_voltage callback")
Signed-off-by Axel Lin <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 drivers/regulator/qcom_smd-regulator.c | 1 -
 1 file changed, 1 deletion(-)
drivers/regulator/qcom_smd-regulator.c +0 -1
index 526bf23dcb49..6c7fe4778793 100644
@@ -152,7 +152,6 @@ static const struct regulator_ops rpm_smps_ldo_ops_fixed = {
 	.enable = rpm_reg_enable,
 	.disable = rpm_reg_disable,
 	.is_enabled = rpm_reg_is_enabled,
-	.list_voltage = regulator_list_voltage_linear_range,
 
 	.get_voltage = rpm_reg_get_voltage,
 	.set_voltage = rpm_reg_set_voltage,
Signature · 1 line
2.8.1