mmc: host: use pr_err for sdhci_dumpregs

PATCH In review Baranowska, BeataX 4 participants 6 messages May 30, 2016 – Jun 22, 2016

Subsystems (2)

MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver

lore

Share & tools

lore

Baranowska, BeataX

author

2016-05-30 07:59 UTC #0 lore raw

PATCH 1/1 mmc: host: use pr_err for sdhci_dumpregs

From: Chuanxiao Dong <[email protected]>

sdhci_dumpregs is used to dump registers when error happens. Thus it should use pr_err instead of pr_debug to show more information about the hardware.

Signed-off-by Chuanxiao Dong <[email protected]>

---
drivers/mmc/host/sdhci.c | 32 ++++++++++++++++----------------

 1 file changed, 16 insertions(+), 16 deletions(-)

drivers/mmc/host/sdhci.c +16 ~~-16~~

index e010ea4eb6f5..99441742d86e 100644
@@ -52,58 +52,58 @@ static int sdhci_get_cd(struct mmc_host *mmc);
 
 static void sdhci_dumpregs(struct sdhci_host *host)
 {
-       pr_debug(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
+       pr_err(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
                mmc_hostname(host->mmc));
 
-       pr_debug(DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
+       pr_err(DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
                sdhci_readl(host, SDHCI_DMA_ADDRESS),
                sdhci_readw(host, SDHCI_HOST_VERSION));
-       pr_debug(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt:  0x%08x\n",
+       pr_err(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt:  0x%08x\n",
                sdhci_readw(host, SDHCI_BLOCK_SIZE),
                sdhci_readw(host, SDHCI_BLOCK_COUNT));
-       pr_debug(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n",
                sdhci_readl(host, SDHCI_ARGUMENT),
                sdhci_readw(host, SDHCI_TRANSFER_MODE));
-       pr_debug(DRIVER_NAME ": Present:  0x%08x | Host ctl: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Present:  0x%08x | Host ctl: 0x%08x\n",
                sdhci_readl(host, SDHCI_PRESENT_STATE),
                sdhci_readb(host, SDHCI_HOST_CONTROL));
-       pr_debug(DRIVER_NAME ": Power:    0x%08x | Blk gap:  0x%08x\n",
+       pr_err(DRIVER_NAME ": Power:    0x%08x | Blk gap:  0x%08x\n",
                sdhci_readb(host, SDHCI_POWER_CONTROL),
                sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL));
-       pr_debug(DRIVER_NAME ": Wake-up:  0x%08x | Clock:    0x%08x\n",
+       pr_err(DRIVER_NAME ": Wake-up:  0x%08x | Clock:    0x%08x\n",
                sdhci_readb(host, SDHCI_WAKE_UP_CONTROL),
                sdhci_readw(host, SDHCI_CLOCK_CONTROL));
-       pr_debug(DRIVER_NAME ": Timeout:  0x%08x | Int stat: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Timeout:  0x%08x | Int stat: 0x%08x\n",
                sdhci_readb(host, SDHCI_TIMEOUT_CONTROL),
                sdhci_readl(host, SDHCI_INT_STATUS));
-       pr_debug(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n",
                sdhci_readl(host, SDHCI_INT_ENABLE),
                sdhci_readl(host, SDHCI_SIGNAL_ENABLE));
-       pr_debug(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n",
+       pr_err(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n",
                sdhci_readw(host, SDHCI_ACMD12_ERR),
                sdhci_readw(host, SDHCI_SLOT_INT_STATUS));
-       pr_debug(DRIVER_NAME ": Caps:     0x%08x | Caps_1:   0x%08x\n",
+       pr_err(DRIVER_NAME ": Caps:     0x%08x | Caps_1:   0x%08x\n",
                sdhci_readl(host, SDHCI_CAPABILITIES),
                sdhci_readl(host, SDHCI_CAPABILITIES_1));
-       pr_debug(DRIVER_NAME ": Cmd:      0x%08x | Max curr: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Cmd:      0x%08x | Max curr: 0x%08x\n",
                sdhci_readw(host, SDHCI_COMMAND),
                sdhci_readl(host, SDHCI_MAX_CURRENT));
-       pr_debug(DRIVER_NAME ": Host ctl2: 0x%08x\n",
+       pr_err(DRIVER_NAME ": Host ctl2: 0x%08x\n",
                sdhci_readw(host, SDHCI_HOST_CONTROL2));
 
        if (host->flags & SDHCI_USE_ADMA) {
                if (host->flags & SDHCI_USE_64_BIT_DMA)
-                       pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n",
+                       pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n",
                                 readl(host->ioaddr + SDHCI_ADMA_ERROR),
                                 readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI),
                                 readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
                else
-                       pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n",
+                       pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n",
                                 readl(host->ioaddr + SDHCI_ADMA_ERROR),
                                 readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
        }
 
-       pr_debug(DRIVER_NAME ": ===========================================\n");
+       pr_err(DRIVER_NAME ": ===========================================\n");
 }
 
 /*****************************************************************************\

Regards,
Beata Baranowska

Intel Technology Poland sp. z o.o.
ul. Słowackiego 173 | 80-298 Gdańsk
Sąd Rejonowy Gdańsk Północ
VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN

Andy Shevchenko

2016-05-31 15:46 UTC #1 lore raw

Quoted 5 lines · BeataX

From: Chuanxiao Dong <[email protected]>
sdhci_dumpregs is used to dump registers when error happens. Thus it should use pr_err instead of pr_debug to show more information about the hardware.

Wouldn't be too noisy?

Signature · 2 lines

With Best Regards,
Andy Shevchenko

Baranowska, BeataX

author

2016-06-01 05:12 UTC #2 lore raw

Quoted 16 lines

-----Original Message-----
From: Andy Shevchenko [mailto:[email protected]]
Sent: Tuesday, May 31, 2016 5:47 PM
To: Baranowska, BeataX <[email protected]>
Cc: Hunter, Adrian <[email protected]>; Ulf Hansson <[email protected]>; [email protected]; linux- [email protected]; Dong, Chuanxiao <[email protected]>; Jarosz, SebastianX <[email protected]>
Subject: Re: [PATCH] mmc: host: use pr_err for sdhci_dumpregs
Quoted 4 lines · BeataX
From: Chuanxiao Dong <[email protected]>
sdhci_dumpregs is used to dump registers when error happens. Thus it should use pr_err instead of pr_debug to show more information about

Quoted 8 lines

the hardware.
Quoted 1 line
Wouldn't be too noisy?
--
With Best Regards,
Andy Shevchenko

It is when error happens so IMHO it should be well visible.

Regards,
Beata Baranowska

Adrian Hunter

maintainer Acked-by on v1 1/1

2016-06-15 11:32 UTC #3 lore raw

In reply to Baranowska, BeataX

Quoted 6 lines · BeataX

From: Chuanxiao Dong <[email protected]>
sdhci_dumpregs is used to dump registers when error happens. Thus it should use pr_err instead of pr_debug to show more information about the hardware.
Signed-off-by Chuanxiao Dong <[email protected]>

Acked-by Adrian Hunter <[email protected]>

Adrian Hunter

maintainer

2016-06-22 11:40 UTC #4 lore raw

PATCH v2 1/1 mmc: sdhci: use pr_err for sdhci_dumpregs

From: Chuanxiao Dong <[email protected]>

sdhci_dumpregs is used to dump registers when error happens. Thus it should use pr_err instead of pr_debug to show more information about the hardware.

Signed-off-by Chuanxiao Dong <[email protected]>

[Fix whitespace and checkpatch warnings]

Signed-off-by Adrian Hunter <[email protected]>

---

Changes in V2:

	Fix whitespace and checkpatch warnings
	Change subject 'host' -> 'sdhci'

 drivers/mmc/host/sdhci.c | 92 ++++++++++++++++++++++++------------------------
 1 file changed, 46 insertions(+), 46 deletions(-)

drivers/mmc/host/sdhci.c +46 ~~-46~~

index 040af1b6b412..49800d2c69fa 100644
@@ -52,58 +52,58 @@ static int sdhci_get_cd(struct mmc_host *mmc);
 
 static void sdhci_dumpregs(struct sdhci_host *host)
 {
-	pr_debug(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
-		mmc_hostname(host->mmc));
-
-	pr_debug(DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
-		sdhci_readl(host, SDHCI_DMA_ADDRESS),
-		sdhci_readw(host, SDHCI_HOST_VERSION));
-	pr_debug(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt:  0x%08x\n",
-		sdhci_readw(host, SDHCI_BLOCK_SIZE),
-		sdhci_readw(host, SDHCI_BLOCK_COUNT));
-	pr_debug(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n",
-		sdhci_readl(host, SDHCI_ARGUMENT),
-		sdhci_readw(host, SDHCI_TRANSFER_MODE));
-	pr_debug(DRIVER_NAME ": Present:  0x%08x | Host ctl: 0x%08x\n",
-		sdhci_readl(host, SDHCI_PRESENT_STATE),
-		sdhci_readb(host, SDHCI_HOST_CONTROL));
-	pr_debug(DRIVER_NAME ": Power:    0x%08x | Blk gap:  0x%08x\n",
-		sdhci_readb(host, SDHCI_POWER_CONTROL),
-		sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL));
-	pr_debug(DRIVER_NAME ": Wake-up:  0x%08x | Clock:    0x%08x\n",
-		sdhci_readb(host, SDHCI_WAKE_UP_CONTROL),
-		sdhci_readw(host, SDHCI_CLOCK_CONTROL));
-	pr_debug(DRIVER_NAME ": Timeout:  0x%08x | Int stat: 0x%08x\n",
-		sdhci_readb(host, SDHCI_TIMEOUT_CONTROL),
-		sdhci_readl(host, SDHCI_INT_STATUS));
-	pr_debug(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n",
-		sdhci_readl(host, SDHCI_INT_ENABLE),
-		sdhci_readl(host, SDHCI_SIGNAL_ENABLE));
-	pr_debug(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n",
-		sdhci_readw(host, SDHCI_ACMD12_ERR),
-		sdhci_readw(host, SDHCI_SLOT_INT_STATUS));
-	pr_debug(DRIVER_NAME ": Caps:     0x%08x | Caps_1:   0x%08x\n",
-		sdhci_readl(host, SDHCI_CAPABILITIES),
-		sdhci_readl(host, SDHCI_CAPABILITIES_1));
-	pr_debug(DRIVER_NAME ": Cmd:      0x%08x | Max curr: 0x%08x\n",
-		sdhci_readw(host, SDHCI_COMMAND),
-		sdhci_readl(host, SDHCI_MAX_CURRENT));
-	pr_debug(DRIVER_NAME ": Host ctl2: 0x%08x\n",
-		sdhci_readw(host, SDHCI_HOST_CONTROL2));
+	pr_err(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
+	       mmc_hostname(host->mmc));
+
+	pr_err(DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
+	       sdhci_readl(host, SDHCI_DMA_ADDRESS),
+	       sdhci_readw(host, SDHCI_HOST_VERSION));
+	pr_err(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt:  0x%08x\n",
+	       sdhci_readw(host, SDHCI_BLOCK_SIZE),
+	       sdhci_readw(host, SDHCI_BLOCK_COUNT));
+	pr_err(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n",
+	       sdhci_readl(host, SDHCI_ARGUMENT),
+	       sdhci_readw(host, SDHCI_TRANSFER_MODE));
+	pr_err(DRIVER_NAME ": Present:  0x%08x | Host ctl: 0x%08x\n",
+	       sdhci_readl(host, SDHCI_PRESENT_STATE),
+	       sdhci_readb(host, SDHCI_HOST_CONTROL));
+	pr_err(DRIVER_NAME ": Power:    0x%08x | Blk gap:  0x%08x\n",
+	       sdhci_readb(host, SDHCI_POWER_CONTROL),
+	       sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL));
+	pr_err(DRIVER_NAME ": Wake-up:  0x%08x | Clock:    0x%08x\n",
+	       sdhci_readb(host, SDHCI_WAKE_UP_CONTROL),
+	       sdhci_readw(host, SDHCI_CLOCK_CONTROL));
+	pr_err(DRIVER_NAME ": Timeout:  0x%08x | Int stat: 0x%08x\n",
+	       sdhci_readb(host, SDHCI_TIMEOUT_CONTROL),
+	       sdhci_readl(host, SDHCI_INT_STATUS));
+	pr_err(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n",
+	       sdhci_readl(host, SDHCI_INT_ENABLE),
+	       sdhci_readl(host, SDHCI_SIGNAL_ENABLE));
+	pr_err(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n",
+	       sdhci_readw(host, SDHCI_ACMD12_ERR),
+	       sdhci_readw(host, SDHCI_SLOT_INT_STATUS));
+	pr_err(DRIVER_NAME ": Caps:     0x%08x | Caps_1:   0x%08x\n",
+	       sdhci_readl(host, SDHCI_CAPABILITIES),
+	       sdhci_readl(host, SDHCI_CAPABILITIES_1));
+	pr_err(DRIVER_NAME ": Cmd:      0x%08x | Max curr: 0x%08x\n",
+	       sdhci_readw(host, SDHCI_COMMAND),
+	       sdhci_readl(host, SDHCI_MAX_CURRENT));
+	pr_err(DRIVER_NAME ": Host ctl2: 0x%08x\n",
+	       sdhci_readw(host, SDHCI_HOST_CONTROL2));
 
 	if (host->flags & SDHCI_USE_ADMA) {
 		if (host->flags & SDHCI_USE_64_BIT_DMA)
-			pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n",
-				 readl(host->ioaddr + SDHCI_ADMA_ERROR),
-				 readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI),
-				 readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
+			pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n",
+			       readl(host->ioaddr + SDHCI_ADMA_ERROR),
+			       readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI),
+			       readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
 		else
-			pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n",
-				 readl(host->ioaddr + SDHCI_ADMA_ERROR),
-				 readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
+			pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n",
+			       readl(host->ioaddr + SDHCI_ADMA_ERROR),
+			       readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
 	}
 
-	pr_debug(DRIVER_NAME ": ===========================================\n");
+	pr_err(DRIVER_NAME ": ===========================================\n");
 }
 
 /*****************************************************************************\

Signature · 1 line

1.9.1

Ulf Hansson

Applied

2016-06-22 15:23 UTC #5 lore raw

Re: [PATCH V2] mmc: sdhci: use pr_err for sdhci_dumpregs

Quoted 8 lines · Adrian Hunter

From: Chuanxiao Dong <[email protected]>
sdhci_dumpregs is used to dump registers when error happens. Thus it should use pr_err instead of pr_debug to show more information about the hardware.
Signed-off-by Chuanxiao Dong <[email protected]>
[Fix whitespace and checkpatch warnings]
Signed-off-by Adrian Hunter <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

Quoted 122 lines

---

Changes in V2:

Fix whitespace and checkpatch warnings
Change subject 'host' -> 'sdhci'

 drivers/mmc/host/sdhci.c | 92 ++++++++++++++++++++++++------------------------
 1 file changed, 46 insertions(+), 46 deletions(-)

drivers/mmc/host/sdhci.c +46 ~~-47~~

index 040af1b6b412..49800d2c69fa 100644
@@ -52,58 +52,58 @@ static int sdhci_get_cd(struct mmc_host *mmc);
 
 static void sdhci_dumpregs(struct sdhci_host *host)
 {
-       pr_debug(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
-               mmc_hostname(host->mmc));
-
-       pr_debug(DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
-               sdhci_readl(host, SDHCI_DMA_ADDRESS),
-               sdhci_readw(host, SDHCI_HOST_VERSION));
-       pr_debug(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt:  0x%08x\n",
-               sdhci_readw(host, SDHCI_BLOCK_SIZE),
-               sdhci_readw(host, SDHCI_BLOCK_COUNT));
-       pr_debug(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n",
-               sdhci_readl(host, SDHCI_ARGUMENT),
-               sdhci_readw(host, SDHCI_TRANSFER_MODE));
-       pr_debug(DRIVER_NAME ": Present:  0x%08x | Host ctl: 0x%08x\n",
-               sdhci_readl(host, SDHCI_PRESENT_STATE),
-               sdhci_readb(host, SDHCI_HOST_CONTROL));
-       pr_debug(DRIVER_NAME ": Power:    0x%08x | Blk gap:  0x%08x\n",
-               sdhci_readb(host, SDHCI_POWER_CONTROL),
-               sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL));
-       pr_debug(DRIVER_NAME ": Wake-up:  0x%08x | Clock:    0x%08x\n",
-               sdhci_readb(host, SDHCI_WAKE_UP_CONTROL),
-               sdhci_readw(host, SDHCI_CLOCK_CONTROL));
-       pr_debug(DRIVER_NAME ": Timeout:  0x%08x | Int stat: 0x%08x\n",
-               sdhci_readb(host, SDHCI_TIMEOUT_CONTROL),
-               sdhci_readl(host, SDHCI_INT_STATUS));
-       pr_debug(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n",
-               sdhci_readl(host, SDHCI_INT_ENABLE),
-               sdhci_readl(host, SDHCI_SIGNAL_ENABLE));
-       pr_debug(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n",
-               sdhci_readw(host, SDHCI_ACMD12_ERR),
-               sdhci_readw(host, SDHCI_SLOT_INT_STATUS));
-       pr_debug(DRIVER_NAME ": Caps:     0x%08x | Caps_1:   0x%08x\n",
-               sdhci_readl(host, SDHCI_CAPABILITIES),
-               sdhci_readl(host, SDHCI_CAPABILITIES_1));
-       pr_debug(DRIVER_NAME ": Cmd:      0x%08x | Max curr: 0x%08x\n",
-               sdhci_readw(host, SDHCI_COMMAND),
-               sdhci_readl(host, SDHCI_MAX_CURRENT));
-       pr_debug(DRIVER_NAME ": Host ctl2: 0x%08x\n",
-               sdhci_readw(host, SDHCI_HOST_CONTROL2));
+       pr_err(DRIVER_NAME ": =========== REGISTER DUMP (%s)===========\n",
+              mmc_hostname(host->mmc));
+
+       pr_err(DRIVER_NAME ": Sys addr: 0x%08x | Version:  0x%08x\n",
+              sdhci_readl(host, SDHCI_DMA_ADDRESS),
+              sdhci_readw(host, SDHCI_HOST_VERSION));
+       pr_err(DRIVER_NAME ": Blk size: 0x%08x | Blk cnt:  0x%08x\n",
+              sdhci_readw(host, SDHCI_BLOCK_SIZE),
+              sdhci_readw(host, SDHCI_BLOCK_COUNT));
+       pr_err(DRIVER_NAME ": Argument: 0x%08x | Trn mode: 0x%08x\n",
+              sdhci_readl(host, SDHCI_ARGUMENT),
+              sdhci_readw(host, SDHCI_TRANSFER_MODE));
+       pr_err(DRIVER_NAME ": Present:  0x%08x | Host ctl: 0x%08x\n",
+              sdhci_readl(host, SDHCI_PRESENT_STATE),
+              sdhci_readb(host, SDHCI_HOST_CONTROL));
+       pr_err(DRIVER_NAME ": Power:    0x%08x | Blk gap:  0x%08x\n",
+              sdhci_readb(host, SDHCI_POWER_CONTROL),
+              sdhci_readb(host, SDHCI_BLOCK_GAP_CONTROL));
+       pr_err(DRIVER_NAME ": Wake-up:  0x%08x | Clock:    0x%08x\n",
+              sdhci_readb(host, SDHCI_WAKE_UP_CONTROL),
+              sdhci_readw(host, SDHCI_CLOCK_CONTROL));
+       pr_err(DRIVER_NAME ": Timeout:  0x%08x | Int stat: 0x%08x\n",
+              sdhci_readb(host, SDHCI_TIMEOUT_CONTROL),
+              sdhci_readl(host, SDHCI_INT_STATUS));
+       pr_err(DRIVER_NAME ": Int enab: 0x%08x | Sig enab: 0x%08x\n",
+              sdhci_readl(host, SDHCI_INT_ENABLE),
+              sdhci_readl(host, SDHCI_SIGNAL_ENABLE));
+       pr_err(DRIVER_NAME ": AC12 err: 0x%08x | Slot int: 0x%08x\n",
+              sdhci_readw(host, SDHCI_ACMD12_ERR),
+              sdhci_readw(host, SDHCI_SLOT_INT_STATUS));
+       pr_err(DRIVER_NAME ": Caps:     0x%08x | Caps_1:   0x%08x\n",
+              sdhci_readl(host, SDHCI_CAPABILITIES),
+              sdhci_readl(host, SDHCI_CAPABILITIES_1));
+       pr_err(DRIVER_NAME ": Cmd:      0x%08x | Max curr: 0x%08x\n",
+              sdhci_readw(host, SDHCI_COMMAND),
+              sdhci_readl(host, SDHCI_MAX_CURRENT));
+       pr_err(DRIVER_NAME ": Host ctl2: 0x%08x\n",
+              sdhci_readw(host, SDHCI_HOST_CONTROL2));
 
        if (host->flags & SDHCI_USE_ADMA) {
                if (host->flags & SDHCI_USE_64_BIT_DMA)
-                       pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n",
-                                readl(host->ioaddr + SDHCI_ADMA_ERROR),
-                                readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI),
-                                readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
+                       pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x%08x\n",
+                              readl(host->ioaddr + SDHCI_ADMA_ERROR),
+                              readl(host->ioaddr + SDHCI_ADMA_ADDRESS_HI),
+                              readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
                else
-                       pr_debug(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n",
-                                readl(host->ioaddr + SDHCI_ADMA_ERROR),
-                                readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
+                       pr_err(DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n",
+                              readl(host->ioaddr + SDHCI_ADMA_ERROR),
+                              readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
        }
 
-       pr_debug(DRIVER_NAME ": ===========================================\n");
+       pr_err(DRIVER_NAME ": ===========================================\n");
 }
 
 /*****************************************************************************\
--

1.9.1