Skip to contentSkip to conversation

x86: baytrail: Introduce a Kconfig option for the internal UART

PATCH New Bin Meng 3 participants 8 messages Jun 15, 2016 – Jun 17, 2016 x86

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/2 x86: baytrail: Introduce a Kconfig option for the internal UART

There are quite a number of BayTrail boards that uses an external SuperIO chipset to provide the legacy UART. For such cases, it's better to have a Kconfig option to enable the internal UART.

So far BayleyBay and MinnowMax boards are using internal UART as the U-Boot console, enable this on these two boards.

Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/cpu/baytrail/Kconfig | 11 +++++++++++
 configs/bayleybay_defconfig   |  1 +
 configs/minnowmax_defconfig   |  1 +
 3 files changed, 13 insertions(+)
arch/x86/cpu/baytrail/Kconfig +11 -0
index 407feb2..1c8ac37 100644
@@ -7,3 +7,14 @@
 config INTEL_BAYTRAIL
 	bool
 	select HAVE_FSP if !EFI
+
+if INTEL_BAYTRAIL
+config INTERNAL_UART
+	bool "Enable the SoC integrated legacy UART"
+	help
+	  There is a legacy UART integrated into the Bay Trail SoC.
+	  A maximum baud rate of 115200 bps is supported. For this
+	  reason, it is recommended that the UART port be used for
+	  debug purposes only, eg: U-Boot console.
+
+endif
configs/bayleybay_defconfig +1 -0
index 9f1d7fb..0a71bb8 100644
@@ -2,6 +2,7 @@ CONFIG_X86=y
 CONFIG_VENDOR_INTEL=y
 CONFIG_DEFAULT_DEVICE_TREE="bayleybay"
 CONFIG_TARGET_BAYLEYBAY=y
+CONFIG_INTERNAL_UART=y
 CONFIG_HAVE_INTEL_ME=y
 CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
configs/minnowmax_defconfig +1 -0
index 28b837d..ba2b7dc 100644
@@ -2,6 +2,7 @@ CONFIG_X86=y
 CONFIG_VENDOR_INTEL=y
 CONFIG_DEFAULT_DEVICE_TREE="minnowmax"
 CONFIG_TARGET_MINNOWMAX=y
+CONFIG_INTERNAL_UART=y
 CONFIG_HAVE_INTEL_ME=y
 CONFIG_ENABLE_MRC_CACHE=y
 CONFIG_SMP=y
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/2 x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART

For any FSP enabled boards that want to enable debug UART support, setup_internal_uart() will be called, but this API is only available on BayTrail platform. Change to wrap it with CONFIG_INTERNAL_UART.

Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/lib/fsp/fsp_support.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/lib/fsp/fsp_support.c +1 -1
index b05dced..a480361 100644
@@ -110,7 +110,7 @@ void fsp_init(u32 stack_top, u32 boot_mode, void *nvs_buf)
 	struct upd_region *fsp_upd;
 #endif
 
-#ifdef CONFIG_DEBUG_UART
+#ifdef CONFIG_INTERNAL_UART
 	setup_internal_uart(1);
 #endif
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/2 x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART

Quoted 5 lines · Bin Meng

For any FSP enabled boards that want to enable debug UART support, setup_internal_uart() will be called, but this API is only available on BayTrail platform. Change to wrap it with CONFIG_INTERNAL_UART.

Signed-off-by Bin Meng <[email protected]>
Reviewed-by Stefan Roese <[email protected]>

Thanks,
Stefan

#3 lore raw

PATCH 2/2 x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART

In reply to Bin Meng
Quoted 9 lines · Bin Meng

For any FSP enabled boards that want to enable debug UART support, setup_internal_uart() will be called, but this API is only available on BayTrail platform. Change to wrap it with CONFIG_INTERNAL_UART.

Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/lib/fsp/fsp_support.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

nit: FSP-enabled

Reviewed-by Simon Glass <[email protected]>
author
#4 lore raw

PATCH 2/2 x86: fsp: Wrap setup_internal_uart() call with CONFIG_INTERNAL_UART

Quoted 5 lines · Simon Glass
Quoted 4 lines · Bin Meng

For any FSP enabled boards that want to enable debug UART support, setup_internal_uart() will be called, but this API is only available on BayTrail platform. Change to wrap it with CONFIG_INTERNAL_UART.

Quoted 8 lines
Quoted 5 lines
Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/lib/fsp/fsp_support.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

nit: FSP-enabled

Fixed the nits, and

Quoted 1 line
Reviewed-by Simon Glass <[email protected]>

applied to u-boot-x86/next, thanks!

#5 lore raw

PATCH 1/2 x86: baytrail: Introduce a Kconfig option for the internal UART

In reply to Bin Meng
Quoted 8 lines · Bin Meng

There are quite a number of BayTrail boards that uses an external SuperIO chipset to provide the legacy UART. For such cases, it's better to have a Kconfig option to enable the internal UART.

So far BayleyBay and MinnowMax boards are using internal UART as the U-Boot console, enable this on these two boards.

Signed-off-by Bin Meng <[email protected]>
Reviewed-by Stefan Roese <[email protected]>

Thanks,
Stefan

#6 lore raw

PATCH 1/2 x86: baytrail: Introduce a Kconfig option for the internal UART

In reply to Bin Meng
Quoted 7 lines · Bin Meng

There are quite a number of BayTrail boards that uses an external SuperIO chipset to provide the legacy UART. For such cases, it's better to have a Kconfig option to enable the internal UART.

So far BayleyBay and MinnowMax boards are using internal UART as the U-Boot console, enable this on these two boards.

Quoted 7 lines
Signed-off-by Bin Meng <[email protected]>

---

 arch/x86/cpu/baytrail/Kconfig | 11 +++++++++++
 configs/bayleybay_defconfig   |  1 +
 configs/minnowmax_defconfig   |  1 +
 3 files changed, 13 insertions(+)
Reviewed-by Simon Glass <[email protected]>
author
#7 lore raw

PATCH 1/2 x86: baytrail: Introduce a Kconfig option for the internal UART

Quoted 11 lines · Simon Glass
Quoted 10 lines · Bin Meng

There are quite a number of BayTrail boards that uses an external SuperIO chipset to provide the legacy UART. For such cases, it's better to have a Kconfig option to enable the internal UART.

So far BayleyBay and MinnowMax boards are using internal UART as the U-Boot console, enable this on these two boards.

Signed-off-by Bin Meng <[email protected]>

---

Quoted 6 lines
Quoted 4 lines
 arch/x86/cpu/baytrail/Kconfig | 11 +++++++++++
 configs/bayleybay_defconfig   |  1 +
 configs/minnowmax_defconfig   |  1 +
 3 files changed, 13 insertions(+)
Reviewed-by Simon Glass <[email protected]>

applied to u-boot-x86/next, thanks!