common: add new boot media kconfig entry

PATCH New Peng Fan 3 participants 5 messages Jun 15, 2016 – Jun 17, 2016

lore

Share & tools

lore

Peng Fan

author

2016-06-15 06:15 UTC #0 lore raw

PATCH 1/1 common: add new boot media kconfig entry

Add CONFIG_{SD|NOR|NAND|ONENAND|SPI|QSPI|SATA}_BOOT kconfig entries.

SoCs supports loading U-Boot from different medias to DRAM, such as i.MX6/7 supports loading U-Boot to DRAM from sd/emmc/nand/qspi/spi/sata and etc. For i.MX, imximage will generate different IVT headers according to boot medias.

Signed-off-by Peng Fan <[email protected]>

Cc Simon Glass <[email protected]>

Cc Heiko Schocher <[email protected]>

Cc Joe Hershberger <[email protected]>

Cc Bin Meng <[email protected]>

Cc Christophe Ricard <[email protected]>

Cc Nikita Kiryanov <[email protected]>

Cc Francois Retief <[email protected]>

Cc Tom Rini <[email protected]>

---
 common/Kconfig | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

common/Kconfig +46 -0

index 4d17b10..a41b670 100644
@@ -97,6 +97,52 @@ config BOOTSTAGE_STASH_SIZE
 
 endmenu
 
+menu "Boot media"
+
+config SD_BOOT
+	bool "Boot from SD"
+	default n
+	help
+	  U-Boot image is stored in SD card.
+
+config NOR_BOOT
+	bool "Boot from NOR"
+	default n
+	help
+	  U-Boot image is stored in NOR flash.
+
+config NAND_BOOT
+	bool "Boot from NAND"
+	default n
+	help
+	  U-Boot image is stored in NAND flash.
+
+config ONENAND_BOOT
+	bool "Boot from ONENAND"
+	default n
+	help
+	  U-Boot image is stored in ONENAND flash.
+
+config SPI_BOOT
+	bool "Boot from SPI"
+	default n
+	help
+	  U-Boot image is stored in SPI flash.
+
+config QSPI_BOOT
+	bool "Boot from QSPI"
+	default n
+	help
+	  U-Boot image is stored in QSPI flash.
+
+config SATA_BOOT
+	bool "Boot from SATA"
+	default n
+	help
+	  U-Boot image is stored in SATA.
+
+endmenu
+
 config BOOTDELAY
 	int "delay in seconds before automatically booting"
 	default 0

Signature · 1 line

2.6.2

Joe Hershberger

2016-06-15 15:11 UTC #1 lore raw

PATCH 1/1 common: add new boot media kconfig entry

Hi Peng,

Quoted 7 lines · Peng Fan

Add CONFIG_{SD|NOR|NAND|ONENAND|SPI|QSPI|SATA}_BOOT kconfig entries.
SoCs supports loading U-Boot from different medias to DRAM, such as i.MX6/7 supports loading U-Boot to DRAM from sd/emmc/nand/qspi/spi/sata and etc. For i.MX, imximage will generate different IVT headers according to boot medias.

Quoted 9 lines

Signed-off-by Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>
Cc Heiko Schocher <[email protected]>
Cc Joe Hershberger <[email protected]>
Cc Bin Meng <[email protected]>
Cc Christophe Ricard <[email protected]>
Cc Nikita Kiryanov <[email protected]>
Cc Francois Retief <[email protected]>
Cc Tom Rini <[email protected]>

Seems you need to run tools/moveconfig.py

Cheers,
-Joe

Peng Fan

author

2016-06-17 06:33 UTC #2 lore raw

PATCH 1/1 common: add new boot media kconfig entry

Hi Joe,

Quoted 20 lines · Joe Hershberger

Hi Peng,
Quoted 7 lines · Peng Fan
Add CONFIG_{SD|NOR|NAND|ONENAND|SPI|QSPI|SATA}_BOOT kconfig entries.
SoCs supports loading U-Boot from different medias to DRAM, such as i.MX6/7 supports loading U-Boot to DRAM from sd/emmc/nand/qspi/spi/sata and etc. For i.MX, imximage will generate different IVT headers according to boot medias.
Quoted 9 lines
Signed-off-by Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>
Cc Heiko Schocher <[email protected]>
Cc Joe Hershberger <[email protected]>
Cc Bin Meng <[email protected]>
Cc Christophe Ricard <[email protected]>
Cc Nikita Kiryanov <[email protected]>
Cc Francois Retief <[email protected]>
Cc Tom Rini <[email protected]>

Quoted 1 line

Seems you need to run tools/moveconfig.py

Thanks. I'll do this and refine my patch.

Thanks,
Peng.

Quoted 3 lines

Cheers,
-Joe

Heiko Schocher

2016-06-15 15:34 UTC #3 lore raw

PATCH 1/1 common: add new boot media kconfig entry

In reply to Peng Fan

Hello Peng,

Am 15.06.2016 um 08:15 schrieb Peng Fan:

Quoted 16 lines

Add CONFIG_{SD|NOR|NAND|ONENAND|SPI|QSPI|SATA}_BOOT kconfig entries.
SoCs supports loading U-Boot from different medias to DRAM, such as i.MX6/7 supports loading U-Boot to DRAM from sd/emmc/nand/qspi/spi/sata and etc. For i.MX, imximage will generate different IVT headers according to boot medias.
Signed-off-by Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>
Cc Heiko Schocher <[email protected]>
Cc Joe Hershberger <[email protected]>
Cc Bin Meng <[email protected]>
Cc Christophe Ricard <[email protected]>
Cc Nikita Kiryanov <[email protected]>
Cc Francois Retief <[email protected]>
Cc Tom Rini <[email protected]>

Quoted 3 lines

---
  common/Kconfig | 46 ++++++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 46 insertions(+)

Hmm... are there no places where the introduced config options already used in config files ?

Quoted 11 lines

common/Kconfig +3 -0

index 4d17b10..a41b670 100644
@@ -97,6 +97,52 @@ config BOOTSTAGE_STASH_SIZE
 
  endmenu
 
+menu "Boot media"
+
+config SD_BOOT

common/Kconfig config BOOTSTAGE_STASH_SIZE · line 112

Quoted 10 lines

common/Kconfig +10 -0

+	bool "Boot from SD"
+	default n
+	help
+	  U-Boot image is stored in SD card.
+
+config NOR_BOOT
+	bool "Boot from NOR"
+	default n
+	help
+	  U-Boot image is stored in NOR flash.

For example this is already defined in

./board/ti/am335x/Kconfig

So I miss at least the lines, which remove this part in your patch, else I think, this would lead in a Kconfig error, if we have the same symbol in two places ... or?

Quoted 27 lines

common/Kconfig +26 -0

+
+config NAND_BOOT
+	bool "Boot from NAND"
+	default n
+	help
+	  U-Boot image is stored in NAND flash.
+
+config ONENAND_BOOT
+	bool "Boot from ONENAND"
+	default n
+	help
+	  U-Boot image is stored in ONENAND flash.
+
+config SPI_BOOT
+	bool "Boot from SPI"
+	default n
+	help
+	  U-Boot image is stored in SPI flash.
+
+config QSPI_BOOT
+	bool "Boot from QSPI"
+	default n
+	help
+	  U-Boot image is stored in QSPI flash.
+
+config SATA_BOOT

common/Kconfig config BOOTSTAGE_STASH_SIZE · line 148

Quoted 10 lines

common/Kconfig +7 -0

+	bool "Boot from SATA"
+	default n
+	help
+	  U-Boot image is stored in SATA.
+
+endmenu
+
  config BOOTDELAY
  	int "delay in seconds before automatically booting"
  	default 0

may you want to use my brand new tbot testcase [1] for testing, if your patch not breaks boards?

bye,
Heiko
[1] http://lists.denx.de/pipermail/u-boot/2016-June/258119.html

Signature · 2 lines

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Peng Fan

author

2016-06-17 06:37 UTC #4 lore raw

PATCH 1/1 common: add new boot media kconfig entry

Hello Heiko,

Quoted 50 lines · Heiko Schocher

Hello Peng,
Am 15.06.2016 um 08:15 schrieb Peng Fan:
Quoted 16 lines
Add CONFIG_{SD|NOR|NAND|ONENAND|SPI|QSPI|SATA}_BOOT kconfig entries.
SoCs supports loading U-Boot from different medias to DRAM, such as i.MX6/7 supports loading U-Boot to DRAM from sd/emmc/nand/qspi/spi/sata and etc. For i.MX, imximage will generate different IVT headers according to boot medias.
Signed-off-by Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>
Cc Heiko Schocher <[email protected]>
Cc Joe Hershberger <[email protected]>
Cc Bin Meng <[email protected]>
Cc Christophe Ricard <[email protected]>
Cc Nikita Kiryanov <[email protected]>
Cc Francois Retief <[email protected]>
Cc Tom Rini <[email protected]>
Quoted 3 lines
---
 common/Kconfig | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)
Hmm... are there no places where the introduced config options already used in config files ?
Quoted 11 lines
common/Kconfig +3 -0
index 4d17b10..a41b670 100644
@@ -97,6 +97,52 @@ config BOOTSTAGE_STASH_SIZE
 
 endmenu
 
+menu "Boot media"
+
+config SD_BOOT
common/Kconfig config BOOTSTAGE_STASH_SIZE · line 112
Quoted 10 lines
common/Kconfig +10 -0
+	bool "Boot from SD"
+	default n
+	help
+	  U-Boot image is stored in SD card.
+
+config NOR_BOOT
+	bool "Boot from NOR"
+	default n
+	help
+	  U-Boot image is stored in NOR flash.
For example this is already defined in

Quoted 1 line

./board/ti/am335x/Kconfig

My bad.

Quoted 4 lines

So I miss at least the lines, which remove this part in your patch, else I think, this would lead in a Kconfig error, if we have the same symbol in two places ... or?

I did not check other Kconfig files. The idea is to introduce config entries to support booting uboot from nand/nor/sd/spi and etc.

I'll take care in V2.

Quoted 33 lines

common/Kconfig +32 -0

+
+config NAND_BOOT
+	bool "Boot from NAND"
+	default n
+	help
+	  U-Boot image is stored in NAND flash.
+
+config ONENAND_BOOT
+	bool "Boot from ONENAND"
+	default n
+	help
+	  U-Boot image is stored in ONENAND flash.
+
+config SPI_BOOT
+	bool "Boot from SPI"
+	default n
+	help
+	  U-Boot image is stored in SPI flash.
+
+config QSPI_BOOT
+	bool "Boot from QSPI"
+	default n
+	help
+	  U-Boot image is stored in QSPI flash.
+
+config SATA_BOOT
+	bool "Boot from SATA"
+	default n
+	help
+	  U-Boot image is stored in SATA.
+
+endmenu

Quoted 8 lines

common/Kconfig config BOOTSTAGE_STASH_SIZE · line 148
Quoted 5 lines
common/Kconfig +1 -0
+
 config BOOTDELAY
 	int "delay in seconds before automatically booting"
 	default 0
may you want to use my brand new tbot testcase [1] for testing, if your patch not breaks boards?

I'll try this.

Thanks,
Peng.

Quoted 7 lines

bye,
Heiko
[1] http://lists.denx.de/pipermail/u-boot/2016-June/258119.html
Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany