Skip to contentSkip to conversation

arm: lib: Fix fix push/pop-section directives

PATCH New Marek Vasut 3 participants 3 messages Jun 4, 2016 – Jun 16, 2016 Arm (32-bit)

lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/1 arm: lib: Fix fix push/pop-section directives

Repair typos in the previous "arm: lib: fix push/pop-section directives" patch, which prevented VCMA9 board from building.

Signed-off-by Marek Vasut <[email protected]>
Fixes b2f1858455e9 ("arm: lib: fix push/pop-section directives")
Cc Tom Warren <[email protected]>
Cc Simon Glass <[email protected]>
Cc Masahiro Yamada <[email protected]>
Cc Stephen Warren <[email protected]>
---
 arch/arm/lib/lib1funcs.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/lib/lib1funcs.S +2 -2
index 9bf93ce..76968ce 100644
@@ -367,9 +367,9 @@ UNWIND(.fnend)
 ENDPROC(Ldiv0)
 .popsection
 
-.pushsection .text.__gnu_thumb1_case_sqi, "ax"
 /* Thumb-1 specialities */
 #if defined(CONFIG_SYS_THUMB_BUILD) && !defined(CONFIG_HAS_THUMB2)
+.pushsection .text.__gnu_thumb1_case_sqi, "ax"
 ENTRY(__gnu_thumb1_case_sqi)
 	push	{r1}
 	mov	r1, lr

@@ -383,7 +383,7 @@ ENTRY(__gnu_thumb1_case_sqi)
 ENDPROC(__gnu_thumb1_case_sqi)
 .popsection
 
-_.pushsection .text.__gnu_thumb1_case_uqi, "ax"
+.pushsection .text.__gnu_thumb1_case_uqi, "ax"
 ENTRY(__gnu_thumb1_case_uqi)
 	push	{r1}
 	mov	r1, lr
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 arm: lib: Fix fix push/pop-section directives

Hello Marek,

Am 05.06.2016 um 00:46 schrieb Marek Vasut:

Quoted 9 lines

Repair typos in the previous "arm: lib: fix push/pop-section directives" patch, which prevented VCMA9 board from building.

Signed-off-by Marek Vasut <[email protected]>
Fixes b2f1858455e9 ("arm: lib: fix push/pop-section directives")
Cc Tom Warren <[email protected]>
Cc Simon Glass <[email protected]>
Cc Masahiro Yamada <[email protected]>
Cc Stephen Warren <[email protected]>
Quoted 3 lines
---
  arch/arm/lib/lib1funcs.S | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks! Fixes compile problems on on the axm, taurus boards. Tested current mainline on them with this fix:

Tested-by Heiko Schocher <[email protected]>

bye,
Heiko

Quoted 26 lines
arch/arm/lib/lib1funcs.S +2 -2
index 9bf93ce..76968ce 100644
@@ -367,9 +367,9 @@ UNWIND(.fnend)
  ENDPROC(Ldiv0)
  .popsection
 
-.pushsection .text.__gnu_thumb1_case_sqi, "ax"
  /* Thumb-1 specialities */
  #if defined(CONFIG_SYS_THUMB_BUILD) && !defined(CONFIG_HAS_THUMB2)
+.pushsection .text.__gnu_thumb1_case_sqi, "ax"
  ENTRY(__gnu_thumb1_case_sqi)
  	push	{r1}
  	mov	r1, lr

@@ -383,7 +383,7 @@ ENTRY(__gnu_thumb1_case_sqi)
  ENDPROC(__gnu_thumb1_case_sqi)
  .popsection
 
-_.pushsection .text.__gnu_thumb1_case_uqi, "ax"
+.pushsection .text.__gnu_thumb1_case_uqi, "ax"
  ENTRY(__gnu_thumb1_case_uqi)
  	push	{r1}
  	mov	r1, lr
Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#2 lore raw

PATCH 1/1 arm: lib: Fix fix push/pop-section directives

In reply to Marek Vasut
Quoted 2 lines · Marek Vasut

Repair typos in the previous "arm: lib: fix push/pop-section directives" patch, which prevented VCMA9 board from building.

Reviewed-by Stephen Warren <[email protected]>

Oops, I evidently didn't re-run buildman on enough boards after I fixed up some other typos:-(