Skip to contentSkip to conversation

SPL ext: cosmetic: correct error message in spl_load_image_ext()

PATCH Superseded Petr Kulhavy 3 participants 3 messages Jun 14, 2016 – Jun 17, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SPL ext: cosmetic: correct error message in spl_load_image_ext()

Correct the error message in spl_load_image_ext() when image parsing fails. Instead of "ext4fs_read failed" print "failed to parse image header".

CC Guillaume GARDET <[email protected]>
---
 common/spl/spl_ext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl_ext.c +1 -1
index ade5496..074b31e 100644
@@ -50,7 +50,7 @@ int spl_load_image_ext(struct blk_desc *block_dev,
 
 	err = spl_parse_image_header(header);
 	if (err < 0) {
-		puts("spl: ext4fs_read failed\n");
+		puts("spl: failed to parse image header\n");
 		goto end;
 	}
 
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 SPL ext: cosmetic: correct error message in spl_load_image_ext()

Le 14/06/2016 11:44, Petr Kulhavy a ?crit :

Quoted 6 lines

Correct the error message in spl_load_image_ext() when image parsing fails. Instead of "ext4fs_read failed" print "failed to parse image header".

CC Guillaume GARDET <[email protected]>
Quoted 17 lines
---
  common/spl/spl_ext.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl_ext.c +1 -1
index ade5496..074b31e 100644
@@ -50,7 +50,7 @@ int spl_load_image_ext(struct blk_desc *block_dev,
 
  	err = spl_parse_image_header(header);
  	if (err < 0) {
-		puts("spl: ext4fs_read failed\n");
+		puts("spl: failed to parse image header\n");
  		goto end;
  	}
 
#2 lore raw

PATCH 1/1 SPL ext: cosmetic: correct error message in spl_load_image_ext()

In reply to Petr Kulhavy
Quoted 15 lines · Petr Kulhavy

Correct the error message in spl_load_image_ext() when image parsing fails. Instead of "ext4fs_read failed" print "failed to parse image header".

CC Guillaume GARDET <[email protected]>
---
 common/spl/spl_ext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl_ext.c +0 -0
index ade5496..074b31e 100644

common/spl/spl_ext.c int spl_load_image_ext(struct blk_desc *block_dev, · line 53

Quoted 5 lines
common/spl/spl_ext.c +1 -1
@@ -50,7 +50,7 @@ int spl_load_image_ext(struct blk_desc *block_dev,
 
 	err = spl_parse_image_header(header);
 	if (err < 0) {
-		puts("spl: ext4fs_read failed\n");
+		puts("spl: failed to parse image header\n");

Can you please make this: "spl: ext: failed to parse image header" so that when encountered someone knows it's in the ext path? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160617/b790fe92/attachment.sig>