mx7dsabresd: Fix LCD_PWR_EN output setting
PATCH 1/4 mx7dsabresd: Fix LCD_PWR_EN output setting
From: Ye Li <[email protected]>
LCD_PWR_EN controls the G pin of Q13 PMOS which needs low voltage to connect D to S for outputting LCD 3.3V. If LCD_PWR_EN is high, we measured the LCD 3v3 is actually 1.2V.
--- board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx7dsabresd/mx7dsabresd.c +1 -1
@@ -171,7 +171,7 @@ static enum qn_level seq[3][2] = {static enum qn_func qn_output[8 ] = { qn_disable, qn_reset, qn_reset, qn_reset, qn_reset, qn_reset, qn_enable, - qn_enable + qn_disable };static void iox74lv_init (void )
Signature · 1 line
2.6.2
PATCH 2/4 imx6ulevk: fix 74LV OE usage
Fix 74LV OE gpio index. gpio index is wrong,
so gpio output will not have effect, since we
use wrong GPIO5_IO18, but not correct GPIO5_IO8.
And at the end of the initialization of 74lv init, should keep OE voltage level at LOW to make 74lv output the correct voltage.
--- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +1 -3
@@ -66,7 +66,7 @@ DECLARE_GLOBAL_DATA_PTR;#define IOX_SDI IMX_GPIO_NR(5, 10)#define IOX_STCP IMX_GPIO_NR(5, 7)#define IOX_SHCP IMX_GPIO_NR(5, 11) -#define IOX_OE IMX_GPIO_NR(5, 18) +#define IOX_OE IMX_GPIO_NR(5, 8)static iomux_v3_cfg_t const iox_pads[] = {/* IOX_SDI */
@@ -154,8 +154,6 @@ static void iox74lv_init(void)* shift register will be output to pins */ gpio_direction_output (IOX_STCP ,1 ); - -gpio_direction_output (IOX_OE ,1 ); };#ifdef CONFIG_SYS_I2C_MXC
Signature · 1 line
2.6.2
PATCH 2/4 imx6ulevk: fix 74LV OE usage
Quoted 11 lines · Peng Fan
Fix 74LV OE gpio index. gpio index is wrong,
so gpio output will not have effect, since we
use wrongGPIO5_IO18, but not correctGPIO5_IO8.And at the end of the initialization of 74lv init, should keep OE voltage level at LOW to make 74lv output the correct voltage.
Signed-off-by Peng Fan <[email protected]>Cc Stefano Babic <[email protected]>Cc Fabio Estevam <[email protected]>
PATCH 3/4 imx6ulevk: fix LCD_nPWREN setting
In reply to Peng FanQ901 is PMOS, LCD_nPWREN should be at low voltage then output is 3V3. If LCD_nPWREN is high, output is 2.4V which is not correct.
--- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +1 -1
@@ -117,7 +117,7 @@ static enum qn_level seq[3][2] = {static enum qn_func qn_output[8 ] = { qn_reset, qn_reset, qn_reset, qn_enable, qn_disable, qn_reset, - qn_disable, qn_enable + qn_disable, qn_disable };static void iox74lv_init (void )
Signature · 1 line
2.6.2
PATCH 3/4 imx6ulevk: fix LCD_nPWREN setting
Quoted 6 lines · Peng Fan
Q901 is PMOS,
LCD_nPWRENshould be at low voltage then output is 3V3. IfLCD_nPWRENis high, output is 2.4V which is not correct.Signed-off-by Peng Fan <[email protected]>Cc Stefano Babic <[email protected]>Cc Fabio Estevam <[email protected]>
PATCH 4/4 imx: mx6ulevk: change QSPI PAD DSE to 120ohm
In reply to Peng FanThe current pad DSE for QSPI is 60ohm. This setting cause too strong drive to clock and data signals. Need to change the DSE to 120ohm for better signal quality.
--- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +1 -1
@@ -303,7 +303,7 @@ static void setup_iomux_uart(void)#define QSPI_PAD_CTRL1 \ (PAD_CTL_SRE_FAST | PAD_CTL_SPEED_MED | \ - PAD_CTL_PKE | PAD_CTL_PUE | PAD_CTL_PUS_47K_UP | PAD_CTL_DSE_60ohm) + PAD_CTL_PKE | PAD_CTL_PUE | PAD_CTL_PUS_47K_UP | PAD_CTL_DSE_120ohm)static iomux_v3_cfg_t const quadspi_pads[] = {MX6_PAD_NAND_WP_B__QSPI_A_SCLK |MUX_PAD_CTRL (QSPI_PAD_CTRL1 ),
Signature · 1 line
2.6.2
PATCH 4/4 imx: mx6ulevk: change QSPI PAD DSE to 120ohm
Quoted 5 lines · Peng Fan
The current pad DSE for QSPI is 60ohm. This setting cause too strong drive to clock and data signals. Need to change the DSE to 120ohm for better signal quality.
Signed-off-by Peng Fan <[email protected]>
PATCH 1/4 mx7dsabresd: Fix LCD_PWR_EN output setting
In reply to Peng FanQuoted 10 lines · Peng Fan
From: Ye Li <[email protected]>
LCD_PWR_ENcontrols the G pin of Q13 PMOS which needs low voltage to connect D to S for outputting LCD 3.3V. IfLCD_PWR_ENis high, we measured the LCD 3v3 is actually 1.2V.Signed-off-by Ye Li <[email protected]>Signed-off-by Peng Fan <[email protected]>Cc Stefano Babic <[email protected]>Cc Fabio Estevam <[email protected]>
Stefano Babic
AppliedPATCH 1/4 mx7dsabresd: Fix LCD_PWR_EN output setting
In reply to Peng FanQuoted 20 lines · Peng Fan
From: Ye Li <[email protected]>
LCD_PWR_ENcontrols the G pin of Q13 PMOS which needs low voltage to connect D to S for outputting LCD 3.3V. IfLCD_PWR_ENis high, we measured the LCD 3v3 is actually 1.2V.Signed-off-by Ye Li <[email protected]>Signed-off-by Peng Fan <[email protected]>Cc Stefano Babic <[email protected]>Cc Fabio Estevam <[email protected]>--- board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)board/freescale/mx7dsabresd/mx7dsabresd.c +0
-0
board/freescale/mx7dsabresd/mx7dsabresd.c static enum qn_level seq[3][2] = { · line 177
Quoted 8 lines
board/freescale/mx7dsabresd/mx7dsabresd.c +1
-1@@ -171,7 +171,7 @@ static enum qn_level seq[3][2] = {static enum qn_func qn_output[8 ] = { qn_disable, qn_reset, qn_reset, qn_reset, qn_reset, qn_reset, qn_enable, - qn_enable + qn_disable };static void iox74lv_init (void )
Applied to master (bug fix), thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================