Skip to contentSkip to conversation

ARM: board: cm-fx6: fix mmc for old revisions of utilite

PATCH New Christopher Spinrath 3 participants 3 messages Jun 16, 2016 – Jun 18, 2016

lore
Share & tools
lore

Christopher Spinrath

author
#0 lore raw

PATCH v2 1/1 ARM: board: cm-fx6: fix mmc for old revisions of utilite

Old revisions of Utilite (based on cm-fx6) do not have a dedicated card detect pin. But the card is removable by the user and card detection can be realized with polling (e.g. supported by Linux).

Add the broken-cd property to the mmc device tree instead of the non-removable property to make card detection possible if polling is supported.

Signed-off-by Christopher Spinrath <[email protected]>
Acked-by Nikita Kiryanov <[email protected]>

---

Notes:
Changes since v1:
- remove Fixes: tag
- add Nikita's Acked-By

 board/compulab/cm_fx6/cm_fx6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/compulab/cm_fx6/cm_fx6.c +1 -1
index a21e7b0..712057a 100644
@@ -610,7 +610,7 @@ int ft_board_setup(void *blob, bd_t *bd)
 		fdt_shrink_to_minimum(blob); /* Make room for new properties */
 		nodeoffset = fdt_path_offset(blob, USDHC3_PATH);
 		fdt_delprop(blob, nodeoffset, "cd-gpios");
-		fdt_find_and_setprop(blob, USDHC3_PATH, "non-removable",
+		fdt_find_and_setprop(blob, USDHC3_PATH, "broken-cd",
 				     NULL, 0, 1);
 		fdt_find_and_setprop(blob, USDHC3_PATH, "keep-power-in-suspend",
 				     NULL, 0, 1);
Signature · 1 line
2.8.3
#1 lore raw

PATCH v2 1/1 ARM: board: cm-fx6: fix mmc for old revisions of utilite

Quoted 10 lines · Christopher Spinrath

Old revisions of Utilite (based on cm-fx6) do not have a dedicated card detect pin. But the card is removable by the user and card detection can be realized with polling (e.g. supported by Linux).

Add the broken-cd property to the mmc device tree instead of the non-removable property to make card detection possible if polling is supported.

Signed-off-by Christopher Spinrath <[email protected]>
Acked-by Nikita Kiryanov <[email protected]>
Acked-by Igor Grinberg <[email protected]>
Signature · 2 lines
Regards,
Igor.
Applied
#2 lore raw

PATCH v2 1/1 ARM: board: cm-fx6: fix mmc for old revisions of utilite

In reply to Christopher Spinrath
Quoted 11 lines · Christopher Spinrath

Old revisions of Utilite (based on cm-fx6) do not have a dedicated card detect pin. But the card is removable by the user and card detection can be realized with polling (e.g. supported by Linux).

Add the broken-cd property to the mmc device tree instead of the non-removable property to make card detection possible if polling is supported.

Signed-off-by Christopher Spinrath <[email protected]>
Acked-by Nikita Kiryanov <[email protected]>

---

Applied to master (bug fix), thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================