Skip to contentSkip to conversation

PM / devfreq: event: Fix return value check in exynos_nocp_parse_dt()

PATCH New weiyj_lk at 163.com 2 participants 2 messages Jun 17, 2016 – Jun 20, 2016

Subsystems (3)
Arm Samsung Exynos Device frequency (devfreq) Device frequency event (devfreq-event)
lore
Share & tools
lore

weiyj_lk at 163.com

author
#0 lore raw

PATCH 1/1 PM / devfreq: event: Fix return value check in exynos_nocp_parse_dt()

From: Wei Yongjun <[email protected]>

In case of error, the function platform_get_resource() returns NULL pointer not ERR_PTR(). Remove unneeded error handling on the result of a call to platform_get_resource() since the value is passed to devm_ioremap_resource().

Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/devfreq/event/exynos-nocp.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/devfreq/event/exynos-nocp.c +0 -3
index 6b6a5f3..a584140 100644
@@ -220,9 +220,6 @@ static int exynos_nocp_parse_dt(struct platform_device *pdev,
 
 	/* Maps the memory mapped IO to control nocp register */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (IS_ERR(res))
-		return PTR_ERR(res);
-
 	base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(base))
 		return PTR_ERR(base);
maintainer
#1 lore raw

PATCH 1/1 PM / devfreq: event: Fix return value check in exynos_nocp_parse_dt()

Hi Wei,

Quoted 6 lines · On 2016? 06? 18? 03:10, weiyj_lk at 163.com wrote:

From: Wei Yongjun <[email protected]>

In case of error, the function platform_get_resource() returns NULL pointer not ERR_PTR(). Remove unneeded error handling on the result of a call to platform_get_resource() since the value is passed to devm_ioremap_resource().

This same patch was already merged to devfreq git[1].

[1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=fixes&id=482c27865b9784831dad45b31c2b0a5c42376802

Thanks,
Chanwoo Choi

Quoted 30 lines
Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/devfreq/event/exynos-nocp.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/devfreq/event/exynos-nocp.c +0 -4
index 6b6a5f3..a584140 100644
@@ -220,9 +220,6 @@ static int exynos_nocp_parse_dt(struct platform_device *pdev,
 
 	/* Maps the memory mapped IO to control nocp register */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (IS_ERR(res))
-		return PTR_ERR(res);
-
 	base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(base))
 		return PTR_ERR(base);
 
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html