Skip to contentSkip to conversation

thermal: tango: add resume support

PATCH Superseded Mason 2 participants 3 messages Jun 20, 2016 – Jun 21, 2016 Thermal

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Mason

author
#0 lore raw

PATCH 1/1 thermal: tango: add resume support

From: Marc Gonzalez <[email protected]>

---
 drivers/thermal/tango_thermal.c | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)
drivers/thermal/tango_thermal.c +25 -2
index 70e0d9f406e9..d571ce2f546d 100644
@@ -64,6 +64,12 @@ static const struct thermal_zone_of_device_ops ops = {
 	.get_temp	= tango_get_temp,
 };
 
+static void tango_thermal_init(struct tango_thermal_priv *priv)
+{
+	writel(0, priv->base + TEMPSI_CFG);
+	writel(CMD_ON, priv->base + TEMPSI_CMD);
+}
+
 static int tango_thermal_probe(struct platform_device *pdev)
 {
 	struct resource *res;
@@ -79,14 +85,30 @@ static int tango_thermal_probe(struct platform_device *pdev)
 	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
 
+	platform_set_drvdata(pdev, priv);
 	priv->thresh_idx = IDX_MIN;
-	writel(0, priv->base + TEMPSI_CFG);
-	writel(CMD_ON, priv->base + TEMPSI_CMD);
+	tango_thermal_init(priv);
 
 	tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, priv, &ops);
 	return PTR_ERR_OR_ZERO(tzdev);
 }
 
+#ifdef CONFIG_PM_SLEEP
+static int tango_thermal_resume(struct device *dev)
+{
+	struct tango_thermal_priv *priv = dev_get_drvdata(dev);
+	tango_thermal_init(priv);
+
+	return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(tango_thermal_pm, NULL, tango_thermal_resume);
+
+#define DEV_PM_OPS	&tango_thermal_pm
+#else
+#define DEV_PM_OPS	NULL
+#endif
+
 static const struct of_device_id tango_sensor_ids[] = {
 	{
 		.compatible = "sigma,smp8758-thermal",
@@ -99,6 +121,7 @@ static struct platform_driver tango_thermal_driver = {
 	.driver	= {
 		.name		= "tango-thermal",
 		.of_match_table	= tango_sensor_ids,
+		.pm		= DEV_PM_OPS,
 	},
 };
 
Signature · 1 line
2.8.2
#1 lore raw
Quoted 3 lines · Mason

From: Marc Gonzalez <[email protected]>

Overall looks good, but as I mentioned in the RFC, since you don't have a ->suspend() method it looks suspicious, so at least the changelog should describe why you think that doesn't exist. For that matter, the changelog needs some more description of the patch well. :)

Kevin

author
#2 lore raw
Quoted 4 lines · Kevin Hilman

Overall looks good, but as I mentioned in the RFC, since you don't have a ->suspend() method it looks suspicious, so at least the changelog should describe why you think that doesn't exist. For that matter, the changelog needs some more description of the patch well. :)

Patch with improved commit message incoming.

Regards.