Skip to contentSkip to conversation

sockets: replace creating a new socket with the record one

RFC PATCH In review Wei Xu 1 participant 1 message Jun 22, 2016 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Wei Xu

author
#1 lore raw

RFC PATCH 3/3 sockets: replace creating a new socket with the record one

There has been comments on this patch, but i forgot adding this patch to the list, just forward it again.

Both server mode and client mode are supported.

Signed-off-by Wei Xu <[email protected]>
---
 util/qemu-sockets.c | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)
util/qemu-sockets.c +17 -8
index 0d6cd1f..e6429d7 100644
@@ -713,10 +713,14 @@ static int unix_listen_saddr(UnixSocketAddress *saddr,
     struct sockaddr_un un;
     int sock, fd;
 
-    sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
-    if (sock < 0) {
-        error_setg_errno(errp, errno, "Failed to create Unix socket");
-        return -1;
+    if (saddr->sockfd) {
+        sock = saddr->sockfd;
+    } else {
+        sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
+        if (sock < 0) {
+            error_setg_errno(errp, errno, "Failed to create Unix socket");
+            return -1;
+        }
     }
 
     memset(&un, 0, sizeof(un));

@@ -786,11 +790,16 @@ static int unix_connect_saddr(UnixSocketAddress *saddr, Error **errp,
         return -1;
     }
 
-    sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
-    if (sock < 0) {
-        error_setg_errno(errp, errno, "Failed to create socket");
-        return -1;
+    if (saddr->sockfd) {
+        sock = saddr->sockfd;
+    } else {
+        sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
+        if (sock < 0) {
+            error_setg_errno(errp, errno, "Failed to create socket");
+            return -1;
+        }
     }
+
     if (callback != NULL) {
         connect_state = g_malloc0(sizeof(*connect_state));
         connect_state->callback = callback;
Signature · 1 line
2.7.1