Skip to contentSkip to conversation

ARM: hisi: make unexported symbols static

PATCH New Ben Dooks 2 participants 2 messages Jun 21, 2016 – Jun 22, 2016

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/HiSilicon SoC support
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 ARM: hisi: make unexported symbols static

The two functions hix5hd2_set_scu_boot_addr() and hip01_set_boot_addr() are not declared or exported outside arch/arm/mach-hisi/platsmp.c file. Avoid the following warnings by making them static:

arch/arm/mach-hisi/platsmp.c:142:6: warning: symbol 'hip01_set_boot_addr' was not declared. Should it be static? arch/arm/mach-hisi/platsmp.c:106:6: warning: symbol 'hix5hd2_set_scu_boot_addr' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---
Cc: Wei Xu <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org

---
 arch/arm/mach-hisi/platsmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-hisi/platsmp.c +2 -2
index 47ed32c..e1d6764 100644
@@ -103,7 +103,7 @@ static void __init hisi_common_smp_prepare_cpus(unsigned int max_cpus)
 	hisi_enable_scu_a9();
 }
 
-void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_addr)
+static void hix5hd2_set_scu_boot_addr(phys_addr_t start_addr, phys_addr_t jump_addr)
 {
 	void __iomem *virt;
 

@@ -139,7 +139,7 @@ static const struct smp_operations hix5hd2_smp_ops __initconst = {
 #define HIP01_BOOT_ADDRESS     0x80000000
 #define REG_SC_CTRL            0x000
 
-void hip01_set_boot_addr(phys_addr_t start_addr, phys_addr_t jump_addr)
+static void hip01_set_boot_addr(phys_addr_t start_addr, phys_addr_t jump_addr)
 {
 	void __iomem *virt;
Signature · 1 line
2.8.1
maintainer
#1 lore raw

PATCH 1/1 ARM: hisi: make unexported symbols static

Hi Ben,

Quoted 8 lines · Ben Dooks

The two functions hix5hd2_set_scu_boot_addr() and hip01_set_boot_addr() are not declared or exported outside arch/arm/mach-hisi/platsmp.c file. Avoid the following warnings by making them static:

arch/arm/mach-hisi/platsmp.c:142:6: warning: symbol 'hip01_set_boot_addr' was not declared. Should it be static? arch/arm/mach-hisi/platsmp.c:106:6: warning: symbol 'hix5hd2_set_scu_boot_addr' was not declared. Should it be static?

Quoted 7 lines
Signed-off-by Ben Dooks <[email protected]>

---
Cc: Wei Xu <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org

---
 arch/arm/mach-hisi/platsmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks!
Applied to the hisilicon git tree.

Best Regards,
Wei