syscalls/removexattr02:skip the test if no xattr support

PATCH New [email protected] 2 participants 4 messages Jun 24, 2016

lore

Share & tools

lore

[email protected]

author

2016-06-24 03:36 UTC #0 lore raw

PATCH 1/1 syscalls/removexattr02:skip the test if no xattr support

From: Shuang Qiu <[email protected]>

Return TCONF if there is no xattr support in fs or mount without user_xattr option

Signed-off-by Shuang Qiu <[email protected]>

---
 .../kernel/syscalls/removexattr/removexattr02.c    |    4 ++++
 1 file changed, 4 insertions(+)

testcases/kernel/syscalls/removexattr/removexattr02.c +4 -0

index 58f310a..cea8733 100644
@@ -85,6 +85,10 @@ static void verify_removexattr(struct test_case *tc)
 {
 
 	TEST(removexattr(tc->path, tc->name));
+	if (TEST_RETURN == -1 && TEST_ERRNO == ENOTSUP)
+		tst_brkm(TCONF, cleanup, "No xattr support in fs or "
+			 "mount without user_xattr option");
+
 	if (TEST_RETURN != -1) {
 		tst_resm(TFAIL, "removexattr() succeeded unexpectedly");
 		return;

Signature · 1 line

1.7.9.5

Jan Stancek

2016-06-24 12:40 UTC #1 lore raw

PATCH 1/1 syscalls/removexattr02:skip the test if no xattr support

----- Original Message -----

Quoted 9 lines

From: "shuang qiu" <[email protected]>
To: [email protected]
Sent: Friday, 24 June, 2016 5:36:02 AM
Subject: [LTP] [PATCH] syscalls/removexattr02:skip the test if no xattr support
From: Shuang Qiu <[email protected]>
Return TCONF if there is no xattr support in fs or mount without user_xattr option

Why only in removexattr02? Should we do the same for removexattr01?

Regards,
Jan

Shuang Qiu

author

2016-06-24 13:20 UTC #2 lore raw

PATCH 1/1 syscalls/removexattr02:skip the test if no xattr support

Quoted 9 lines · Jan Stancek

----- Original Message -----
Quoted 5 lines
From: "shuang qiu" <[email protected]>
To: [email protected]
Sent: Friday, 24 June, 2016 5:36:02 AM
Subject: [LTP] [PATCH] syscalls/removexattr02:skip the test if no xattr support

Quoted 5 lines

Quoted 4 lines
From: Shuang Qiu <[email protected]>
Return TCONF if there is no xattr support in fs or mount without user_xattr option
Why only in removexattr02? Should we do the same for removexattr01?

removexattr01 already handle such situation.

Thanks
Shuang

Quoted 3 lines

Regards,
Jan

Jan Stancek

2016-06-24 13:25 UTC #3 lore raw

PATCH 1/1 syscalls/removexattr02:skip the test if no xattr support

----- Original Message -----

Quoted 17 lines

From: "Shuang Qiu" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected]
Sent: Friday, 24 June, 2016 3:20:32 PM
Subject: Re: [LTP] [PATCH] syscalls/removexattr02:skip the test if no xattr support
Quoted 10 lines · Jan Stancek
----- Original Message -----
Quoted 6 lines
From: "shuang qiu" <[email protected]>
To: [email protected]
Sent: Friday, 24 June, 2016 5:36:02 AM
Subject: [LTP] [PATCH] syscalls/removexattr02:skip the test if no xattr
support

Quoted 7 lines

Quoted 6 lines
Quoted 5 lines
From: Shuang Qiu <[email protected]>
Return TCONF if there is no xattr support in fs or mount without user_xattr
option
Why only in removexattr02? Should we do the same for removexattr01?
removexattr01 already handle such situation.

Sorry, I missed that. Pushed with curly brackets around if.

Regards,
Jan

Quoted 8 lines

Thanks
Shuang
Quoted 3 lines
Regards,
Jan