mmc: increase MMC SDHCI read status timeout
PATCH v2 1/1 mmc: increase MMC SDHCI read status timeout
Otherwise, ocassionally see errors like this:
Flashing sparse image at offset 2078720 Flashing Sparse Image
sdhci_send_command: Timeout for status update! mmc fail to send stop cmd
write_sparse_image: Write failed, block #2181088 [0]
This does not affect the actual writing speed, which is controlled by the default value:
CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT
It only increases the retries when reading:
SDHCI_INT_STATUS
to avoid the timeout error.
---
as per the discussion in:
http://lists.denx.de/pipermail/u-boot/2016-June/258966.html
this supercedes:
http://patchwork.ozlabs.org/patch/615994/
Changes in v2:
dropped "CONFIG_" from the #define
dropped "arm:" in the commit message
drivers/mmc/sdhci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/mmc/sdhci.c +3 -2
@@ -127,6 +127,7 @@ static int sdhci_transfer_data(struct sdhci_host *host, struct mmc_data *data,#define CONFIG_SDHCI_CMD_MAX_TIMEOUT 3200#endif #define CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT 100 +#define SDHCI_READ_STATUS_TIMEOUT 1000static int sdhci_send_command (struct mmc *mmc,struct mmc_cmd *cmd,struct mmc_data *data)
@@ -243,9 +244,9 @@ static int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,if (stat &SDHCI_INT_ERROR )break ; }while (((stat & mask) != mask) && - (get_timer (start) <CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT )); + (get_timer (start) <SDHCI_READ_STATUS_TIMEOUT )); -if (get_timer (start) >=CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT ) { +if (get_timer (start) >=SDHCI_READ_STATUS_TIMEOUT ) {if (host->quirks &SDHCI_QUIRK_BROKEN_R1B )return 0 ;else {
Signature · 1 line
1.8.5
PATCH v2 1/1 mmc: increase MMC SDHCI read status timeout
2016-06-30 5:42 GMT+09:00 Steve Rae <[email protected]>:
Quoted 11 lines
Otherwise, ocassionally see errors like this:
Flashing sparse image at offset 2078720 Flashing Sparse Image
sdhci_send_command: Timeout for status update! mmc fail to send stop cmd
write_sparse_image: Write failed, block #2181088 [0]This does not affect the actual writing speed, which is controlled by the default value:
CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT
Quoted 7 lines
It only increases the retries when reading:
SDHCI_INT_STATUS
to avoid the timeout error.Signed-off-by Steve Rae <[email protected]>Reviewed-by Stefan Roese <[email protected]>Tested-by Masahiro Yamada <[email protected]>
Looks good to me. Thanks!
Signature · 2 lines
Best Regards Masahiro Yamada
PATCH v2 1/1 mmc: increase MMC SDHCI read status timeout
Quoted 19 lines · Masahiro Yamada
2016-06-30 5:42 GMT+09:00 Steve Rae <[email protected]>:
Quoted 18 lines
Otherwise, ocassionally see errors like this:
Flashing sparse image at offset 2078720 Flashing Sparse Image
sdhci_send_command: Timeout for status update! mmc fail to send stop cmd
write_sparse_image: Write failed, block #2181088 [0]This does not affect the actual writing speed, which is controlled by the default value:
CONFIG_SDHCI_CMD_DEFAULT_TIMEOUTIt only increases the retries when reading:
SDHCI_INT_STATUS
to avoid the timeout error.Signed-off-by Steve Rae <[email protected]>Reviewed-by Stefan Roese <[email protected]>Tested-by Masahiro Yamada <[email protected]>
Best Regards,
Jaehoon Chung
Quoted 7 lines
Looks good to me. Thanks!
PATCH v2 1/1 mmc: increase MMC SDHCI read status timeout
In reply to Steve RaeQuoted 11 lines · Steve Rae
Otherwise, ocassionally see errors like this:
Flashing sparse image at offset 2078720 Flashing Sparse Image
sdhci_send_command: Timeout for status update! mmc fail to send stop cmd
write_sparse_image: Write failed, block #2181088 [0]This does not affect the actual writing speed, which is controlled by the default value:
CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT
Quoted 8 lines
It only increases the retries when reading:
SDHCI_INT_STATUS
to avoid the timeout error.Signed-off-by Steve Rae <[email protected]>Reviewed-by Stefan Roese <[email protected]>Tested-by Masahiro Yamada <[email protected]>Tested-by Jaehoon Chung <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160701/1580bff8/attachment.sig>