Skip to contentSkip to conversation

Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.

PATCH In review Samuele Baisi 2 participants 4 messages Jul 5, 2016 – Jul 8, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.

Removed a blankline after an opening bracket.

---
 drivers/staging/gdm724x/gdm_tty.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gdm724x/gdm_tty.c +0 -1
index eb7e252..ae39663 100644
@@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
 	int j;
 
 	for (i = 0; i < TTY_MAX_COUNT; i++) {
-
 		gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
 		if (!gdm)
 			return -ENOMEM;
Signature · 1 line
2.8.1
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Samuele Baisi

Removed a blankline after an opening bracket.

---
 drivers/staging/gdm724x/gdm_tty.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gdm724x/gdm_tty.c +0 -0
index eb7e252..ae39663 100644

drivers/staging/gdm724x/gdm_tty.c int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device) · line 230

Quoted 7 lines
drivers/staging/gdm724x/gdm_tty.c +0 -1
@@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
 	int j;
 
 	for (i = 0; i < TTY_MAX_COUNT; i++) {
-
 		gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
 		if (!gdm)
 			return -ENOMEM;

Patch applies cleanly and removes the checkpath issue.

Samuele,

It is a good idea to include the issue you are solving in the commit message, in this case it would be:

Removed a blankline after an opening bracket.

CHECK: Blank lines aren't necessary after an open brace '{' #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
+ for (i = 0; i < TTY_MAX_COUNT; i++) {
+

Signed-off-by:
---

Thanks :)
Luis

#2 lore raw

Il giorno ven 8 lug 2016 alle 20:17, Luis de Bethencourt <[email protected]> ha scritto:

Quoted 40 lines · Samuele Baisi
Quoted 16 lines

Removed a blankline after an opening bracket.

---

  drivers/staging/gdm724x/gdm_tty.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gdm724x/gdm_tty.c
b/drivers/staging/gdm724x/gdm_tty.c
index eb7e252..ae39663 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev
*tty_dev, struct device *device)
int j;

Quoted 6 lines

for (i = 0; i < TTY_MAX_COUNT; i++) {
-
gdm = kmalloc(sizeof(*gdm), GFP_KERNEL); if (!gdm)
return -ENOMEM;

Patch applies cleanly and removes the checkpath issue.

Samuele,

It is a good idea to include the issue you are solving in the commit message, in this case it would be:

Removed a blankline after an opening bracket.

CHECK: Blank lines aren't necessary after an open brace '{' #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:

(quoted diff) +2 -0
+       for (i = 0; i < TTY_MAX_COUNT; i++) {
+
Quoted 5 lines

Signed-off-by:
---

Thanks :)
Luis

Ok, next time I'll try to be more clear.

Thank you very much and best regards.

Samuele

#3 lore raw
Quoted 44 lines · Samuele Baisi

Il giorno ven 8 lug 2016 alle 20:17, Luis de Bethencourt <[email protected]> ha scritto:

Quoted 41 lines · Samuele Baisi
Quoted 12 lines

Removed a blankline after an opening bracket.

---

  drivers/staging/gdm724x/gdm_tty.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index eb7e252..ae39663 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)

Quoted 8 lines
      int j;

      for (i = 0; i < TTY_MAX_COUNT; i++) {
 -
          gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
          if (!gdm)
              return -ENOMEM;

Patch applies cleanly and removes the checkpath issue.

Samuele,

It is a good idea to include the issue you are solving in the commit message, in this case it would be:

Removed a blankline after an opening bracket.

CHECK: Blank lines aren't necessary after an open brace '{' #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:

(quoted diff) +2 -0
+       for (i = 0; i < TTY_MAX_COUNT; i++) {
+

Signed-off-by:
---

Quoted 9 lines
Quoted 2 lines

Thanks :)
Luis

Ok, next time I'll try to be more clear.

Thank you very much and best regards.

Samuele

No problem Samuele.

Looking forward to more patches from you soon :)
Feel free to CC me in them.

Luis