Skip to contentSkip to conversation

firmware: tegra: early resume bpmp

PATCH In review Bitan Biswas 2 participants 3 messages Jun 14, 2019 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: tegra: early resume bpmp

Early resume Tegra bpmp to fix Xavier clock rate error as follows:

[  159.017101] of_serial 3110000.serial: calling platform_pm_resume+0x0/0x58 @ 317, parent: cbb
[  159.025501] of_serial 3110000.serial: platform_pm_resume+0x0/0x58 returned 0 after 14 usecs
[  159.033694] tegra-i2c 31c0000.i2c: calling platform_pm_resume+0x0/0x58 @ 317, parent: cbb
[  159.042254] tegra-i2c 31c0000.i2c: failed changing clock rate: -22
[  159.048216] PM: dpm_run_callback(): platform_pm_resume+0x0/0x58 returns -22
[  159.055553] tegra-i2c 31c0000.i2c: platform_pm_resume+0x0/0x58 returned -22 after 13072 usecs
[  159.063875] PM: Device 31c0000.i2c failed to resume: error -22
---
 drivers/firmware/tegra/bpmp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/firmware/tegra/bpmp.c +3 -1
index dd775e8..de09036 100644
@@ -811,7 +811,9 @@ static int __maybe_unused tegra_bpmp_resume(struct device *dev)
 		return 0;
 }
 
-static SIMPLE_DEV_PM_OPS(tegra_bpmp_pm_ops, NULL, tegra_bpmp_resume);
+const struct dev_pm_ops tegra_bpmp_pm_ops = {
+	.resume_early = tegra_bpmp_resume
+};
 
 #if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC) || \
     IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC)
Signature · 1 line
2.7.4
#1 lore raw
Quoted 19 lines · Bitan Biswas

Early resume Tegra bpmp to fix Xavier clock rate error as follows:

[  159.017101] of_serial 3110000.serial: calling platform_pm_resume+0x0/0x58 @ 317, parent: cbb
[  159.025501] of_serial 3110000.serial: platform_pm_resume+0x0/0x58 returned 0 after 14 usecs
[  159.033694] tegra-i2c 31c0000.i2c: calling platform_pm_resume+0x0/0x58 @ 317, parent: cbb
[  159.042254] tegra-i2c 31c0000.i2c: failed changing clock rate: -22
[  159.048216] PM: dpm_run_callback(): platform_pm_resume+0x0/0x58 returns -22
[  159.055553] tegra-i2c 31c0000.i2c: platform_pm_resume+0x0/0x58 returned -22 after 13072 usecs
[  159.063875] PM: Device 31c0000.i2c failed to resume: error -22
---
 drivers/firmware/tegra/bpmp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/firmware/tegra/bpmp.c +0 -0
index dd775e8..de09036 100644

drivers/firmware/tegra/bpmp.c static int __maybe_unused tegra_bpmp_resume(struct device *dev) · line 816

Quoted 7 lines
drivers/firmware/tegra/bpmp.c +3 -1
@@ -811,7 +811,9 @@ static int __maybe_unused tegra_bpmp_resume(struct device *dev)
 		return 0;
 }
 
-static SIMPLE_DEV_PM_OPS(tegra_bpmp_pm_ops, NULL, tegra_bpmp_resume);
+const struct dev_pm_ops tegra_bpmp_pm_ops = {
+	.resume_early = tegra_bpmp_resume
+};

I've changed this to be static while applying to for-5.3/firmware.

Thanks,
Thierry

#2 lore raw
Quoted 23 lines · Thierry Reding
Quoted 22 lines · Bitan Biswas

Early resume Tegra bpmp to fix Xavier clock rate error as follows:

[  159.017101] of_serial 3110000.serial: calling platform_pm_resume+0x0/0x58 @ 317, parent: cbb
[  159.025501] of_serial 3110000.serial: platform_pm_resume+0x0/0x58 returned 0 after 14 usecs
[  159.033694] tegra-i2c 31c0000.i2c: calling platform_pm_resume+0x0/0x58 @ 317, parent: cbb
[  159.042254] tegra-i2c 31c0000.i2c: failed changing clock rate: -22
[  159.048216] PM: dpm_run_callback(): platform_pm_resume+0x0/0x58 returns -22
[  159.055553] tegra-i2c 31c0000.i2c: platform_pm_resume+0x0/0x58 returned -22 after 13072 usecs
[  159.063875] PM: Device 31c0000.i2c failed to resume: error -22
---
  drivers/firmware/tegra/bpmp.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/firmware/tegra/bpmp.c +0 -0
index dd775e8..de09036 100644
@@ -811,7 +811,9 @@ static int __maybe_unused tegra_bpmp_resume(struct device *dev)
  		return 0;
  }
 
Quoted 6 lines

drivers/firmware/tegra/bpmp.c static int __maybe_unused tegra_bpmp_resume(struct device *dev) · line 816

Quoted 4 lines
drivers/firmware/tegra/bpmp.c +3 -1
-static SIMPLE_DEV_PM_OPS(tegra_bpmp_pm_ops, NULL, tegra_bpmp_resume);
+const struct dev_pm_ops tegra_bpmp_pm_ops = {
+	.resume_early = tegra_bpmp_resume
+};

I've changed this to be static while applying to for-5.3/firmware.

Is this patch already part of some other patch? In that case I can abandon the patch.

Else, I shall add static keyword.

-regards,
Bitan