Char: isicom, fix close bug
PATCH 1/1 Char: isicom, fix close bug
Is there any chance to have this in 2.6.19?
--
isicom, fix close bug
port is dereferenced even if it is NULL. Dereference it _after_ the check if (!port)... Thanks Eric <[email protected]> for reporting this.
[http://bugzilla.kernel.org/show_bug.cgi?id=7527]
Signed-off-by Jiri Slaby <[email protected]>
---
commit 3b03fd9a68de624866b52b9e9a93d551839c0128
tree 77fff66a8b34516b014e9adbe55a9f1027de14c4
parent 0579e303553655245e8a6616bd8b4428b07d63a2
author Jiri Slaby <[email protected]> Wed, 15 Nov 2006 00:25:30 +0100 committer Jiri Slaby <[email protected]> Wed, 15 Nov 2006 00:25:30 +0100
drivers/char/isicom.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/char/isicom.c +2 -1
@@ -1062,11 +1062,12 @@ static void isicom_shutdown_port(structstatic void isicom_close (struct tty_struct *tty,struct file *filp) {struct isi_port *port = tty->driver_data; -struct isi_board *card = port->card; +struct isi_board *card;unsigned long flags;if (!port)return ; + card = port->card;if (isicom_paranoia_check (port, tty->name,"isicom_close" ))return ;