dm: clk: Remove simple version of clk_get_by_index/name()
PATCH v2 1/1 dm: clk: Remove simple version of clk_get_by_index/name()
Simple version of clk_get_by_index() added by:
"dm: clk: Add a simple version of clk_get_by_index()" (sha1: a4b10c088c4f6ef2e2bba33e8cfea369bcbbce44) is only working for #clock-cells=<1> but not for any other values. Fixed clocks is using #clock-cells=<0> which requires full implementation.
Remove simplified versions of clk_get_by_index() and use full version. Also remove empty clk_get_by_name() which is failing when it is called which is useless.
---
Changes in v2:
- Also use full version of clk_get_by_name()
- Subject change from "Remove simple version of clk_get_by_index()"
--- drivers/clk/clk-uclass.c | 26 -------------------------- 1 file changed, 26 deletions(-)
drivers/clk/clk-uclass.c +0 -26
@@ -20,31 +20,6 @@ static inline struct clk_ops *clk_dev_ops(struct udevice *dev) }#if CONFIG_IS_ENABLED (OF_CONTROL ) -#ifdef CONFIG_SPL_BUILD -int clk_get_by_index(struct udevice *dev, int index, struct clk *clk) -{ - int ret; - u32 cell[2]; - - if (index != 0) - return -ENOSYS; - assert(clk); - ret = uclass_get_device(UCLASS_CLK, 0, &clk->dev); - if (ret) - return ret; - ret = fdtdec_get_int_array(gd->fdt_blob, dev->of_offset, "clocks", - cell, 2); - if (ret) - return ret; - clk->id = cell[1]; - return 0; -} - -int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk) -{ - return -ENOSYS; -} -#elsestatic int clk_of_xlate_default (struct clk *clk,struct fdtdec_phandle_args *args) {
@@ -118,7 +93,6 @@ int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk) return clk_get_by_index(dev, index, clk); }#endif -#endif int clk_request (struct udevice *dev,struct clk *clk) {
Signature · 1 line
1.9.1
PATCH v2 1/1 dm: clk: Remove simple version of clk_get_by_index/name()
Quoted 10 lines · Michal Simek
Simple version of
clk_get_by_index()added by:
"dm: clk: Add a simple version ofclk_get_by_index()" (sha1:a4b10c088c4f6ef2e2bba33e8cfea369bcbbce44) is only working for #clock-cells=<1> but not for any other values. Fixed clocks is using #clock-cells=<0> which requires full implementation.Remove simplified versions of
clk_get_by_index()and use full version. Also remove emptyclk_get_by_name()which is failing when it is called which is useless.
This seems reasonable to me,
PATCH v2 1/1 dm: clk: Remove simple version of clk_get_by_index/name()
Hi Simon,
Quoted 8 lines · Stephen Warren
Quoted 7 lines · Michal Simek
Simple version of
clk_get_by_index()added by:
"dm: clk: Add a simple version ofclk_get_by_index()" (sha1:a4b10c088c4f6ef2e2bba33e8cfea369bcbbce44) is only working for #clock-cells=<1> but not for any other values. Fixed clocks is using #clock-cells=<0> which requires full implementation.
Quoted 6 lines
Quoted 3 lines
Remove simplified versions of
clk_get_by_index()and use full version. Also remove emptyclk_get_by_name()which is failing when it is called which is useless.This seems reasonable to me,
Acked-by Stephen Warren <[email protected]>
I see your patch
"dm: clk: Add support for of-platdata"
(sha1: 7423daa60eb30b6613dfc19a51c55de23fd4d703)
has been merged to the tree and it is in conflict with this patch. Is there any problem about using full version and just remove the whole SPL part?
Thanks,
Michal
PATCH v2 1/1 dm: clk: Remove simple version of clk_get_by_index/name()
Hi Michal,
Quoted 18 lines · Michal Simek
Hi Simon,
Quoted 8 lines · Stephen Warren
Quoted 7 lines · Michal Simek
Simple version of
clk_get_by_index()added by:
"dm: clk: Add a simple version ofclk_get_by_index()" (sha1:a4b10c088c4f6ef2e2bba33e8cfea369bcbbce44) is only working for #clock-cells=<1> but not for any other values. Fixed clocks is using #clock-cells=<0> which requires full implementation.Quoted 6 lines
Quoted 3 lines
Remove simplified versions of
clk_get_by_index()and use full version. Also remove emptyclk_get_by_name()which is failing when it is called which is useless.This seems reasonable to me,
Acked-by Stephen Warren <[email protected]>
Quoted 6 lines
I see your patch
"dm: clk: Add support for of-platdata"
(sha1:7423daa60eb30b6613dfc19a51c55de23fd4d703)
has been merged to the tree and it is in conflict with this patch. Is there any problem about using full version and just remove the whole SPL part?
Yes I was going to mention that. Unfortunately we need the of-platdata version since in that case there is no device tree (it has been converted to a C struct).
Regards,
Simon
PATCH v2 1/1 dm: clk: Remove simple version of clk_get_by_index/name()
Hi Simon,
Quoted 28 lines · Simon Glass
Hi Michal,
Quoted 18 lines · Michal Simek
Hi Simon,
Quoted 8 lines · Stephen Warren
Quoted 7 lines · Michal Simek
Simple version of
clk_get_by_index()added by:
"dm: clk: Add a simple version ofclk_get_by_index()" (sha1:a4b10c088c4f6ef2e2bba33e8cfea369bcbbce44) is only working for #clock-cells=<1> but not for any other values. Fixed clocks is using #clock-cells=<0> which requires full implementation.Quoted 6 lines
Quoted 3 lines
Remove simplified versions of
clk_get_by_index()and use full version. Also remove emptyclk_get_by_name()which is failing when it is called which is useless.This seems reasonable to me,
Acked-by Stephen Warren <[email protected]>Quoted 6 lines
I see your patch
"dm: clk: Add support for of-platdata"
(sha1:7423daa60eb30b6613dfc19a51c55de23fd4d703)
has been merged to the tree and it is in conflict with this patch. Is there any problem about using full version and just remove the whole SPL part?
Quoted 3 lines
Yes I was going to mention that. Unfortunately we need the of-platdata version since in that case there is no device tree (it has been converted to a C struct).
v3 sent which address this.
Thanks,
Michal