Skip to contentSkip to conversation

openpromfs root inode has ino 0

DISCUSSION Vegard Nossum 1 participant 1 message Jul 17, 2016 VFS

lore
Share & tools
lore
#0 lore raw

Hi,

I noticed that fs/openpromfs/inode.c has:

#define OPENPROM_ROOT_INO 0

It seems it was originally 16 but was changed to 0 here:

commit 3d824a46b7210ea3b0a13ab0d0fbd7f6e2e91ddf

Author: David S. Miller <[email protected]>
Date:   Sun Jun 25 23:19:14 2006 -0700

[OPENPROMFS]: Rewrite using in-kernel device tree and seq_file.

As far as I understand, inode 0 should never be used and can cause various things to fail, e.g. my /bin/ls seems to completely ignore getdents() results which have ->d_ino = 0.

I don't know if it actually causes any problems for people who are actually using this, and I don't have the means to test the code anyway, so just a heads up...

Vegard