mmc: fix the output format
PATCH 1/1 mmc: fix the output format
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)
than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
---
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/mmc-uclass.c +1 -1
@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)for (uclass_first_device (UCLASS_MMC , &dev); dev; -uclass_next_device (&dev)) { +uclass_next_device (&dev), first = false) {struct mmc *m =mmc_get_mmc_dev (dev);if (!first) {
Signature · 1 line
1.9.1
PATCH 1/1 mmc: fix the output format
Hi Ziyuan,
Quoted 6 lines · Ziyuan Xu
It's nicer to see this:
=> mmc list
dwmmc atff0c0000: 0
dwmmc atff0f0000: 1 (eMMC)
Quoted 6 lines
than this:
=> mmc list
dwmmc atff0c0000: 0dwmmc atff0f0000: 1 (eMMC)With the latter, it's much clearer which mmc devices are on.
You're right. After applied your patch, it may display like mmc-legacy type. If add the comment in more detail,
How about "Display mmc list information like mmc-legacy type." ? :)
Best Regards,
Jaehoon Chung
Quoted 21 lines
Signed-off-by Ziyuan Xu <[email protected]>---
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/mmc-uclass.c +1
-1@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)for (uclass_first_device (UCLASS_MMC , &dev); dev; -uclass_next_device (&dev)) { +uclass_next_device (&dev), first = false) {struct mmc *m =mmc_get_mmc_dev (dev);if (!first) {
PATCH 1/1 mmc: fix the output format
Hi Jaehoon,
Quoted 11 lines · Jaehoon Chung
Hi Ziyuan,
Quoted 8 lines · Ziyuan Xu
It's nicer to see this:
=> mmc list
dwmmc atff0c0000: 0
dwmmc atff0f0000: 1 (eMMC)than this:
Quoted 7 lines
Quoted 4 lines
=> mmc list
dwmmc atff0c0000: 0dwmmc atff0f0000: 1 (eMMC)With the latter, it's much clearer which mmc devices are on.
You're right. After applied your patch, it may display like mmc-legacy type. If add the comment in more detail,
How about "Display mmc list information like mmc-legacy type." ? :)
Looks good for me.I will change commit to
mmc: display mmc list informaton like mmc_legacy type. Thanks!
Quoted 27 lines
Best Regards,
Jaehoon ChungQuoted 20 lines
Signed-off-by Ziyuan Xu <[email protected]>---
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/mmc-uclass.c +1
-1@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)for (uclass_first_device (UCLASS_MMC , &dev); dev; -uclass_next_device (&dev)) { +uclass_next_device (&dev), first = false) {struct mmc *m =mmc_get_mmc_dev (dev);if (!first) {