Skip to contentSkip to conversation

rockchip: fix rk3036 SPL build

PATCH New Heiko Stuebner 3 participants 4 messages Jul 20, 2016 – Jul 23, 2016

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Rockchip
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

PATCH 1/1 rockchip: fix rk3036 SPL build

Commit c7db6abf534d ("ARM64: rockchip: add support for rk3399 SoC based evb") moved the SPL Kconfig selects into the individual soc-specific options. But it only did it for the rk3288 and not for the rk3036 thus disabling SPL builds for it. Add the necessary options for the rk3036 as well.

Fixes c7db6abf534d ("ARM64: rockchip: add support for rk3399 SoC based evb")
Signed-off-by Heiko Stuebner <[email protected]>
---
 arch/arm/mach-rockchip/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-rockchip/Kconfig +2 -0
index 2817c0f..c47e16c 100644
@@ -8,6 +8,8 @@ config ROCKCHIP_RK3036
 	  including NEON and GPU, Mali-400 graphics, several DDR3 options
 	  and video codec support. Peripherals include Gigabit Ethernet,
 	  USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
+	select SUPPORT_SPL
+	select SPL
 
 config ROCKCHIP_RK3188
 	bool "Support Rockchip RK3188"
Signature · 1 line
2.8.0.rc3
#1 lore raw

PATCH 1/1 rockchip: fix rk3036 SPL build

Hi Heiko,

Simon apply my V4 patch which still have some problem, he said that
he will rebase
with a new patch set either if I send a new version or send fixes, but he won't be available till next week.

I have send out my V5 patch which including the code of this patch.

Thanks,
- Kever

Quoted 24 lines · Heiko Stuebner

Commit c7db6abf534d ("ARM64: rockchip: add support for rk3399 SoC based evb") moved the SPL Kconfig selects into the individual soc-specific options. But it only did it for the rk3288 and not for the rk3036 thus disabling SPL builds for it. Add the necessary options for the rk3036 as well.

Fixes c7db6abf534d ("ARM64: rockchip: add support for rk3399 SoC based evb")
Signed-off-by Heiko Stuebner <[email protected]>
---
  arch/arm/mach-rockchip/Kconfig | 2 ++
  1 file changed, 2 insertions(+)
arch/arm/mach-rockchip/Kconfig +2 -0
index 2817c0f..c47e16c 100644
@@ -8,6 +8,8 @@ config ROCKCHIP_RK3036
  	  including NEON and GPU, Mali-400 graphics, several DDR3 options
  	  and video codec support. Peripherals include Gigabit Ethernet,
  	  USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
+	select SUPPORT_SPL
+	select SPL
 
  config ROCKCHIP_RK3188
  	bool "Support Rockchip RK3188"
#2 lore raw

PATCH 1/1 rockchip: fix rk3036 SPL build

Hi Heiko,

Quoted 9 lines · Kever Yang

Hi Heiko,

Simon apply my V4 patch which still have some problem, he said that he
will rebase
with a new patch set either if I send a new version or send fixes, but he won't be available till next week.

I have send out my V5 patch which including the code of this patch.

Please can you check u-boot-rockchip and see if this looks OK now?

Regards,
Simon

Quoted 34 lines

Thanks,
- Kever

Quoted 27 lines · Heiko Stuebner

Commit c7db6abf534d ("ARM64: rockchip: add support for rk3399 SoC based evb")
moved the SPL Kconfig selects into the individual soc-specific options. But it only did it for the rk3288 and not for the rk3036 thus disabling SPL builds for it. Add the necessary options for the rk3036 as well.

Fixes c7db6abf534d ("ARM64: rockchip: add support for rk3399 SoC based

evb")

Signed-off-by Heiko Stuebner <[email protected]>
---
  arch/arm/mach-rockchip/Kconfig | 2 ++
  1 file changed, 2 insertions(+)
arch/arm/mach-rockchip/Kconfig +2 -0
index 2817c0f..c47e16c 100644
@@ -8,6 +8,8 @@ config ROCKCHIP_RK3036
          including NEON and GPU, Mali-400 graphics, several DDR3 options
          and video codec support. Peripherals include Gigabit Ethernet,
          USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
+       select SUPPORT_SPL
+       select SPL
    config ROCKCHIP_RK3188
        bool "Support Rockchip RK3188"
author maintainer
#3 lore raw

PATCH 1/1 rockchip: fix rk3036 SPL build

Hi Simon,

Am Freitag, 22. Juli 2016, 20:31:36 schrieb Simon Glass:

Quoted 10 lines · Kever Yang
Quoted 7 lines

Simon apply my V4 patch which still have some problem, he said that he

will rebase
with a new patch set either if I send a new version or send fixes, but he won't be available till next week.

I have send out my V5 patch which including the code of this patch.

Please can you check u-boot-rockchip and see if this looks OK now?

yep, I've rebased on top of your master branch from just now, and everything still builds and runs just fine (rk3036, rk3188 and rk3288).

Heiko