mmc: display mmc list information like mmc_legacy type

PATCH Superseded Ziyuan Xu 3 participants 6 messages Jul 19, 2016 – Jul 23, 2016 MMC, SD and SDIO

lore

Share & tools

lore

Ziyuan Xu

author

2016-07-19 14:21 UTC #0 lore raw

PATCH v2 1/1 mmc: display mmc list information like mmc_legacy type

From: Xu Ziyuan <[email protected]>

It's nicer to see this:

=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)

than this:

=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)

With the latter, it's much clearer which mmc devices are on.

Signed-off-by Ziyuan Xu <[email protected]>

Serise-changes: 2
- Update commit from Jaehoon

Signed-off-by Ziyuan Xu <[email protected]>

---

 drivers/mmc/mmc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/mmc-uclass.c +1 -1

index 38ced41..beebc70 100644
@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
 
 	for (uclass_first_device(UCLASS_MMC, &dev);
 	     dev;
-	     uclass_next_device(&dev)) {
+	     uclass_next_device(&dev), first = false) {
 		struct mmc *m = mmc_get_mmc_dev(dev);
 
 		if (!first) {

Signature · 1 line

1.9.1

Jaehoon Chung

2016-07-21 02:11 UTC #1 lore raw

PATCH v2 1/1 mmc: display mmc list information like mmc_legacy type

Hi Ziyuan,

Quoted 8 lines · Ziyuan Xu

From: Xu Ziyuan <[email protected]>
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)

Quoted 6 lines

than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.

Right? "With latter"?

Quoted 5 lines

Signed-off-by Ziyuan Xu <[email protected]>
Serise-changes: 2
- Update commit from Jaehoon

Could you add the Changelog to the below line?

Quoted 3 lines

Signed-off-by Ziyuan Xu <[email protected]>
---

Locate the Changelog at here.

Best Regards,
Jaehoon Chung

Quoted 18 lines

 drivers/mmc/mmc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/mmc-uclass.c +1 -1

index 38ced41..beebc70 100644
@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
 
 	for (uclass_first_device(UCLASS_MMC, &dev);
 	     dev;
-	     uclass_next_device(&dev)) {
+	     uclass_next_device(&dev), first = false) {
 		struct mmc *m = mmc_get_mmc_dev(dev);
 
 		if (!first) {

Ziyuan Xu

author

2016-07-23 03:11 UTC #2 lore raw

PATCH v2 1/1 mmc: display mmc list information like mmc_legacy type

Hi Jaehoon,

Thanks for your catch, fix it in v3.

Quoted 52 lines · Jaehoon Chung

Hi Ziyuan,
Quoted 8 lines · Ziyuan Xu
From: Xu Ziyuan <[email protected]>
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)
Quoted 6 lines
than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Right? "With latter"?
Quoted 4 lines
Signed-off-by Ziyuan Xu <[email protected]>
Serise-changes: 2
- Update commit from Jaehoon
Could you add the Changelog to the below line?
Quoted 2 lines
Signed-off-by Ziyuan Xu <[email protected]>
---
Locate the Changelog at here.
Best Regards,
Jaehoon Chung
Quoted 17 lines
  drivers/mmc/mmc-uclass.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/mmc-uclass.c +1 -1
index 38ced41..beebc70 100644
@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
 
  	for (uclass_first_device(UCLASS_MMC, &dev);
  	     dev;
-	     uclass_next_device(&dev)) {
+	     uclass_next_device(&dev), first = false) {
  		struct mmc *m = mmc_get_mmc_dev(dev);
 
  		if (!first) {

Simon Glass

2016-07-22 03:21 UTC #3 lore raw

PATCH v2 1/1 mmc: display mmc list information like mmc_legacy type

In reply to Ziyuan Xu

Quoted 17 lines · Ziyuan Xu

From: Xu Ziyuan <[email protected]>
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)
than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Signed-off-by Ziyuan Xu <[email protected]>

Quoted 8 lines

Serise-changes: 2
- Update commit from Jaehoon
Signed-off-by Ziyuan Xu <[email protected]>
---
 drivers/mmc/mmc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the bug fix.

Acked-by Simon Glass <[email protected]>

Simon Glass

2016-07-23 02:57 UTC #4 lore raw

PATCH v2 1/1 mmc: display mmc list information like mmc_legacy type

Hi,

Quoted 24 lines · Simon Glass

Quoted 23 lines · Ziyuan Xu
From: Xu Ziyuan <[email protected]>
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)
than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Signed-off-by Ziyuan Xu <[email protected]>
Serise-changes: 2
- Update commit from Jaehoon
Signed-off-by Ziyuan Xu <[email protected]>
---

Quoted 6 lines

Quoted 2 lines
 drivers/mmc/mmc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the bug fix.
Acked-by Simon Glass <[email protected]>

Please can you send a v2 with the nits fixed?

- Simon

Ziyuan Xu

author

2016-07-23 03:12 UTC #5 lore raw

PATCH v2 1/1 mmc: display mmc list information like mmc_legacy type

Hi Simon,

Quoted 27 lines · Simon Glass

Hi,
Quoted 24 lines · Simon Glass
Quoted 23 lines · Ziyuan Xu
From: Xu Ziyuan <[email protected]>
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)
than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
With the latter, it's much clearer which mmc devices are on.
Signed-off-by Ziyuan Xu <[email protected]>
Serise-changes: 2
- Update commit from Jaehoon
Signed-off-by Ziyuan Xu <[email protected]>
---

Quoted 6 lines

Quoted 5 lines
Quoted 2 lines
  drivers/mmc/mmc-uclass.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the bug fix.
Acked-by Simon Glass <[email protected]>
Please can you send a v2 with the nits fixed?

Fixed, see v3.

Quoted 5 lines

- Simon