Skip to contentSkip to conversation

Revert "imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS"

PATCH New Breno Lima 3 participants 3 messages Jul 20, 2016 – Jul 21, 2016

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

Breno Lima

author
#0 lore raw

PATCH 1/1 Revert "imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS"

Commit c1ebf54868359005 ("imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS") causes SPL breakage on wandboard:

ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c
ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c
ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c
ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c ** First descriptor is NOT a primary desc on 0:1 **
spl: no partition table found
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

This error is seen when SPL and u-boot.img are stored in the raw SD card partition.

This reverts commit c1ebf54868359005c32944c1473668d5fcaca158.

Signed-off-by Breno Lima <[email protected]>
---
 arch/arm/imx-common/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/imx-common/spl.c +1 -1
index 0c1e401..bdcda7d 100644
@@ -76,7 +76,7 @@ u32 spl_boot_mode(const u32 boot_device)
 	/* for MMC return either RAW or FAT mode */
 	case BOOT_DEVICE_MMC1:
 	case BOOT_DEVICE_MMC2:
-#if defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT)
+#if defined(CONFIG_SPL_FAT_SUPPORT)
 		return MMCSD_MODE_FS;
 #elif defined(CONFIG_SUPPORT_EMMC_BOOT)
 		return MMCSD_MODE_EMMCBOOT;
Signature · 1 line
2.7.4
reviewer
#1 lore raw

PATCH 1/1 Revert "imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS"

Quoted 12 lines · Breno Lima

Commit c1ebf54868359005 ("imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS") causes SPL breakage on wandboard:

ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c
ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c
ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c
ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c ** First descriptor is NOT a primary desc on 0:1 **
spl: no partition table found
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

Quoted 6 lines

This error is seen when SPL and u-boot.img are stored in the raw SD card partition.

This reverts commit c1ebf54868359005c32944c1473668d5fcaca158.

Signed-off-by Breno Lima <[email protected]>

Thanks for the fix:

Reviewed-by Fabio Estevam <[email protected]>
#2 lore raw

PATCH 1/1 Revert "imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS"

Hi Breno,

Am 20.07.2016 um 22:20 schrieb Fabio Estevam:

Quoted 16 lines · Breno Lima
Quoted 15 lines

Commit c1ebf54868359005 ("imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS") causes SPL breakage on wandboard:

ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c
ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c
ERROR: v7_dcache_inval_range - start address is not aligned - 0x1820006c
ERROR: v7_dcache_inval_range - stop address is not aligned - 0x1820086c ** First descriptor is NOT a primary desc on 0:1 **
spl: no partition table found
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

This error is seen when SPL and u-boot.img are stored in the raw SD card partition.

Quoted 6 lines
Quoted 3 lines

This reverts commit c1ebf54868359005c32944c1473668d5fcaca158.

Signed-off-by Breno Lima <[email protected]>

Thanks for the fix:

Reviewed-by Fabio Estevam <[email protected]>

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic