Skip to contentSkip to conversation

block: replace obsolete simple_strtol() with kstrtoul()

PATCH New Daeseok Youn 1 participant 2 messages Feb 20, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: replace obsolete simple_strtol() with kstrtoul()

Quoted 1 line

From cac24db7480b10b671d05320e0cb97a7bf5d0aea Mon Sep 17 00:00:00 2001

From: Daeseok Youn <[email protected]>
Date: Thu, 20 Feb 2014 15:35:14 +0900
Subject: [PATCH] block: replace obsolete simple_strtol() with kstrtoul()

- Makes rd_size value as static, because it is only referenced in this file.

---
 drivers/block/brd.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/block/brd.c +4 -3
index e73b85c..a33d8d3 100644
@@ -429,12 +429,12 @@ static const struct block_device_operations brd_fops = {
  * And now the modules code and kernel interface.
  */
 static int rd_nr;
-int rd_size = CONFIG_BLK_DEV_RAM_SIZE;
+static unsigned long rd_size = CONFIG_BLK_DEV_RAM_SIZE;
 static int max_part;
 static int part_shift;
 module_param(rd_nr, int, S_IRUGO);
 MODULE_PARM_DESC(rd_nr, "Maximum number of brd devices");
-module_param(rd_size, int, S_IRUGO);
+module_param(rd_size, ulong, S_IRUGO);
 MODULE_PARM_DESC(rd_size, "Size of each RAM disk in kbytes.");
 module_param(max_part, int, S_IRUGO);
 MODULE_PARM_DESC(max_part, "Maximum number of partitions per RAM disk");
@@ -446,7 +446,8 @@ MODULE_ALIAS("rd");
 /* Legacy boot options - nonmodular */
 static int __init ramdisk_size(char *str)
 {
-	rd_size = simple_strtol(str, NULL, 0);
+	if (kstrtoul(str, 0, &rd_size) < 0)
+		return 0;
 	return 1;
 }
 __setup("ramdisk_size=", ramdisk_size);
Signature · 3 lines
1.7.9.5

---
#1 lore raw

PATCH 1/1 block: replace obsolete simple_strtol() with kstrtoul()

[email protected] account doesn't exist.

TO+ :
[email protected], [email protected]

Quoted 42 lines · you

From cac24db7480b10b671d05320e0cb97a7bf5d0aea Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Thu, 20 Feb 2014 15:35:14 +0900
Subject: [PATCH] block: replace obsolete simple_strtol() with kstrtoul()

- Makes rd_size value as static, because it is only referenced in this file.

---
 drivers/block/brd.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/block/brd.c +0 -0
index e73b85c..a33d8d3 100644
@@ -429,12 +429,12 @@ static const struct block_device_operations brd_fops =

{ * And now the modules code and kernel interface.
*/
static int rd_nr;

drivers/block/brd.c +4 -3
-int rd_size = CONFIG_BLK_DEV_RAM_SIZE;
+static unsigned long rd_size = CONFIG_BLK_DEV_RAM_SIZE;
 static int max_part;
 static int part_shift;
 module_param(rd_nr, int, S_IRUGO);
 MODULE_PARM_DESC(rd_nr, "Maximum number of brd devices");
-module_param(rd_size, int, S_IRUGO);
+module_param(rd_size, ulong, S_IRUGO);
 MODULE_PARM_DESC(rd_size, "Size of each RAM disk in kbytes.");
 module_param(max_part, int, S_IRUGO);
 MODULE_PARM_DESC(max_part, "Maximum number of partitions per RAM disk");
@@ -446,7 +446,8 @@ MODULE_ALIAS("rd");
 /* Legacy boot options - nonmodular */
 static int __init ramdisk_size(char *str)
 {
-	rd_size = simple_strtol(str, NULL, 0);
+	if (kstrtoul(str, 0, &rd_size) < 0)
+		return 0;
 	return 1;
 }
 __setup("ramdisk_size=", ramdisk_size);