Skip to contentSkip to conversation

ACPI: PM: s2idle: Print debug messages in two new places

PATCH New Rafael J. Wysocki 1 participant 3 messages Feb 1, 2022 ACPI

lore
Share & tools
lore

Rafael J. Wysocki

author
#0 lore raw

cover ACPI: PM: s2idle: Print debug messages in two new places

Hi All,

This series causes PM debug messages to be printed in two new places to help diagnose issues related to wakeup from suspend-to-idle.

Thanks!

author
#1 lore raw

PATCH 1/2 ACPI: PM: Print additional debug message in acpi_s2idle_wake()

From: Rafael J. Wysocki <[email protected]>

Make acpi_s2idle_wake() print an additional debug message when the SCI is going to be rearmed for system wakeup to help diagnose wakeup-related issues.

Signed-off-by Rafael J. Wysocki <[email protected]>
---
 drivers/acpi/sleep.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/acpi/sleep.c +2 -0
Index: linux-pm/drivers/acpi/sleep.c
===================================================================
@@ -764,6 +764,8 @@ bool acpi_s2idle_wake(void)
 			return true;
 		}
 
+		pm_pr_dbg("Rearming ACPI SCI for wakeup\n");
+
 		rearm_wake_irq(acpi_sci_irq);
 	}
author
#2 lore raw

PATCH 2/2 ACPI: EC / PM: Print additional debug message in acpi_ec_dispatch_gpe()

In reply to Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

Make acpi_ec_dispatch_gpe() print an additional debug message after seeing the EC GPE status bit set to help diagnose wakeup-related issues.

Signed-off-by Rafael J. Wysocki <[email protected]>
---
 drivers/acpi/ec.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/acpi/ec.c +4 -1
Index: linux-pm/drivers/acpi/ec.c
===================================================================
@@ -2071,8 +2071,11 @@ bool acpi_ec_dispatch_gpe(void)
 	 */
 	spin_lock_irq(&first_ec->lock);
 
-	if (acpi_ec_gpe_status_set(first_ec))
+	if (acpi_ec_gpe_status_set(first_ec)) {
+		pm_pr_dbg("ACPI EC GPE status set\n");
+
 		work_in_progress = advance_transaction(first_ec, false);
+	}
 
 	spin_unlock_irq(&first_ec->lock);