rk3399: reseve space for trust

PATCH New Kever Yang 2 participants 4 messages Jul 22, 2016 – Jul 25, 2016 Arm Rockchip

lore

Share & tools

lore

Kever Yang

author

2016-07-22 09:34 UTC #0 lore raw

PATCH 1/1 rk3399: reseve space for trust

rk3399 need reserve 0x200000 at the begining of DRAM, for ATF usage.

Signed-off-by Kever Yang <[email protected]>

---

 board/rockchip/evb_rk3399/evb-rk3399.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

board/rockchip/evb_rk3399/evb-rk3399.c +2 -1

index dffacd0..37d3851 100644
@@ -21,6 +21,7 @@ int dram_init(void)
 
 void dram_init_banksize(void)
 {
-	gd->bd->bi_dram[0].start = 0;
+	/* Reserve 0x200000 for trust word */
+	gd->bd->bi_dram[0].start = 0x200000;
 	gd->bd->bi_dram[0].size = 0x80000000;
 }

Signature · 1 line

1.9.1

Simon Glass

2016-07-23 02:57 UTC #1 lore raw

PATCH 1/1 rk3399: reseve space for trust

Hi Kever,

On 22 July 2016 at 03:34, Kever Yang <[email protected]> wrote:

For the commit message, you have "rk3399: reseve space for trust".

I think it should be "rk3399: Reseve space for ARM Trusted Firmware" or perhaps ATF

Quoted 1 line

rk3399 need reserve 0x200000 at the begining of DRAM, for ATF usage.

needs
beginning
s/usage/use/

Quoted 12 lines

Signed-off-by Kever Yang <[email protected]>
---
 board/rockchip/evb_rk3399/evb-rk3399.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
board/rockchip/evb_rk3399/evb-rk3399.c +0 -0
index dffacd0..37d3851 100644

board/rockchip/evb_rk3399/evb-rk3399.c int dram_init(void) · line 24

Quoted 5 lines

board/rockchip/evb_rk3399/evb-rk3399.c +1 -1

@@ -21,6 +21,7 @@ int dram_init(void)
 
 void dram_init_banksize(void)
 {
-       gd->bd->bi_dram[0].start = 0;
+       /* Reserve 0x200000 for trust word */

What does 'trust word' mean? Do you mean space for ATF, or a single word of memory?

Quoted 7 lines

board/rockchip/evb_rk3399/evb-rk3399.c +1 -1

+       gd->bd->bi_dram[0].start = 0x200000;
        gd->bd->bi_dram[0].size = 0x80000000;
 }
--

1.9.1

Regards,
Simon

Simon Glass

2016-07-23 03:03 UTC #2 lore raw

PATCH 1/1 rk3399: reseve space for trust

Hi again,

Quoted 8 lines · Simon Glass

Hi Kever,
On 22 July 2016 at 03:34, Kever Yang <[email protected]> wrote:
For the commit message, you have "rk3399: reseve space for trust".
I think it should be "rk3399: Reseve space for ARM Trusted Firmware" or perhaps ATF

Ooops I mean 'Reserve' !

Quoted 37 lines

Quoted 3 lines
rk3399 need reserve 0x200000 at the begining of DRAM, for ATF usage.
needs
beginning
s/usage/use/
Quoted 12 lines
Signed-off-by Kever Yang <[email protected]>
---
 board/rockchip/evb_rk3399/evb-rk3399.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
board/rockchip/evb_rk3399/evb-rk3399.c +0 -0
index dffacd0..37d3851 100644
board/rockchip/evb_rk3399/evb-rk3399.c int dram_init(void) · line 24
Quoted 5 lines
board/rockchip/evb_rk3399/evb-rk3399.c +1 -1
@@ -21,6 +21,7 @@ int dram_init(void)
 
 void dram_init_banksize(void)
 {
-       gd->bd->bi_dram[0].start = 0;
+       /* Reserve 0x200000 for trust word */
What does 'trust word' mean? Do you mean space for ATF, or a single word of memory?
Quoted 7 lines
board/rockchip/evb_rk3399/evb-rk3399.c +1 -1
+       gd->bd->bi_dram[0].start = 0x200000;
        gd->bd->bi_dram[0].size = 0x80000000;
 }
--
1.9.1

Quoted 2 lines

Regards,
Simon

Regards,
Simon

Kever Yang

author

2016-07-25 02:00 UTC #3 lore raw

PATCH 1/1 rk3399: reseve space for trust

Hi Simon,

Quoted 5 lines · Simon Glass

Hi again,
Quoted 2 lines · Simon Glass
Hi Kever,

Quoted 7 lines

Quoted 6 lines · Kever Yang
For the commit message, you have "rk3399: reseve space for trust".
I think it should be "rk3399: Reseve space for ARM Trusted Firmware" or perhaps ATF
Ooops I mean 'Reserve' !

I though the memory is used by ATF BL31 and BL32 which is not including in ATF,
this reserve memory only use for ATF BL31 in fact, so I will send Version 2 with all
you comments applied.

Thanks,
- Kever

Quoted 39 lines

Quoted 33 lines
Quoted 3 lines
rk3399 need reserve 0x200000 at the begining of DRAM, for ATF usage.
needs
beginning
s/usage/use/
Quoted 11 lines
Signed-off-by Kever Yang <[email protected]>
---
  board/rockchip/evb_rk3399/evb-rk3399.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
board/rockchip/evb_rk3399/evb-rk3399.c +0 -0
index dffacd0..37d3851 100644
board/rockchip/evb_rk3399/evb-rk3399.c int dram_init(void) · line 24
Quoted 5 lines
board/rockchip/evb_rk3399/evb-rk3399.c +1 -1
@@ -21,6 +21,7 @@ int dram_init(void)
 
  void dram_init_banksize(void)
  {
-       gd->bd->bi_dram[0].start = 0;
+       /* Reserve 0x200000 for trust word */
What does 'trust word' mean? Do you mean space for ATF, or a single word of memory?
Quoted 7 lines
board/rockchip/evb_rk3399/evb-rk3399.c +1 -1
+       gd->bd->bi_dram[0].start = 0x200000;
         gd->bd->bi_dram[0].size = 0x80000000;
  }
--
1.9.1
Quoted 2 lines
Regards,
Simon
Regards,
Simon