mmc: display mmc list information like mmc_legacy type

PATCH New Ziyuan Xu 3 participants 4 messages Jul 23, 2016 – Aug 5, 2016 MMC, SD and SDIO

lore

Share & tools

lore

Ziyuan Xu

author

2016-07-23 03:11 UTC #0 lore raw

PATCH v3 1/1 mmc: display mmc list information like mmc_legacy type

From: Xu Ziyuan <[email protected]>

It's nicer to see this:

=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)

than this:

=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)

With the former, it's much clearer which mmc devices are on.

Signed-off-by Ziyuan Xu <[email protected]>

---

Changes in v3:
- Fix nits

Changes in v2:
- Update commit from Jaehoon

 drivers/mmc/mmc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/mmc-uclass.c +1 -1

index 38ced41..beebc70 100644
@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
 
 	for (uclass_first_device(UCLASS_MMC, &dev);
 	     dev;
-	     uclass_next_device(&dev)) {
+	     uclass_next_device(&dev), first = false) {
 		struct mmc *m = mmc_get_mmc_dev(dev);
 
 		if (!first) {

Signature · 1 line

1.9.1

Simon Glass

2016-07-25 02:07 UTC #1 lore raw

PATCH v3 1/1 mmc: display mmc list information like mmc_legacy type

Quoted 19 lines · Ziyuan Xu

From: Xu Ziyuan <[email protected]>
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)
than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
With the former, it's much clearer which mmc devices are on.
Signed-off-by Ziyuan Xu <[email protected]>
---

Quoted 8 lines

Changes in v3:
- Fix nits
Changes in v2:
- Update commit from Jaehoon
 drivers/mmc/mmc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by Simon Glass <[email protected]>

Jaehoon Chung

2016-07-25 04:58 UTC #2 lore raw

PATCH v3 1/1 mmc: display mmc list information like mmc_legacy type

Quoted 23 lines · Simon Glass

Quoted 22 lines · Ziyuan Xu
From: Xu Ziyuan <[email protected]>
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)
than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
With the former, it's much clearer which mmc devices are on.
Signed-off-by Ziyuan Xu <[email protected]>
---
Changes in v3:
- Fix nits

Quoted 7 lines

Quoted 5 lines
Changes in v2:
- Update commit from Jaehoon
 drivers/mmc/mmc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by Simon Glass <[email protected]>

Reviewed-by Jaehoon Chung <[email protected]>

Tested-by Jaehoon Chung <[email protected]>

Quoted 3 lines

Jaehoon Chung

2016-08-05 02:26 UTC #3 lore raw

PATCH v3 1/1 mmc: display mmc list information like mmc_legacy type

In reply to Ziyuan Xu

Quoted 13 lines · Xu Ziyuan

From: Xu Ziyuan <[email protected]>
It's nicer to see this:
=> mmc list
dwmmc at ff0c0000: 0
dwmmc at ff0f0000: 1 (eMMC)
than this:
=> mmc list
dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)

Quoted 6 lines

With the former, it's much clearer which mmc devices are on.
Signed-off-by Ziyuan Xu <[email protected]>
Acked-by Simon Glass <[email protected]>
Reviewed-by Jaehoon Chung <[email protected]>
Tested-by Jaehoon Chung <[email protected]>

Applied on u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

Quoted 25 lines

---

Changes in v3:
- Fix nits

Changes in v2:
- Update commit from Jaehoon

 drivers/mmc/mmc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/mmc-uclass.c +1 -1

index 38ced41..beebc70 100644
@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
 
 	for (uclass_first_device(UCLASS_MMC, &dev);
 	     dev;
-	     uclass_next_device(&dev)) {
+	     uclass_next_device(&dev), first = false) {
 		struct mmc *m = mmc_get_mmc_dev(dev);
 
 		if (!first) {