ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit

The LCDK is the successor to the late Hawkboard and has the same machine number.
Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

Signed-off-by Karl Beldan <[email protected]>

---
 Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++
 arch/arm/mach-davinci/da8xx-dt.c                  |  1 +
 4 files changed, 77 insertions(+)
 create mode 100644 arch/arm/boot/dts/omapl138-lcdk.dts

Documentation/devicetree/bindings/arm/davinci.txt +4 -0

index cfaeda4..1482c74 100644
@@ -5,6 +5,10 @@ DA850/OMAP-L138/AM18x Evaluation Module (EVM) board
 Required root node properties:
     - compatible = "ti,da850-evm", "ti,da850";
 
+DA850/OMAP-L138/AM18x L138/C6748 Development Kit (LCDK) board
+Required root node properties:
+    - compatible = "ti,omapl138-lcdk", "ti,da850";
+
 EnBW AM1808 based CMC board
 Required root node properties:
     - compatible = "enbw,cmc", "ti,da850;

arch/arm/boot/dts/Makefile +1 -0

index 414b427..da3f69b 100644
@@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_BERLIN) += \
 dtb-$(CONFIG_ARCH_BRCMSTB) += \
 	bcm7445-bcm97445svmb.dtb
 dtb-$(CONFIG_ARCH_DAVINCI) += \
+	omapl138-lcdk.dtb \
 	da850-enbw-cmc.dtb \
 	da850-evm.dtb
 dtb-$(CONFIG_ARCH_DIGICOLOR) += \

arch/arm/boot/dts/omapl138-lcdk.dts new file +9 -0

new file mode 100644
index 0000000..fad3b6d
@@ -0,0 +1,71 @@
+/*
+ * Copyright (c) 2016 BayLibre, Inc.
+ *
+ * Licensed under GPLv2 or later.
+ */
+/dts-v1/;
+#include "da850.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+

arch/arm/boot/dts/omapl138-lcdk.dts new file +52 -0

+		stdout-path = "serial2:115200n8";
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0xc0000000 0x08000000>;
+	};
+};
+
+&pmx_core {
+	status = "okay";
+};
+
+&serial2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&serial2_rxtx_pins>;
+	status = "okay";
+};
+
+&wdt {
+	status = "okay";
+};
+
+&rtc0 {
+	status = "okay";
+};
+
+&gpio {
+	status = "okay";
+};
+
+&mdio {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mdio_pins>;
+	bus_freq = <2200000>;
+	status = "okay";
+};
+
+&eth0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mii_pins>;
+	status = "okay";
+};
+
+&mmc0 {
+	max-frequency = <50000000>;
+	bus-width = <4>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc0_pins>;
+	cd-gpios = <&gpio 64 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};

arch/arm/mach-davinci/da8xx-dt.c +1 -0

index 754f478..d5f710c 100644
@@ -49,6 +49,7 @@ static void __init da850_init_machine(void)
 
 static const char *const da850_boards_compat[] __initconst = {
 	"enbw,cmc",
+	"ti,omapl138-lcdk",
 	"ti,da850-evm",
 	"ti,da850",
 	NULL,

Signature · 1 line

2.9.0.rc1

Quoted 67 lines · Karl Beldan

The LCDK is the successor to the late Hawkboard and has the same machine number.
Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

Signed-off-by Karl Beldan <[email protected]>

---
 Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++
 arch/arm/mach-davinci/da8xx-dt.c                  |  1 +
 4 files changed, 77 insertions(+)
 create mode 100644 arch/arm/boot/dts/omapl138-lcdk.dts

Documentation/devicetree/bindings/arm/davinci.txt +4 -0

index cfaeda4..1482c74 100644
@@ -5,6 +5,10 @@ DA850/OMAP-L138/AM18x Evaluation Module (EVM) board
 Required root node properties:
     - compatible = "ti,da850-evm", "ti,da850";
 
+DA850/OMAP-L138/AM18x L138/C6748 Development Kit (LCDK) board
+Required root node properties:
+    - compatible = "ti,omapl138-lcdk", "ti,da850";
+
 EnBW AM1808 based CMC board
 Required root node properties:
     - compatible = "enbw,cmc", "ti,da850;

arch/arm/boot/dts/Makefile +1 -0

index 414b427..da3f69b 100644
@@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_BERLIN) += \
 dtb-$(CONFIG_ARCH_BRCMSTB) += \
 	bcm7445-bcm97445svmb.dtb
 dtb-$(CONFIG_ARCH_DAVINCI) += \
+	omapl138-lcdk.dtb \
 	da850-enbw-cmc.dtb \
 	da850-evm.dtb
 dtb-$(CONFIG_ARCH_DIGICOLOR) += \

arch/arm/boot/dts/omapl138-lcdk.dts new file +14 -0

new file mode 100644
index 0000000..fad3b6d
@@ -0,0 +1,71 @@
+/*
+ * Copyright (c) 2016 BayLibre, Inc.
+ *
+ * Licensed under GPLv2 or later.
+ */
+/dts-v1/;
+#include "da850.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+	model = "DA850/AM1808/OMAP-L138 LCDK";
+	compatible = "ti,omapl138-lcdk", "ti,da850";
+
+	aliases {

arch/arm/boot/dts/omapl138-lcdk.dts line 19

Quoted 5 lines

arch/arm/boot/dts/omapl138-lcdk.dts new file +5 -0

+		serial2 = &serial2;
+	};
+
+	chosen {
+		bootargs = "console=ttyS2,115200n8 earlycon";

You don't need console with stdout-path set. And really, earlycon should not be the default.

Quoted 11 lines · Rob Herring

Quoted 10 lines · Karl Beldan

The LCDK is the successor to the late Hawkboard and has the same machine number.
Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

Quoted 10 lines

arch/arm/boot/dts/omapl138-lcdk.dts line 19

Quoted 6 lines

arch/arm/boot/dts/omapl138-lcdk.dts new file +6 -0

+   aliases {
+           serial2 = &serial2;
+   };
+
+   chosen {
+           bootargs = "console=ttyS2,115200n8 earlycon";

You don't need console with stdout-path set. And really, earlycon should not be the default.

Ok for earlycon.

For the console, I thought likewise .. until I _struggled_ to understand why the console was disappearing under my feet.
It seemed even stranger when I started looking at the codepath because drivers/of/base.c would properly add_preferred_console as expected after the corresponding UART was added. But the reality was there, without it the console was not like stdout-path.
Among the commits that could instill doubt as to whether stdout-path rules is f64255b5072d:
"The assumption that at least 1 preferred console will be registered when the stdout-path property is set is invalid, which can result in _no_ consoles.", though it didn't answer my question.
I started looking whether tty0 was not getting in the way and in the end I came up with setting console.
But you seem affirmative.

+Peter H

Quoted 12 lines · Karl Beldan

Quoted 11 lines · Rob Herring

Quoted 10 lines · Karl Beldan

The LCDK is the successor to the late Hawkboard and has the same machine number.
Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

[...]

Quoted 12 lines

Quoted 10 lines

arch/arm/boot/dts/omapl138-lcdk.dts line 19

Quoted 6 lines

arch/arm/boot/dts/omapl138-lcdk.dts new file +6 -0

+   aliases {
+           serial2 = &serial2;
+   };
+
+   chosen {
+           bootargs = "console=ttyS2,115200n8 earlycon";

You don't need console with stdout-path set. And really, earlycon should not be the default.

Ok for earlycon.

Quoted 14 lines

For the console, I thought likewise .. until I _struggled_ to understand why the console was disappearing under my feet.
It seemed even stranger when I started looking at the codepath because drivers/of/base.c would properly add_preferred_console as expected after the corresponding UART was added. But the reality was there, without it the console was not like stdout-path.
Among the commits that could instill doubt as to whether stdout-path rules is f64255b5072d:
"The assumption that at least 1 preferred console will be registered when the stdout-path property is set is invalid, which can result in _no_ consoles.", though it didn't answer my question.
I started looking whether tty0 was not getting in the way and in the end I came up with setting console.
But you seem affirmative.

There have been some issues in this area, but I thought they were in conjunction with earlycon and solved now. This is a fairly common review request for dts files, so I'm surprised if it doesn't work right. Maybe having tty0 or not has some influence. Or people just accept review comments without testing or caring...

Quoted 45 lines · Rob Herring

+Peter H

Quoted 12 lines · Karl Beldan

Quoted 11 lines · Rob Herring

Quoted 10 lines · Karl Beldan

The LCDK is the successor to the late Hawkboard and has the same machine number.
Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

[...]

Quoted 12 lines

Quoted 10 lines

arch/arm/boot/dts/omapl138-lcdk.dts line 19

Quoted 6 lines

arch/arm/boot/dts/omapl138-lcdk.dts new file +6 -0

+   aliases {
+           serial2 = &serial2;
+   };
+
+   chosen {
+           bootargs = "console=ttyS2,115200n8 earlycon";

You don't need console with stdout-path set. And really, earlycon should not be the default.

Ok for earlycon.

Quoted 14 lines

For the console, I thought likewise .. until I _struggled_ to understand why the console was disappearing under my feet.
It seemed even stranger when I started looking at the codepath because drivers/of/base.c would properly add_preferred_console as expected after the corresponding UART was added. But the reality was there, without it the console was not like stdout-path.
Among the commits that could instill doubt as to whether stdout-path rules is f64255b5072d:
"The assumption that at least 1 preferred console will be registered when the stdout-path property is set is invalid, which can result in _no_ consoles.", though it didn't answer my question.
I started looking whether tty0 was not getting in the way and in the end I came up with setting console.
But you seem affirmative.

Quoted 6 lines

There have been some issues in this area, but I thought they were in conjunction with earlycon and solved now. This is a fairly common review request for dts files, so I'm surprised if it doesn't work right. Maybe having tty0 or not has some influence. Or people just accept review comments without testing or caring...

I can assure you I tested without early{con,printk} ;).

Now I have just rechecked the codepaths and something caught my attention in kernel/printk/printk.c:__add_preferred_console(): if console_cmdline is empty selected_console gets unconditionally set to zero ! Knowing this I confirmed by replacing with idx (works), and also by using ttyS0 (i.e. alias serial0 = &uart2) (works), this would not affect DTs using serial0. It's late here so I'll stop there.

The LCDK is the successor to the late Hawkboard and has the same machine number.

Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

Signed-off-by Karl Beldan <[email protected]>

---
 Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++

+ Sekhar

Hi Karl,

Quoted 2 lines · Karl Beldan

The LCDK is the successor to the late Hawkboard and has the same machine number.

Machine number is only relevant for legacy (non-DT) boot and this is DT boot, so the machine number bit really relevant for this changelog.

BTW, have you tried legacy boot on LCDK with board-omapl138-hawk.c? I assume it mostly works?

Quoted 10 lines

Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

Signed-off-by Karl Beldan <[email protected]>

Tested with v4.7 on my LCDK board.

Tested-by Kevin Hilman <[email protected]>

Note that I also needed CONFIG_RTC_DRV_OMAP=m enabled in davinci_all_defconfig for the RTC driver. Could you add a patch for that to this series as well?

Also, plese Cc the co-maintainer Sekhar Nori (now Cc'd) on all future davinci patches.

Quoted 4 lines

---
 Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++

I think this should be called da850-lcdk.dts.

The OMAP prefix in the DT directory is just going to cause confusion, and the other DTs using this same SoC are already called da850.

Sekhar do you have any opinion here?

[...]

arch/arm/boot/dts/omapl138-lcdk.dts line 19

Quoted 10 lines

arch/arm/boot/dts/omapl138-lcdk.dts new file +10 -0

+/ {
+	model = "DA850/AM1808/OMAP-L138 LCDK";
+	compatible = "ti,omapl138-lcdk", "ti,da850";
+
+	aliases {
+		serial2 = &serial2;
+	};
+
+	chosen {
+		bootargs = "console=ttyS2,115200n8 earlycon";

earlycon is kind of a debug option, so probably should be left out of the default DT.

Quoted 4 lines · Kevin Hilman

+ Sekhar

Hi Karl,

Quoted 8 lines

Quoted 2 lines · Karl Beldan

The LCDK is the successor to the late Hawkboard and has the same machine number.

Machine number is only relevant for legacy (non-DT) boot and this is DT boot, so the machine number bit really relevant for this changelog.

Hi Kevin,

It was purely informative.

Quoted 3 lines

BTW, have you tried legacy boot on LCDK with board-omapl138-hawk.c? I assume it mostly works?

Yes.

Quoted 13 lines

Quoted 10 lines

Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

Signed-off-by Karl Beldan <[email protected]>

Tested with v4.7 on my LCDK board.

Quoted 6 lines

Tested-by Kevin Hilman <[email protected]>

Note that I also needed CONFIG_RTC_DRV_OMAP=m enabled in davinci_all_defconfig for the RTC driver. Could you add a patch for that to this series as well?

No problem. BTW do you also consider CONFIG_ items not arch specific (like CONFIG_NET_VENDOR_SMSC) ?

Quoted 4 lines

Also, plese Cc the co-maintainer Sekhar Nori (now Cc'd) on all future davinci patches.

Sure.

Quoted 5 lines

Quoted 4 lines

---
 Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++

Quoted 5 lines

I think this should be called da850-lcdk.dts.

The OMAP prefix in the DT directory is just going to cause confusion, and the other DTs using this same SoC are already called da850.

That's what I thought too, mainline U-Boot is using omapl138_lcdk but yes da850 is less confusing given the code already present (downside is when you search for da850 on the net there's nothing).

Quoted 3 lines

 Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++

I think this should be called da850-lcdk.dts.

The OMAP prefix in the DT directory is just going to cause confusion, and the other DTs using this same SoC are already called da850.

Sekhar do you have any opinion here?

The LCDK is the successor to the late Hawkboard.
Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. phy, audio codec, video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always on).
A DT-only boot with this addition gives functional UART, reboot via watchdog, RTC, ethernet and MMC (I added the CD GPIO for the MMC although davinci_mmc doesn't call the OF facilities of mmc core).

Cc Sekhar Nori <[email protected]>

Tested-by Kevin Hilman <[email protected]>

Signed-off-by Karl Beldan <[email protected]>

---
 Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/da850-lcdk.dts                  | 70 +++++++++++++++++++++++
 arch/arm/mach-davinci/da8xx-dt.c                  |  1 +
 4 files changed, 76 insertions(+)
 create mode 100644 arch/arm/boot/dts/da850-lcdk.dts

The LCDK is the successor to the late Hawkboard and has the same machine number.
Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

Signed-off-by Karl Beldan <[email protected]>

---
 Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++
 arch/arm/mach-davinci/da8xx-dt.c                  |  1 +
 4 files changed, 77 insertions(+)
 create mode 100644 arch/arm/boot/dts/omapl138-lcdk.dts

Documentation/devicetree/bindings/arm/davinci.txt +0 -0

index cfaeda4..1482c74 100644

Documentation/devicetree/bindings/arm/davinci.txt +1 -0

+
 EnBW AM1808 based CMC board
 Required root node properties:
     - compatible = "enbw,cmc", "ti,da850;

arch/arm/boot/dts/Makefile +1 -0

index 414b427..da3f69b 100644
@@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_BERLIN) += \
 dtb-$(CONFIG_ARCH_BRCMSTB) += \
 	bcm7445-bcm97445svmb.dtb
 dtb-$(CONFIG_ARCH_DAVINCI) += \
+	omapl138-lcdk.dtb \
 	da850-enbw-cmc.dtb \
 	da850-evm.dtb
 dtb-$(CONFIG_ARCH_DIGICOLOR) += \

arch/arm/boot/dts/omapl138-lcdk.dts new file +0 -0

new file mode 100644
index 0000000..fad3b6d

Quoted 11 lines · Karl Beldan

The LCDK is the successor to the late Hawkboard and has the same machine number.
Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

Quoted 1 line

Signed-off-by Karl Beldan <[email protected]>

C6748 is a pin-compatible DSP-only part which does not run Linux. The OMAP-L138 and C6748 LCDKs are physically different boards. So, I would just stick with subject line ".. for the OMAP-L138 LCDK board"

Quoted 16 lines

---
 Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
 arch/arm/boot/dts/Makefile                        |  1 +
 arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++
 arch/arm/mach-davinci/da8xx-dt.c                  |  1 +
 4 files changed, 77 insertions(+)
 create mode 100644 arch/arm/boot/dts/omapl138-lcdk.dts

Documentation/devicetree/bindings/arm/davinci.txt +0 -0

index cfaeda4..1482c74 100644
@@ -5,6 +5,10 @@ DA850/OMAP-L138/AM18x Evaluation Module (EVM) board
 Required root node properties:
     - compatible = "ti,da850-evm", "ti,da850";
 

Documentation/devicetree/bindings/arm/davinci.txt DA850/OMAP-L138/AM18x Evaluation Module (EVM) board · line 8

Quoted 1 line

Documentation/devicetree/bindings/arm/davinci.txt +1 -0

+DA850/OMAP-L138/AM18x L138/C6748 Development Kit (LCDK) board

here too, drop reference to C6748.

Documentation/devicetree/bindings/arm/davinci.txt DA850/OMAP-L138/AM18x Evaluation Module (EVM) board · line 10

Quoted 2 lines

Documentation/devicetree/bindings/arm/davinci.txt +2 -0

+Required root node properties:
+    - compatible = "ti,omapl138-lcdk", "ti,da850";

let the compatible be "ti,da850-lcdk" for consistency.

Quoted 20 lines

Documentation/devicetree/bindings/arm/davinci.txt +1 -0

+
 EnBW AM1808 based CMC board
 Required root node properties:
     - compatible = "enbw,cmc", "ti,da850;

arch/arm/boot/dts/Makefile +1 -0

index 414b427..da3f69b 100644
@@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_BERLIN) += \
 dtb-$(CONFIG_ARCH_BRCMSTB) += \
 	bcm7445-bcm97445svmb.dtb
 dtb-$(CONFIG_ARCH_DAVINCI) += \
+	omapl138-lcdk.dtb \
 	da850-enbw-cmc.dtb \
 	da850-evm.dtb
 dtb-$(CONFIG_ARCH_DIGICOLOR) += \

arch/arm/boot/dts/omapl138-lcdk.dts new file +0 -1

new file mode 100644
index 0000000..fad3b6d
--- /dev/null

arch/arm/boot/dts/omapl138-lcdk.dts line 4

Quoted 6 lines

+++ b/arch/arm/boot/dts/omapl138-lcdk.dts

arch/arm/boot/dts/omapl138-lcdk.dts new file +4 -0

@@ -0,0 +1,71 @@
+/*
+ * Copyright (c) 2016 BayLibre, Inc.
+ *
+ * Licensed under GPLv2 or later.

are you sure about "or later"?

Quoted 12 lines · Sekhar Nori

Quoted 11 lines · Karl Beldan

The LCDK is the successor to the late Hawkboard and has the same machine number.
Among the differences are the flash (16bits vs 8bits) and some pins (MMC, LEDs, buttons, some external connectors), however the main components remain the same (eth. PHY, Audio Codec, Video decoder and DAC) except for the main PMIC, different and hard-wired on the LCDK (the LDOs and DCDCs are always ON).
A DT-only boot with this addition gives functional uart, reboot via watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC although davinci_mmc doesn't call yet the mmc core OF facilities).

Quoted 6 lines

Quoted 1 line

Signed-off-by Karl Beldan <[email protected]>

C6748 is a pin-compatible DSP-only part which does not run Linux. The OMAP-L138 and C6748 LCDKs are physically different boards. So, I would just stick with subject line ".. for the OMAP-L138 LCDK board"

That was my understanding but LCDK stands for L138-C6748-Dev-Kit right ? Anyways, I'll remove the said references as per your request.

This driver handles the RTC of most davinci SoCs.

Cc Sekhar Nori <[email protected]>

Cc Kevin Hilman <[email protected]>

Signed-off-by Karl Beldan <[email protected]>

The LCDK embeds a LAN8710.

Cc Sekhar Nori <[email protected]>

Cc Kevin Hilman <[email protected]>

Signed-off-by Karl Beldan <[email protected]>

This depends on "ARM: dts: da850: Add missing pin muxing for the UARTs".

Changes from v1:
- s/omapl138/da850/
- Remove earlycon from bootargs
- Remove console=ttyS2,115200n8 from bootargs (workaround for preferred console)
- Add patches for CONFIG_SMSC_PHY=y and CONFIG_RTC_DRV_OMAP=m

Changes from v2:
- [1] Remove references to C6748: replace 'L138/C6748 Dev Kit (LCDK)' with 'LCDK'
- Change license from 'GPLv2 or later' to 'GPLv2'

Changes from v3:
- revert v2 [1]