Skip to contentSkip to conversation

arm64: Kconfig: select ALPINE_MSI only if PCI is selected

PATCH New Sudeep Holla 3 participants 4 messages Aug 3, 2016 – Aug 11, 2016 arm64

lore
Share & tools
lore

Sudeep Holla

author
#0 lore raw

PATCH 1/2 arm64: Kconfig: select ALPINE_MSI only if PCI is selected

Even when PCI is disabled, ARCH_ALPINE selects ALPINE_MSI triggerring the following config warning:

warning: (ARCH_ALPINE) selects ALPINE_MSI which has unmet direct
dependencies (PCI)

This patch makes selection of ALPINE_MSI conditional on PCI.

Cc Arnd Bergmann <[email protected]>
Acked-by Antoine Tenart <[email protected]>
Signed-off-by Sudeep Holla <[email protected]>
---
 arch/arm64/Kconfig.platforms | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi ARM-SoC guys,

I still see this couple of config warnings without PCI with today's next.

Regards,
Sudeep

arch/arm64/Kconfig.platforms +1 -1
index 4fb0bef0f094..b0e6850aa3e4 100644
@@ -8,7 +8,7 @@ config ARCH_SUNXI
 
 config ARCH_ALPINE
 	bool "Annapurna Labs Alpine platform"
-	select ALPINE_MSI
+	select ALPINE_MSI if PCI
 	help
 	  This enables support for the Annapurna Labs Alpine
 	  Soc family.

--
2.7.4

author
#1 lore raw

PATCH 2/2 arm64: Kconfig: select HISILICON_IRQ_MBIGEN only if PCI is selected

Even when PCI is disabled, ARCH_HISI selects HISILICON_IRQ_MBIGEN triggerring the following config warning:

warning: (ARM64 && HISILICON_IRQ_MBIGEN) selects ARM_GIC_V3_ITS which

	has unmet direct dependencies (PCI && PCI_MSI)

This patch makes selection of HISILICON_IRQ_MBIGEN conditional on PCI.

Cc Ma Jun <[email protected]>
Cc Arnd Bergmann <[email protected]>
Signed-off-by Sudeep Holla <[email protected]>
---
 arch/arm64/Kconfig.platforms | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/Kconfig.platforms +1 -1
index b0e6850aa3e4..41d82b327e6a 100644
@@ -66,7 +66,7 @@ config ARCH_LG1K
 config ARCH_HISI
 	bool "Hisilicon SoC Family"
 	select ARM_TIMER_SP804
-	select HISILICON_IRQ_MBIGEN
+	select HISILICON_IRQ_MBIGEN if PCI
 	help
 	  This enables support for Hisilicon ARMv8 SoC family

--
2.7.4

Applied
#2 lore raw

PATCH 2/2 arm64: Kconfig: select HISILICON_IRQ_MBIGEN only if PCI is selected

Quoted 7 lines · CEST Sudeep Holla

Even when PCI is disabled, ARCH_HISI selects HISILICON_IRQ_MBIGEN triggerring the following config warning:

warning: (ARM64 && HISILICON_IRQ_MBIGEN) selects ARM_GIC_V3_ITS which

        has unmet direct dependencies (PCI && PCI_MSI)

This patch makes selection of HISILICON_IRQ_MBIGEN conditional on PCI.

I think strictly speaking HISILICON_IRQ_MBIGEN should work without PCI, but that is only a theoretical setup, and the patch seems to be the simplest way to avoid the warning.

Applied both patches to fixes, sorry for the delay.

Arnd

#3 lore raw

PATCH 2/2 arm64: Kconfig: select HISILICON_IRQ_MBIGEN only if PCI is selected

? 2016/8/11 4:51, Arnd Bergmann ??:

Quoted 7 lines · CEST Sudeep Holla
Quoted 6 lines

Even when PCI is disabled, ARCH_HISI selects HISILICON_IRQ_MBIGEN triggerring the following config warning:

warning: (ARM64 && HISILICON_IRQ_MBIGEN) selects ARM_GIC_V3_ITS which

        has unmet direct dependencies (PCI && PCI_MSI)
Quoted 8 lines
Quoted 1 line

This patch makes selection of HISILICON_IRQ_MBIGEN conditional on PCI.

I think strictly speaking HISILICON_IRQ_MBIGEN should work without PCI, but that is only a theoretical setup, and the patch seems to be the simplest way to avoid the warning.

Applied both patches to fixes, sorry for the delay.

sorry for late response, I just noticed this patch.

You are right, HISILICON_IRQ_MBIGEN uses the platform msi and has no relation with pci.

Quoted 3 lines

Arnd