Skip to contentSkip to conversation

Input: tegra-kbc: fix inverted reset logic

PATCH Applied Masahiro Yamada 4 participants 4 messages Aug 16, 2016 – Aug 22, 2016

Subsystems (4)
HID Tegra architecture support Input drivers Tegra kbc driver
lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 Input: tegra-kbc: fix inverted reset logic

Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") accidentally converted _deassert to _assert, so there is no code to wake up this hardware.

Fixes fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
Signed-off-by Masahiro Yamada <[email protected]>

---

 drivers/input/keyboard/tegra-kbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/tegra-kbc.c +1 -1
index 7d61439..0c07e10 100644
@@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
 	/* Reset the KBC controller to clear all previous status.*/
 	reset_control_assert(kbc->rst);
 	udelay(100);
-	reset_control_assert(kbc->rst);
+	reset_control_deassert(kbc->rst);
 	udelay(100);
 
 	tegra_kbc_config_pins(kbc);
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Masahiro Yamada

Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") accidentally converted _deassert to _assert, so there is no code to wake up this hardware.

Fixes fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
Signed-off-by Masahiro Yamada <[email protected]>

---

 drivers/input/keyboard/tegra-kbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Nice catch!

Acked-by Thierry Reding <[email protected]>
maintainer Applied
#3 lore raw
In reply to Masahiro Yamada
Quoted 6 lines · Masahiro Yamada

Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") accidentally converted _deassert to _assert, so there is no code to wake up this hardware.

Fixes fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
Signed-off-by Masahiro Yamada <[email protected]>

Applied, thank you.

Quoted 21 lines

---

 drivers/input/keyboard/tegra-kbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/tegra-kbc.c +1 -1
index 7d61439..0c07e10 100644
@@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
 	/* Reset the KBC controller to clear all previous status.*/
 	reset_control_assert(kbc->rst);
 	udelay(100);
-	reset_control_assert(kbc->rst);
+	reset_control_deassert(kbc->rst);
 	udelay(100);
 
 	tegra_kbc_config_pins(kbc);
Signature · 1 line
1.9.1
Signature · 1 line
Dmitry