Skip to contentSkip to conversation

ARM: mm: pull asm/memory.h explicitly

PATCH New Vladimir Murzin 2 participants 4 messages Aug 17, 2016 – Aug 18, 2016 Arm (32-bit)

lore
Share & tools
lore

Vladimir Murzin

author
#0 lore raw

PATCH 1/1 ARM: mm: pull asm/memory.h explicitly

Commit d78114554939a (""ARM: 8512/1: proc-v7.S: Adjust stack address when XIP_KERNEL"") introduced a macro which lives under asm/memory.h. Unfortunately, for MMU-less systems (like R-class) it leads to build failure:

arch/arm/mm/proc-v7.S: Assembler messages:
arch/arm/mm/proc-v7.S:538: Error: unrecognised relocation suffix make[1]: *** [arch/arm/mm/proc-v7.o] Error 1
make: *** [arch/arm/mm] Error 2

since it is implicitly pulled via asm/pgtable.h for MMU capable systems only.

To fix it include asm/memory.h explicitly.

Signed-off-by Vladimir Murzin <[email protected]>
---
 arch/arm/mm/proc-v7.S |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mm/proc-v7.S +1 -0
index d0b116c..8cb105b 100644
@@ -16,6 +16,7 @@
 #include <asm/hwcap.h>
 #include <asm/pgtable-hwdef.h>
 #include <asm/pgtable.h>
+#include <asm/memory.h>
 
 #include "proc-macros.S"
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw

PATCH 1/1 ARM: mm: pull asm/memory.h explicitly

Quoted 9 lines · Vladimir Murzin

Commit d78114554939a (""ARM: 8512/1: proc-v7.S: Adjust stack address when XIP_KERNEL"") introduced a macro which lives under asm/memory.h. Unfortunately, for MMU-less systems (like R-class) it leads to build failure:

arch/arm/mm/proc-v7.S: Assembler messages:
arch/arm/mm/proc-v7.S:538: Error: unrecognised relocation suffix make[1]: *** [arch/arm/mm/proc-v7.o] Error 1
make: *** [arch/arm/mm] Error 2

Quoted 5 lines

since it is implicitly pulled via asm/pgtable.h for MMU capable systems only.

To fix it include asm/memory.h explicitly.

Signed-off-by Vladimir Murzin <[email protected]>

Looks fine, thanks.

Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
author
#2 lore raw

PATCH 1/1 ARM: mm: pull asm/memory.h explicitly

Quoted 10 lines · Russell King - ARM Linux
Quoted 9 lines · Vladimir Murzin

Commit d78114554939a (""ARM: 8512/1: proc-v7.S: Adjust stack address when XIP_KERNEL"") introduced a macro which lives under asm/memory.h. Unfortunately, for MMU-less systems (like R-class) it leads to build failure:

arch/arm/mm/proc-v7.S: Assembler messages:
arch/arm/mm/proc-v7.S:538: Error: unrecognised relocation suffix make[1]: *** [arch/arm/mm/proc-v7.o] Error 1
make: *** [arch/arm/mm] Error 2

Quoted 8 lines
Quoted 5 lines

since it is implicitly pulled via asm/pgtable.h for MMU capable systems only.

To fix it include asm/memory.h explicitly.

Signed-off-by Vladimir Murzin <[email protected]>

Looks fine, thanks.

Should I drop it into patch system?

Cheers
Vladimir

maintainer
#3 lore raw

PATCH 1/1 ARM: mm: pull asm/memory.h explicitly

Quoted 13 lines · Vladimir Murzin
Quoted 12 lines · Russell King - ARM Linux
Quoted 11 lines · Vladimir Murzin

Commit d78114554939a (""ARM: 8512/1: proc-v7.S: Adjust stack address when XIP_KERNEL"") introduced a macro which lives under asm/memory.h. Unfortunately, for MMU-less systems (like R-class) it leads to build failure:

arch/arm/mm/proc-v7.S: Assembler messages:
arch/arm/mm/proc-v7.S:538: Error: unrecognised relocation suffix make[1]: *** [arch/arm/mm/proc-v7.o] Error 1
make: *** [arch/arm/mm] Error 2

since it is implicitly pulled via asm/pgtable.h for MMU capable systems only.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

To fix it include asm/memory.h explicitly.

Signed-off-by Vladimir Murzin <[email protected]>

Looks fine, thanks.

Should I drop it into patch system?

Yes please.

Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.