ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
Subsystems (3)
PATCH 1/1 ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
This adds the PM8058 LEDs as used in the platform.
---
These DT bindings have been ACKed by Rob Herring and Bjorn Andersson so I think the patch is safe to merge to the Qcom tree.
--- arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 39 ++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +39 -0
@@ -239,6 +239,45 @@ }; }; }; + + led at 48 { + /* + * The keypad LED @0x48 is routed to + * the sensor board where it is + * connected to an infrared LED + * SFH4650 (60mW, @850nm) next to the + * ambient light and proximity sensor + * Capella Microsystems CM3605. + */ + compatible = "qcom,pm8058-keypad-led"; + reg = <0x48>; + label = "proximity0"; + default-state = "off"; + }; + led at 131 { + compatible = "qcom,pm8058-led"; + reg = <0x131>; + label = "pm8058:red"; + default-state = "off"; + }; + led at 132 { + /* + * This is actually green too on my + * board, but documented as yellow. + */ + compatible = "qcom,pm8058-led"; + reg = <0x132>; + label = "pm8058:yellow"; + default-state = "off"; + linux,default-trigger = "mmc0"; + }; + led at 133 { + compatible = "qcom,pm8058-led"; + reg = <0x133>; + label = "pm8058:green"; + default-state = "on"; + linux,default-trigger = "heartbeat"; + }; }; };
Signature · 1 line
2.7.4
PATCH 1/1 ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
Quoted 9 lines · Linus Walleij
This adds the PM8058 LEDs as used in the platform.
Cc linux-arm-msm at vger.kernel.orgCc linux-leds at vger.kernel.orgCc Andy Gross <[email protected]>Cc Stephen Boyd <[email protected]>Cc Bjorn Andersson <[email protected]>Cc Jacek Anaszewski <[email protected]>Signed-off-by Linus Walleij <[email protected]>
Regards,
Bjorn
Quoted 60 lines
---
These DT bindings have been ACKed by Rob Herring and Bjorn Andersson so I think the patch is safe to merge to the Qcom tree.--- arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 39 ++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +39
-0@@ -239,6 +239,45 @@ }; }; }; + + led at 48 { + /* + * The keypad LED @0x48 is routed to + * the sensor board where it is + * connected to an infrared LED + * SFH4650 (60mW, @850nm) next to the + * ambient light and proximity sensor + * Capella Microsystems CM3605. + */ + compatible = "qcom,pm8058-keypad-led"; + reg = <0x48>; + label = "proximity0"; + default-state = "off"; + }; + led at 131 { + compatible = "qcom,pm8058-led"; + reg = <0x131>; + label = "pm8058:red"; + default-state = "off"; + }; + led at 132 { + /* + * This is actually green too on my + * board, but documented as yellow. + */ + compatible = "qcom,pm8058-led"; + reg = <0x132>; + label = "pm8058:yellow"; + default-state = "off"; + linux,default-trigger = "mmc0"; + }; + led at 133 { + compatible = "qcom,pm8058-led"; + reg = <0x133>; + label = "pm8058:green"; + default-state = "on"; + linux,default-trigger = "heartbeat"; + }; }; };Signature · 1 line
2.7.4
PATCH 1/1 ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
In reply to Linus WalleijQuoted 27 lines · Linus Walleij
This adds the PM8058 LEDs as used in the platform.
Cc linux-arm-msm at vger.kernel.orgCc linux-leds at vger.kernel.orgCc Andy Gross <[email protected]>Cc Stephen Boyd <[email protected]>Cc Bjorn Andersson <[email protected]>Cc Jacek Anaszewski <[email protected]>Signed-off-by Linus Walleij <[email protected]>---
These DT bindings have been ACKed by Rob Herring and Bjorn Andersson so I think the patch is safe to merge to the Qcom tree.--- arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 39 ++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +3
-0@@ -239,6 +239,45 @@ }; }; }; + + led at 48 { + /*
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts line 254
Quoted 10 lines
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +10
-0+ * The keypad LED @0x48 is routed to + * the sensor board where it is + * connected to an infrared LED + * SFH4650 (60mW, @850nm) next to the + * ambient light and proximity sensor + * Capella Microsystems CM3605. + */ + compatible = "qcom,pm8058-keypad-led"; + reg = <0x48>; + label = "proximity0";
In DT bindings documentation it was changed to "pm8050:white:keypad" to adhere to the LED class device naming convention. I assume that having it in this form is an omission here.
Quoted 30 lines
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +26
-0+ default-state = "off"; + }; + led at 131 { + compatible = "qcom,pm8058-led"; + reg = <0x131>; + label = "pm8058:red"; + default-state = "off"; + }; + led at 132 { + /* + * This is actually green too on my + * board, but documented as yellow. + */ + compatible = "qcom,pm8058-led"; + reg = <0x132>; + label = "pm8058:yellow"; + default-state = "off"; + linux,default-trigger = "mmc0"; + }; + led at 133 { + compatible = "qcom,pm8058-led"; + reg = <0x133>; + label = "pm8058:green"; + default-state = "on"; + linux,default-trigger = "heartbeat"; + }; }; };
Signature · 2 lines
Best regards, Jacek Anaszewski
PATCH 1/1 ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
Quoted 18 lines · Jacek Anaszewski
Quoted 14 lines
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +3
-0+ led at 48 { + /* + * The keypad LED @0x48 is routedto
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +3
-0+ * the sensor board where it is + * connected to an infrared LED + * SFH4650 (60mW, @850nm) next tothe
+ * ambient light and proximity
sensorarch/arm/boot/dts/qcom-apq8060-dragonboard.dts +3
-0+ * Capella Microsystems CM3605. + */ + compatible ="qcom,pm8058-keypad-led";
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts line 254
Quoted 2 lines
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +2
-0+ reg = <0x48>; + label = "proximity0";
Quoted 3 lines
In DT bindings documentation it was changed to "pm8050:white:keypad" to adhere to the LED class device naming convention. I assume that having it in this form is an omission here.
Hm right. Given the usecase here, what do you say about naming it:
"pm8058:infrared:proximitysensor"
?
Yours,
Linus Walleij
PATCH 1/1 ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard
Quoted 21 lines · Linus Walleij
Quoted 18 lines · Jacek Anaszewski
Quoted 16 lines
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +3
-0+ led at 48 { + /* + * The keypad LED @0x48 is routedto
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +3
-0+ * the sensor board where it is + * connected to an infrared LED + * SFH4650 (60mW, @850nm) next tothe
+ * ambient light and proximity
sensorarch/arm/boot/dts/qcom-apq8060-dragonboard.dts +3
-0+ * Capella Microsystems CM3605. + */ + compatible ="qcom,pm8058-keypad-led";
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +2
-0+ reg = <0x48>; + label = "proximity0";
Quoted 8 lines
Quoted 3 lines
In DT bindings documentation it was changed to "pm8050:white:keypad" to adhere to the LED class device naming convention. I assume that having it in this form is an omission here.
Hm right. Given the usecase here, what do you say about naming it:
"pm8058:infrared:proximitysensor"
Looks good.
Signature · 2 lines
Best regards, Jacek Anaszewski