Skip to contentSkip to conversation

bash: fix interpreter of ptest script

PATCH In review [email protected] 2 participants 4 messages Aug 24, 2016 – Aug 25, 2016

lore
Share & tools
lore
#0 lore raw

cover bash: fix interpreter of ptest script

From: Kai Kang <[email protected]>

The following changes since commit 94646f4828c2aa11a89996763edaa2e9d57106a9:

oeqa/buildiptables: Switch from netfilter.org to yoctoproject.org mirror (2016-08-23 17:59:43 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib kangkai/bash
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/bash

Kai Kang (1):
bash: fix interpreter of ptest script

 meta/recipes-extended/bash/bash.inc | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 bash: fix interpreter of ptest script

From: Kai Kang <[email protected]>

The interpreter of bash ptest script tests/getopts5.sub is /local/bin/bash which is not suitable for oe. Use /bin/bash instead.

---
 meta/recipes-extended/bash/bash.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-extended/bash/bash.inc +2 -0
index 1d08526..d299a4a 100644
@@ -54,6 +54,8 @@ do_install_ptest () {
 	cp ${B}/Makefile ${D}${PTEST_PATH}
         sed -i -e 's/^Makefile/_Makefile/' -e "s,--sysroot=${STAGING_DIR_TARGET},,g" \
 	    -e "s,${S},,g" -e "s,${B},,g" -e "s,${STAGING_DIR_NATIVE},,g" ${D}${PTEST_PATH}/Makefile
+
+	sed -i -e 's:/local\(/bin/bash\):\1:' ${D}${PTEST_PATH}/tests/getopts5.sub
 }
 
 pkg_postinst_${PN} () {
Signature · 1 line
2.9.3
#2 lore raw
Quoted 3 lines · On 24 August 2016 at 10:26, <[email protected]> wrote:

The interpreter of bash ptest script tests/getopts5.sub is /local/bin/bash which is not suitable for oe. Use /bin/bash instead.

Presumably this test is executed under bash explicitly, so is this really worth fixing?

Ross

author
#3 lore raw
Quoted 8 lines · Ross

On 24 August 2016 at 10:26, <[email protected] <mailto:[email protected]>> wrote:

The interpreter of bash ptest script tests/getopts5.sub is /local/bin/bash which is not suitable for oe. Use /bin/bash instead.

Presumably this test is executed under bash explicitly, so is this really worth fixing?

I sent the patch to bash maillist and it is not accepted too. So please ignore it. Thanks.

--Kai

Quoted 2 lines

Ross

Signature · 2 lines
Regards,
Neil | Kai Kang