rtc: changed raw spi calls to register map calls
PATCH 1/1 rtc: changed raw spi calls to register map calls
Quoted 1 line
From
2ec82b6c9b99647e31d26c4c828dc7c51af8a633Mon Sep 17 00:00:00 2001
From: Raghavendra Ganiga <[email protected]>
Date: Wed, 31 Aug 2016 01:13:30 +0530
Subject: [PATCH] rtc: changed raw spi calls to register map calls
This patch changes calls of spi read write calls to register map read and write calls
--- drivers/rtc/Kconfig | 1 + drivers/rtc/rtc-ds1347.c | 102 ++++++++++++++++++++++++++--------------------- 2 files changed, 58 insertions(+), 45 deletions(-)
drivers/rtc/Kconfig +1 -0
@@ -655,6 +655,7 @@ config RTC_DRV_DS1343 will be called rtc-ds1343. config RTC_DRV_DS1347 + select REGMAP_SPI tristate "Dallas/Maxim DS1347" help If you say yes here you get support for the
drivers/rtc/rtc-ds1347.c +57 -45
168 lines not on this page · raw message
Signature · 11 lines
1.9.1 -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
Hi,
Please fix the subject, this patch is ds1347 specific.
Quoted 8 lines · RAGHAVENDRA GANIGA
From
2ec82b6c9b99647e31d26c4c828dc7c51af8a633Mon Sep 17 00:00:00 2001
From: Raghavendra Ganiga <[email protected]>
Date: Wed, 31 Aug 2016 01:13:30 +0530
Subject: [PATCH] rtc: changed raw spi calls to register map callsThis patch changes calls of spi read write calls to register map read and write calls
Can you explain why you need that change? I'm not sure what you gain from it (it makes the driver and the kernel bigger).
drivers/rtc/rtc-ds1347.c static int ds1347_read_time(struct device *dev, struct rtc_time *dt) · line 89
Quoted 4 lines
drivers/rtc/rtc-ds1347.c +2
-1/* year in linux is from 1900 i.e in range of 100 -in rtc it is from 00 to 99 */ +* in rtc it is from 00 to 99 +*/
Unrelated change.
Signature · 13 lines
Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
Quoted 4 lines · Alexandre Belloni
Hi,
Please fix the subject, this patch is ds1347 specific.
Yes I will fix the subject
Quoted 6 lines · RAGHAVENDRA GANIGA
Quoted 5 lines
From
2ec82b6c9b99647e31d26c4c828dc7c51af8a633Mon Sep 17 00:00:00 2001
From: Raghavendra Ganiga <[email protected]>
Date: Wed, 31 Aug 2016 01:13:30 +0530
Subject: [PATCH] rtc: changed raw spi calls to register map calls
Quoted 7 lines
Quoted 3 lines
This patch changes calls of spi read write calls to register map read and write calls
Can you explain why you need that change? I'm not sure what you gain from it (it makes the driver and the kernel bigger).
Regmaps abstract layer are a better way of accessing register through spi interface rather than accessing directly through SPI layer
Quoted 8 lines
drivers/rtc/rtc-ds1347.c static int ds1347_read_time(struct device *dev, struct rtc_time *dt) · line 89
Quoted 4 lines
drivers/rtc/rtc-ds1347.c +2
-1/* year in linux is from 1900 i.e in range of 100 -in rtc it is from 00 to 99 */ +* in rtc it is from 00 to 99 +*/ Unrelated change.
will have a seperate patch for this checkpatch.pl fix
Signature · 8 lines
You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.