net: Fix cache misalignment message after network load operations
PATCH v3 1/1 net: Fix cache misalignment message after network load operations
After any operation that downloads a file (e.g., pxe get, or dhcp), the buffer containing the downloaded data is flushed. This is unnecessary and annoying. Unnecessary, because
the network driver should already have fliushed the cache for the DMAed area, and annoying because it generates a cache misalignment message.
--- cmd/net.c | 3 --- 1 file changed, 3 deletions(-)
cmd/net.c +0 -3
@@ -243,9 +243,6 @@ static int netboot_common(enum proto_t preturn CMD_RET_SUCCESS ; } -/* flush cache */ -flush_cache (load_addr, size); -bootstage_mark (BOOTSTAGE_ID_NET_LOADED ); rcode =bootm_maybe_autostart (cmdtp, argv[0 ]);
PATCH v3 1/1 net: Fix cache misalignment message after network load operations
Hello Peter,
Am 14.09.2016 um 05:49 schrieb Peter.Chubb at data61.csiro.au:
Quoted 10 lines
After any operation that downloads a file (e.g., pxe get, or dhcp), the buffer containing the downloaded data is flushed. This is unnecessary and annoying. Unnecessary, because
the network driver should already have fliushed the cache for the DMAed area, and annoying because it generates a cache misalignment message.Signed-off-by Peter Chubb <[email protected]>--- cmd/net.c | 3 --- 1 file changed, 3 deletions(-)
I posted a fix for this here:
http://patchwork.ozlabs.org/patch/663489/
but I did not remove the flush operation ... can we really remove it?
If so, you can add my
bye,
Heiko
Quoted 20 lines
Index:
u-boot/cmd/net.c
===================================================================cmd/net.c +0
-3@@ -243,9 +243,6 @@ static int netboot_common(enum proto_t preturn CMD_RET_SUCCESS ; } -/* flush cache */ -flush_cache (load_addr, size); -bootstage_mark (BOOTSTAGE_ID_NET_LOADED ); rcode =bootm_maybe_autostart (cmdtp, argv[0 ]);_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH v3 1/1 net: Fix cache misalignment message after network load operations
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Heiko" == Heiko Schocher <[email protected]> writes:
Heiko> Hello Peter, Am 14.09.2016 um 05:49 schrieb Heiko> Peter.Chubb at data61.csiro.au:
Quoted 9 lines
Quoted 9 lines
After any operation that downloads a file (e.g., pxe get, or dhcp), the buffer containing the downloaded data is flushed. This is unnecessary and annoying. Unnecessary, because the network driver should already have fliushed the cache for the DMAed area, and annoying because it generates a cache misalignment message.
Signed-off-by Peter Chubb <[email protected]>---
cmd/net.c| 3 --- 1 file changed, 3 deletions(-)
Heiko> I posted a fix for this here:
Heiko> http://patchwork.ozlabs.org/patch/663489/
Heiko> but I did not remove the flush operation ... can we really Heiko> remove it?
I believe so -- removing it was suggested by Joe Hershberger.
Heiko> If so, you can add my Acked-by: Heiko Schocher <[email protected]>
OK. thanks.
Signature · 2 lines
Dr Peter Chubb Tel: +61 2 9490 5852 http://ts.data61.csiro.au/ Trustworthy Systems Group Data61 (formerly NICTA)
PATCH v3 1/1 net: Fix cache misalignment message after network load operations
In reply to Peter.Chubb at data61.csiro.auQuoted 7 lines · On Tue, Sep 13, 2016 at 10:49 PM, <[email protected]> wrote:
After any operation that downloads a file (e.g., pxe get, or dhcp), the buffer containing the downloaded data is flushed. This is unnecessary and annoying. Unnecessary, because
the network driver should already have fliushed the cache for the DMAed area, and annoying because it generates a cache misalignment message.Signed-off-by Peter Chubb <[email protected]>
PATCH v3 1/1 net: Fix cache misalignment message after network load operations
In reply to Peter.Chubb at data61.csiro.auQuoted 9 lines · Peter Chubb
After any operation that downloads a file (e.g., pxe get, or dhcp), the buffer containing the downloaded data is flushed. This is unnecessary and annoying. Unnecessary, because
the network driver should already have fliushed the cache for the DMAed area, and annoying because it generates a cache misalignment message.Signed-off-by Peter Chubb <[email protected]>Acked-by Heiko Schocher <[email protected]>Acked-by Joe Hershberger <[email protected]>
Joe, do you want to pick this up or should I? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161005/7af841f9/attachment.sig>
PATCH v3 1/1 net: Fix cache misalignment message after network load operations
Quoted 8 lines · Tom Rini
Quoted 6 lines · Peter Chubb
After any operation that downloads a file (e.g., pxe get, or dhcp), the buffer containing the downloaded data is flushed. This is unnecessary and annoying. Unnecessary, because
the network driver should already have fliushed the cache for the DMAed area, and annoying because it generates a cache misalignment message.
Quoted 7 lines
Quoted 3 lines
Signed-off-by Peter Chubb <[email protected]>Acked-by Heiko Schocher <[email protected]>Acked-by Joe Hershberger <[email protected]>Reviewed-by Tom Rini <[email protected]>Joe, do you want to pick this up or should I? Thanks!
I'll get it.
Thanks,
-Joe