Skip to contentSkip to conversation

ocfs2: fix undefined struct variable in inode.h

PATCH Applied Joseph Qi 2 participants 2 messages Sep 21, 2016 – Sep 22, 2016 OCFS2

lore
Share & tools
lore

Joseph Qi

author
#0 lore raw

PATCH 1/1 ocfs2: fix undefined struct variable in inode.h

The extern struct variable ocfs2_inode_cache is not defined. It meant to use ocfs2_inode_cachep defined in super.c, I think. Fortunately it is not used anywhere now, so no impact actually. Clean it up to fix this mistake.

Signed-off-by Joseph Qi <[email protected]>
---
 fs/ocfs2/inode.h | 2 --
 1 file changed, 2 deletions(-)
fs/ocfs2/inode.h +0 -2
index 50cc550..5af68fc 100644
@@ -123,8 +123,6 @@ static inline struct ocfs2_inode_info *OCFS2_I(struct inode *inode)
 #define INODE_JOURNAL(i) (OCFS2_I(i)->ip_flags & OCFS2_INODE_JOURNAL)
 #define SET_INODE_JOURNAL(i) (OCFS2_I(i)->ip_flags |= OCFS2_INODE_JOURNAL)
 
-extern struct kmem_cache *ocfs2_inode_cache;
-
 extern const struct address_space_operations ocfs2_aops;
 extern const struct ocfs2_caching_operations ocfs2_inode_caching_ops;
Signature · 1 line
1.8.4.3
#1 lore raw

PATCH 1/1 ocfs2: fix undefined struct variable in inode.h

Hi,

Quoted 6 lines · Joseph Qi

The extern struct variable ocfs2_inode_cache is not defined. It meant to use ocfs2_inode_cachep defined in super.c, I think. Fortunately it is not used anywhere now, so no impact actually. Clean it up to fix this mistake.

Signed-off-by Joseph Qi <[email protected]>

LGTM

Reviewed-by Eric Ren<[email protected]>
Quoted 9 lines
---
  fs/ocfs2/inode.h | 2 --
  1 file changed, 2 deletions(-)
fs/ocfs2/inode.h +0 -0
index 50cc550..5af68fc 100644

fs/ocfs2/inode.h static inline struct ocfs2_inode_info *OCFS2_I(struct inode *inode) · line 128

Quoted 8 lines
fs/ocfs2/inode.h +0 -2
@@ -123,8 +123,6 @@ static inline struct ocfs2_inode_info *OCFS2_I(struct inode *inode)
  #define INODE_JOURNAL(i) (OCFS2_I(i)->ip_flags & OCFS2_INODE_JOURNAL)
  #define SET_INODE_JOURNAL(i) (OCFS2_I(i)->ip_flags |= OCFS2_INODE_JOURNAL)
 
-extern struct kmem_cache *ocfs2_inode_cache;
-
  extern const struct address_space_operations ocfs2_aops;
  extern const struct ocfs2_caching_operations ocfs2_inode_caching_ops;

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20160922/d0acd4f0/attachment.html