Skip to contentSkip to conversation

ARM: dts: socfpga: Add Macnica sodia board

PATCH New Nobuhiro Iwamatsu 4 participants 5 messages Sep 24, 2016 – Nov 1, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: socfpga: Add Macnica sodia board

Add support for board based on the Altera Cyclone V SoC. This board has the following functions:
- 1 GiB of DRAM
- 1 Gigabit ethernet
- 1 SD card slot
- 1 USB gadget port
- QSPI NOR Flash
- I2C EEPROMs and I2C RTC
- DVI output
- Audio port

This commit supports without QSPI, DVI and Audio.

---
V2: move the PHY of setting to the Ethetnet PHY node level.

 arch/arm/boot/dts/Makefile                   |   1 +
 arch/arm/boot/dts/socfpga_cyclone5_sodia.dts | 123 +++++++++++++++++++++++++++
 2 files changed, 124 insertions(+)
 create mode 100644 arch/arm/boot/dts/socfpga_cyclone5_sodia.dts
arch/arm/boot/dts/Makefile +1 -0
index befcd26..7c5f0c3 100644
@@ -696,6 +696,7 @@ dtb-$(CONFIG_ARCH_SOCFPGA) += \
 	socfpga_cyclone5_de0_sockit.dtb \
 	socfpga_cyclone5_sockit.dtb \
 	socfpga_cyclone5_socrates.dtb \
+	socfpga_cyclone5_sodia.dtb \
 	socfpga_cyclone5_vining_fpga.dtb \
 	socfpga_vt.dtb
 dtb-$(CONFIG_ARCH_SPEAR13XX) += \
arch/arm/boot/dts/socfpga_cyclone5_sodia.dts new file +123 -0

123 lines not on this page · raw message

Signature · 1 line
2.9.3
#1 lore raw

PATCH v2 1/1 ARM: dts: socfpga: Add Macnica sodia board

Quoted 121 lines · Nobuhiro Iwamatsu

Add support for board based on the Altera Cyclone V SoC. This board has the following functions:
- 1 GiB of DRAM
- 1 Gigabit ethernet
- 1 SD card slot
- 1 USB gadget port
- QSPI NOR Flash
- I2C EEPROMs and I2C RTC
- DVI output
- Audio port

This commit supports without QSPI, DVI and Audio.

---
V2: move the PHY of setting to the Ethetnet PHY node level.

 arch/arm/boot/dts/Makefile                   |   1 +
 arch/arm/boot/dts/socfpga_cyclone5_sodia.dts | 123 +++++++++++++++++++++++++++
 2 files changed, 124 insertions(+)
 create mode 100644 arch/arm/boot/dts/socfpga_cyclone5_sodia.dts
arch/arm/boot/dts/Makefile +1 -0
index befcd26..7c5f0c3 100644
@@ -696,6 +696,7 @@ dtb-$(CONFIG_ARCH_SOCFPGA) += \
 	socfpga_cyclone5_de0_sockit.dtb \
 	socfpga_cyclone5_sockit.dtb \
 	socfpga_cyclone5_socrates.dtb \
+	socfpga_cyclone5_sodia.dtb \
 	socfpga_cyclone5_vining_fpga.dtb \
 	socfpga_vt.dtb
 dtb-$(CONFIG_ARCH_SPEAR13XX) += \
arch/arm/boot/dts/socfpga_cyclone5_sodia.dts new file +81 -0
new file mode 100644
index 0000000..9aaf413
@@ -0,0 +1,123 @@
+/*
+ *  Copyright (C) 2016 Nobuhiro Iwamatsu <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "socfpga_cyclone5.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+
+/ {
+	model = "Altera SOCFPGA Cyclone V SoC Macnica Sodia board";
+	compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+
+	chosen {
+		bootargs = "earlyprintk";
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory {
+		name = "memory";
+		device_type = "memory";
+		reg = <0x0 0x40000000>;
+	};
+
+	aliases {
+		ethernet0 = &gmac1;
+	};
+
+	regulator_3_3v: 3-3-v-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "3.3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
+	leds: gpio-leds {
+		compatible = "gpio-leds";
+
+		hps_led0 {
+			label = "hps:green:led0";
+			gpios = <&portb 12 GPIO_ACTIVE_LOW>;
+		};
+
+		hps_led1 {
+			label = "hps:green:led1";
+			gpios = <&portb 13 GPIO_ACTIVE_LOW>;
+		};
+
+		hps_led2 {
+			label = "hps:green:led2";
+			gpios = <&portb 14 GPIO_ACTIVE_LOW>;
+		};
+
+		hps_led3 {
+			label = "hps:green:led3";
+			gpios = <&portb 15 GPIO_ACTIVE_LOW>;
+		};
+	};
+};
+
+&gmac1 {
+	status = "okay";
+	phy-mode = "rgmii";
+	phy = <&phy0>;
+
+	mdio0 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		phy0: ethernet-phy at 0 {

arch/arm/boot/dts/socfpga_cyclone5_sodia.dts line 91

Quoted 10 lines
arch/arm/boot/dts/socfpga_cyclone5_sodia.dts new file +10 -0
+			reg = <0>;
+			rxd0-skew-ps = <0>;
+			rxd1-skew-ps = <0>;
+			rxd2-skew-ps = <0>;
+			rxd3-skew-ps = <0>;
+			rxdv-skew-ps = <0>;
+			rxc-skew-ps = <3000>;
+			txen-skew-ps = <0>;
+			txc-skew-ps = <3000>;
+		};

This looks much better now, thanks!
--
Florian

Applied
#2 lore raw

PATCH v2 1/1 ARM: dts: socfpga: Add Macnica sodia board

In reply to Nobuhiro Iwamatsu
Quoted 11 lines · Nobuhiro Iwamatsu

Add support for board based on the Altera Cyclone V SoC. This board has the following functions:
- 1 GiB of DRAM
- 1 Gigabit ethernet
- 1 SD card slot
- 1 USB gadget port
- QSPI NOR Flash
- I2C EEPROMs and I2C RTC
- DVI output
- Audio port

Quoted 6 lines

This commit supports without QSPI, DVI and Audio.

---
V2: move the PHY of setting to the Ethetnet PHY node level.

Applied. Thanks!

Dinh

#3 lore raw

PATCH v2 1/1 ARM: dts: socfpga: Add Macnica sodia board

In reply to Nobuhiro Iwamatsu

Hi,

Saw this when looking at the patch when merging it.

Please fix up with incremental patch. Dinh, this goes for other platforms under socfpga too, several have this problem:

Quoted 20 lines · Nobuhiro Iwamatsu
arch/arm/boot/dts/socfpga_cyclone5_sodia.dts new file +14 -0
new file mode 100644
index 0000000..9aaf413
@@ -0,0 +1,123 @@
+/*
+ *  Copyright (C) 2016 Nobuhiro Iwamatsu <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License

arch/arm/boot/dts/socfpga_cyclone5_sodia.dts line 24

Quoted 10 lines
arch/arm/boot/dts/socfpga_cyclone5_sodia.dts new file +10 -0
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "socfpga_cyclone5.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+
+/ {
+       model = "Altera SOCFPGA Cyclone V SoC Macnica Sodia board";
+       compatible = "altr,socfpga-cyclone5", "altr,socfpga";

You should add a compatible entry for your specific board. Compatible goes from specific to generic, so something like:

compatible = "altr,macnica-sodia", "latr,socfpga-cyclone5", "altr,socfpga";

You can even add entries for the specific rev (if there are differences). But at the very least, add one for the board.

Dinh, please follow up for other boards as well. I've still merged the pull request you sent (email about that separately).

Regards,

-Olof

#4 lore raw

PATCH v2 1/1 ARM: dts: socfpga: Add Macnica sodia board

Hi Olof,

Quoted 42 lines · Olof Johansson

Hi,

Saw this when looking at the patch when merging it.

Please fix up with incremental patch. Dinh, this goes for other platforms under socfpga too, several have this problem:

Quoted 20 lines · Nobuhiro Iwamatsu
arch/arm/boot/dts/socfpga_cyclone5_sodia.dts new file +14 -0
new file mode 100644
index 0000000..9aaf413
@@ -0,0 +1,123 @@
+/*
+ *  Copyright (C) 2016 Nobuhiro Iwamatsu <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License

arch/arm/boot/dts/socfpga_cyclone5_sodia.dts line 24

Quoted 10 lines
arch/arm/boot/dts/socfpga_cyclone5_sodia.dts new file +10 -0
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "socfpga_cyclone5.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+
+/ {
+       model = "Altera SOCFPGA Cyclone V SoC Macnica Sodia board";
+       compatible = "altr,socfpga-cyclone5", "altr,socfpga";

You should add a compatible entry for your specific board. Compatible goes from specific to generic, so something like:

Quoted 9 lines

compatible = "altr,macnica-sodia", "latr,socfpga-cyclone5", "altr,socfpga";

You can even add entries for the specific rev (if there are differences). But at the very least, add one for the board.

Dinh, please follow up for other boards as well. I've still merged the pull request you sent (email about that separately).

Thanks for noticing this. I'll send a patch to fix this shortly.

Dinh