linux/mm.h: canonicalize macro PAGE_ALIGNED() definition
Subsystems (2)
RFC PATCH 1/1 linux/mm.h: canonicalize macro PAGE_ALIGNED() definition
From: zijun_hu <[email protected]>
macro PAGE_ALIGNED() is prone to cause error because it doesn't follow convention to parenthesize parameter @addr within macro body, for example unsigned long *ptr = kmalloc(...); PAGE_ALIGNED(ptr + 16); for the left parameter of macro IS_ALIGNED(), (unsigned long)(ptr + 16) is desired but the actual one is (unsigned long)ptr + 16
it is fixed by simply canonicalizing macro PAGE_ALIGNED() definition
Signed-off-by zijun_hu <[email protected]>
--- include/linux/mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mm.h +1 -1
@@ -126,7 +126,7 @@ extern int overcommit_kbytes_handler(struct ctl_table *, int, void __user *,#define PAGE_ALIGN (addr) ALIGN(addr, PAGE_SIZE)/* test whether an address (unsigned long or pointer) is aligned to PAGE_SIZE */ -#define PAGE_ALIGNED (addr) IS_ALIGNED((unsigned long)addr, PAGE_SIZE) +#define PAGE_ALIGNED (addr) IS_ALIGNED((unsigned long)(addr), PAGE_SIZE)/* * Linux kernel virtual memory manager primitives.
Signature · 8 lines
1.9.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>