elfutils: clarify licensing info
PATCH 1/1 elfutils: clarify licensing info
From: Gustavo Zacarias <[email protected]>
elfutils libraries are GPLv2 or LGPLv3+, standalone programs are GPLv3+ (see the NEWS file).
Make the GPLv3+ license tag/file dependant on the programs being enabled, and make the GPLv2/LGPLv3+ tag more descriptive.
--- package/elfutils/elfutils.mk | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
package/elfutils/elfutils.mk +8 -2
@@ -8,10 +8,16 @@ ELFUTILS_VERSION = 0.166 ELFUTILS_SOURCE = elfutils-$(ELFUTILS_VERSION).tar.bz2 ELFUTILS_SITE = https://fedorahosted.org/releases/e/l/elfutils/$(ELFUTILS_VERSION) ELFUTILS_INSTALL_STAGING = YES -ELFUTILS_LICENSE = GPLv3, GPLv2, LGPLv3 -ELFUTILS_LICENSE_FILES = COPYING COPYING-GPLV2 COPYING-LGPLV3 +ELFUTILS_LICENSE = GPLv2 or LGPLv3+ (library) +ELFUTILS_LICENSE_FILES = COPYING-GPLV2 COPYING-LGPLV3 ELFUTILS_DEPENDENCIES = zlib +# Programs are GPLv3+ so add it when they're enabled +ifeq ($(BR2_PACKAGE_ELFUTILS_PROGS),y) +ELFUTILS_LICENSE += GPLv3+ (programs) +ELFUTILS_LICENSE_FILES += COPYING +endif + # We patch configure.ac ELFUTILS_AUTORECONF = YES
Signature · 1 line
2.7.3
PATCH 1/1 elfutils: clarify licensing info
Hi,
Quoted 7 lines · gustavo.zacarias at free-electrons.com
From: Gustavo Zacarias <[email protected]>
elfutils libraries are GPLv2 or LGPLv3+, standalone programs are GPLv3+ (see the NEWS file).
Make the GPLv3+ license tag/file dependant on the programs being enabled, and make the GPLv2/LGPLv3+ tag more descriptive.
License string should be GPLv2+ instead of GPLv2 because license header uses clause "either version 2 of the License, or (at your option) any later version". With that license string for library is "GPLv2+ or LGPLv3+"
Quoted 10 lines
Signed-off-by Gustavo Zacarias <[email protected]>--- package/elfutils/elfutils.mk | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)package/elfutils/elfutils.mk +0
-0
package/elfutils/elfutils.mk ELFUTILS_VERSION = 0.166 · line 11
Quoted 6 lines
package/elfutils/elfutils.mk +1
-2@@ -8,10 +8,16 @@ ELFUTILS_VERSION = 0.166 ELFUTILS_SOURCE = elfutils-$(ELFUTILS_VERSION).tar.bz2 ELFUTILS_SITE = https://fedorahosted.org/releases/e/l/elfutils/$(ELFUTILS_VERSION) ELFUTILS_INSTALL_STAGING = YES -ELFUTILS_LICENSE = GPLv3, GPLv2, LGPLv3 -ELFUTILS_LICENSE_FILES = COPYING COPYING-GPLV2 COPYING-LGPLV3 +ELFUTILS_LICENSE = GPLv2 or LGPLv3+ (library)
As mentioned above it should be
ELFUTILS_LICENSE = GPLv2+ or LGPLv3+ (library)
package/elfutils/elfutils.mk ELFUTILS_VERSION = 0.166 · line 16
Quoted 5 lines
package/elfutils/elfutils.mk +3
-0+ELFUTILS_LICENSE_FILES = COPYING-GPLV2 COPYING-LGPLV3 ELFUTILS_DEPENDENCIES = zlib +# Programs are GPLv3+ so add it when they're enabled +ifeq ($(BR2_PACKAGE_ELFUTILS_PROGS),y)
There is same if condition down. Instead we should conditionally add license there.
package/elfutils/elfutils.mk ELFUTILS_VERSION = 0.166 · line 17
Quoted 1 line
package/elfutils/elfutils.mk +1
-0+ELFUTILS_LICENSE += GPLv3+ (programs)
Since it is separate component, it should be comma separated.
ELFUTILS_LICENSE := $(ELFUTILS_LICENSE), GPLv3+ (programs)
Regards,
Rahul
PATCH 1/1 elfutils: clarify licensing info
Quoted 5 lines · Rahul Bedarkar
Hi,
License string should be GPLv2+ instead of GPLv2 because license header uses clause "either version 2 of the License, or (at your option) any later version". With that license string for library is "GPLv2+ or LGPLv3+"
Right, fixed for v2.
Quoted 2 lines
There is same if condition down. Instead we should conditionally add license there.
Missed that optimization, fixed.
Quoted 5 lines
Quoted 1 line
+ELFUTILS_LICENSE += GPLv3+ (programs)
Since it is separate component, it should be comma separated.
ELFUTILS_LICENSE:= $(ELFUTILS_LICENSE), GPLv3+ (programs)
Most packages don't do this correctly, only a few do and i've used those as example, though it's no excuse. Care to fix the others? Regards.
PATCH 1/1 elfutils: clarify licensing info
Hello,
Quoted 8 lines · Gustavo Zacarias
Quoted 5 lines
Quoted 1 line
+ELFUTILS_LICENSE += GPLv3+ (programs)
Since it is separate component, it should be comma separated.
ELFUTILS_LICENSE:= $(ELFUTILS_LICENSE), GPLv3+ (programs)Most packages don't do this correctly, only a few do and i've used those as example, though it's no excuse. Care to fix the others?
I will add it to my todo list.
Thanks,
Rahul