Skip to contentSkip to conversation

tests/functional/ppc: skip remote interrupts test if -net user not built

PATCH Applied Shivang Upadhyay 3 participants 4 messages Jul 28 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 tests/functional/ppc: skip remote interrupts test if -net user not built

While running remote interrupts test, without libslirp-devel installed, facing the following panic logs.

File

    ...
    raise VMLaunchFailure(
    ...<3 lines>...
    ) from exc
    ...
        Output: qemu-system-ppc64: -netdev user,id=net0: network backend

'user' is not compiled into this binary

Adding netdev user requirement for this test.

Fixes 63f5ba80921 ("tests/functional: tests/functional: Add remote interrupts test for PowerNV")

---

Changelog:

v3:
- rearranging the require_netdev, before set_machine. to keep all test requirements in same place, as suggested by Amit.
- keeping review tags from Thomas and Amit.

v2: https://lore.kernel.org/qemu-devel/[email protected]/
- moved to require_netdev method, suggested by Amit and Thomas.

v1: https://lore.kernel.org/qemu-devel/[email protected]/

---
 tests/functional/ppc64/test_powernv.py | 1 +
 1 file changed, 1 insertion(+)
tests/functional/ppc64/test_powernv.py +1 -0
index bac2017e18..f3e05e4d38 100755
@@ -90,6 +90,7 @@ def test_linux_smt_boot(self):
 
     def test_linux_remote_interrupts(self):
         self.require_accelerator("tcg")
+        self.require_netdev('user')
         self.set_machine('powernv')
 
         # Have below setup in this test:
Signature · 1 line
2.54.0
Tested-by on v3 1/1
#1 lore raw
Quoted 14 lines · Shivang Upadhyay

While running remote interrupts test, without libslirp-devel installed, facing the following panic logs.

File

    ...
    raise VMLaunchFailure(
    ...<3 lines>...
    ) from exc
    ...
        Output: qemu-system-ppc64: -netdev user,id=net0: network backend

'user' is not compiled into this binary

Adding netdev user requirement for this test.

Quoted 7 lines
Fixes 63f5ba80921 ("tests/functional: tests/functional: Add remote interrupts test for PowerNV")

---

Looks like my Tested-by: from v2 got missed. Anyhow, sharing it again here...

Tested on a system without libslirp-devel. Test is correctly skipped:

ok 1 test_powernv.PowernvMachine.test_linux_remote_interrupts # SKIP no support for user networking 1..1

Thanks,
Amit

Quoted 34 lines

Changelog:

v3:
- rearranging the require_netdev, before set_machine. to keep all test requirements in same place, as suggested by Amit.
- keeping review tags from Thomas and Amit.

v2: https://lore.kernel.org/qemu-devel/[email protected]/
- moved to require_netdev method, suggested by Amit and Thomas.

v1: https://lore.kernel.org/qemu-devel/[email protected]/

---
 tests/functional/ppc64/test_powernv.py | 1 +
 1 file changed, 1 insertion(+)
tests/functional/ppc64/test_powernv.py +1 -0
index bac2017e18..f3e05e4d38 100755
@@ -90,6 +90,7 @@ def test_linux_smt_boot(self):
 
     def test_linux_remote_interrupts(self):
         self.require_accelerator("tcg")
+        self.require_netdev('user')
         self.set_machine('powernv')
 
         # Have below setup in this test:
Signature · 1 line
2.54.0
#2 lore raw
Quoted 10 lines · Amit Machhiwal
Quoted 6 lines
Fixes 63f5ba80921 ("tests/functional: tests/functional: Add remote

interrupts test for PowerNV")

---

Looks like my Tested-by: from v2 got missed. Anyhow, sharing it again here...

Quoted 8 lines

Tested on a system without libslirp-devel. Test is correctly skipped:

  ok 1 test_powernv.PowernvMachine.test_linux_remote_interrupts # SKIP no support for user networking
  1..1

Thanks for posting again. I missed to pick it.

~Shivang.

#3 lore raw
In reply to Shivang Upadhyay
Quoted 14 lines · Shivang Upadhyay

While running remote interrupts test, without libslirp-devel installed, facing the following panic logs.

   File
     ...
     raise VMLaunchFailure(
     ...<3 lines>...
     ) from exc
     ...
         Output: qemu-system-ppc64: -netdev user,id=net0: network backend

'user' is not compiled into this binary

Adding netdev user requirement for this test.

Quoted 7 lines
Fixes 63f5ba80921 ("tests/functional: tests/functional: Add remote interrupts test for PowerNV")

---

Queued via hw-misc, thanks.