net/mana: fix counter overflow for posted WQE
PATCH 1/1 net/mana: fix counter overflow for posted WQE
From: Long Li <[email protected]>
This counter should set to uint16_t, the same type as pkt_received. Otherwise, it may overflow when pkt_received goes over 256.
Thanks Xinhao Kong <[email protected]> for debugging.
--- drivers/net/mana/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mana/rx.c +1 -1
@@ -399,7 +399,7 @@ uint16_t mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) {uint16_t pkt_received =0 ; -uint8_t wqe_posted =0 ; +uint16_t wqe_posted =0 ;struct mana_rxq *rxq = dpdk_rxq;struct mana_priv *priv = rxq->priv;struct rte_mbuf *mbuf;
Signature · 1 line
2.34.1
PATCH v2 1/1 net/mana: fix counter overflow for posted WQE
From: Long Li <[email protected]>
This counter should set to uint16_t, the same type as pkt_received. Otherwise, it may overflow when pkt_received goes over 256.
Thanks Xinhao Kong <[email protected]> for debugging this.
---
Change log:
v2: added "Signed-off-by"
drivers/net/mana/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mana/rx.c +1 -1
@@ -399,7 +399,7 @@ uint16_t mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) {uint16_t pkt_received =0 ; -uint8_t wqe_posted =0 ; +uint16_t wqe_posted =0 ;struct mana_rxq *rxq = dpdk_rxq;struct mana_priv *priv = rxq->priv;struct rte_mbuf *mbuf;
Signature · 1 line
2.34.1
Ferruh Yigit
AppliedQuoted 5 lines · On 7/11/2023 12:51 AM, [email protected] wrote:
From: Long Li <[email protected]>
This counter should set to
uint16_t, the same type aspkt_received. Otherwise, it may overflow whenpkt_receivedgoes over 256.
Quoted 7 lines
Thanks Xinhao Kong <[email protected]> for debugging this.
Fixes 517ed6e2d590 ("net/mana: add basic driver with build environment")Signed-off-by Long Li <[email protected]>
Applied to dpdk-next-net/main, thanks.