Skip to contentSkip to conversation

ARM: dts: socfpga: Fix NAND controller clock supply

PATCH New Marek Vasut 2 participants 2 messages May 10, 2018 – May 14, 2018 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: socfpga: Fix NAND controller clock supply

The Denali NAND x-clock should be supplied by nand_x_clk, not by nand_clk. Fix this, otherwise the Denali driver gets incorrect clock frequency information and incorrectly configures the NAND timing.

Fixes d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
Cc Steffen Trumtrar <[email protected]>
Cc Dinh Nguyen <[email protected]>
---
 arch/arm/boot/dts/socfpga.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +1 -1
index d697f5062624..e719c20a0e65 100644
@@ -750,7 +750,7 @@
 			reg-names = "nand_data", "denali_reg";
 			interrupts = <0x0 0x90 0x4>;
 			dma-mask = <0xffffffff>;
-			clocks = <&nand_clk>;
+			clocks = <&nand_x_clk>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.16.2
#1 lore raw

PATCH 1/1 ARM: dts: socfpga: Fix NAND controller clock supply

Quoted 19 lines · Marek Vasut

The Denali NAND x-clock should be supplied by nand_x_clk, not by nand_clk. Fix this, otherwise the Denali driver gets incorrect clock frequency information and incorrectly configures the NAND timing.

Fixes d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
Cc Steffen Trumtrar <[email protected]>
Cc Dinh Nguyen <[email protected]>
---
 arch/arm/boot/dts/socfpga.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +0 -0
index d697f5062624..e719c20a0e65 100644

arch/arm/boot/dts/socfpga.dtsi line 756

Quoted 8 lines
arch/arm/boot/dts/socfpga.dtsi +1 -1
@@ -750,7 +750,7 @@
 			reg-names = "nand_data", "denali_reg";
 			interrupts = <0x0 0x90 0x4>;
 			dma-mask = <0xffffffff>;
-			clocks = <&nand_clk>;
+			clocks = <&nand_x_clk>;
 			status = "disabled";
 		};
 

Applied and cc'ed stable kernel.

Thanks,
Dinh