Skip to contentSkip to conversation

common: env: add kconfig entry for env storage

PATCH New Peng Fan 4 participants 4 messages Oct 8, 2016 – Oct 18, 2016

lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH 1/1 common: env: add kconfig entry for env storage

Add Kconfig entry for ENV storage

Cc Simon Glass <[email protected]>
Cc Heiko Schocher <[email protected]>
Cc Tom Rini <[email protected]>
Cc Masahiro Yamada <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Francois Retief <[email protected]>
---
 common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 73 insertions(+)
common/Kconfig +73 -0
index c69c141..a630924 100644
@@ -158,6 +158,79 @@ config SPI_BOOT
 
 endmenu
 
+menu "ENV storage media"
+
+config ENV_IS_IN_DATAFLASH
+	bool "env stored in dataflash"
+	help
+	  env stored in dataflash
+
+config ENV_IS_IN_EEPROM
+	bool "env stored in eeprom"
+	help
+	  env stored in eeprom
+
+config ENV_IS_EMBEDDED
+	bool "env is embedded"
+	help
+	  env is embedded
+
+config ENV_IS_IN_FLASH
+	bool "env stored in flash"
+	help
+	  env stored in flash
+
+config ENV_IS_IN_MMC
+	bool "env stored in sd/mmc card"
+	help
+	  env stored in sd/mmc card
+
+config ENV_IS_IN_NAND
+	bool "env stored in nand flash"
+	help
+	  env stored in nand flash
+
+config ENV_IS_IN_NVRAM
+	bool "env stored in nvram"
+	help
+	  env stored in nvram
+
+config ENV_IS_IN_ONENAND
+	bool "env stored in onenand"
+	help
+	  env stored in onenand
+
+config ENV_IS_IN_SATA
+	bool "env stored in sata"
+	help
+	  env stored in sata
+
+config ENV_IS_IN_SPI_FLASH
+	bool "env stored in spi flash"
+	help
+	  env stored in spi flash
+
+config ENV_IS_IN_FAT
+	bool "env stored in a fat file"
+	help
+	  env stored in a fat file
+
+config ENV_IS_IN_UBI
+	bool "env stored in a ubi file"
+	help
+	  env stored in a ubi file
+
+config ENV_IS_IN_REMOTE
+	bool "env stored in remote"
+	help
+	  env stored in remote
+
+config ENV_IS_NOWHERE
+	bool "env is nowhere"
+	help
+	  env is nowhere
+endmenu
+
 config BOOTDELAY
 	int "delay in seconds before automatically booting"
 	default 2
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 common: env: add kconfig entry for env storage

Hi Peng,

Quoted 19 lines · Peng Fan

Add Kconfig entry for ENV storage

Cc Simon Glass <[email protected]>
Cc Heiko Schocher <[email protected]>
Cc Tom Rini <[email protected]>
Cc Masahiro Yamada <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Francois Retief <[email protected]>
---
 common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 73 insertions(+)
common/Kconfig +0 -0
index c69c141..a630924 100644

common/Kconfig config SPI_BOOT · line 166

Quoted 9 lines
common/Kconfig +6 -0
@@ -158,6 +158,79 @@ config SPI_BOOT
 
 endmenu
 
+menu "ENV storage media"
+
+config ENV_IS_IN_DATAFLASH
+       bool "env stored in dataflash"
+       help
+         env stored in dataflash

Can you add a little more help detail on this? Also I suspect we should have CONFIG_ENV as well, to enable the actual environment (independent of where it is stored).

Also, can you migrate the existing configs with moveconfig? That would be a big step forward and may inspire me to move it to linker lists.

Regards,
Simon

#2 lore raw

PATCH 1/1 common: env: add kconfig entry for env storage

Quoted 25 lines · Simon Glass

Hi Peng,

Quoted 22 lines · Peng Fan

Add Kconfig entry for ENV storage

Cc Simon Glass <[email protected]>
Cc Heiko Schocher <[email protected]>
Cc Tom Rini <[email protected]>
Cc Masahiro Yamada <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Francois Retief <[email protected]>
---
 common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 73 insertions(+)
common/Kconfig +0 -0
index c69c141..a630924 100644
@@ -158,6 +158,79 @@ config SPI_BOOT
 
 endmenu
 
Quoted 10 lines

common/Kconfig config SPI_BOOT · line 166

Quoted 6 lines
common/Kconfig +6 -0
+menu "ENV storage media"
+
+config ENV_IS_IN_DATAFLASH
+       bool "env stored in dataflash"
+       help
+         env stored in dataflash

Can you add a little more help detail on this? Also I suspect we should have CONFIG_ENV as well, to enable the actual environment (independent of where it is stored).

Yes, please add a bit more to the text.

Quoted 2 lines

Also, can you migrate the existing configs with moveconfig? That would be a big step forward and may inspire me to move it to linker lists.

Actually, I bet this is going to be messy enough that I'm fine running the moveconfig myself right before I merge it in.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161017/92dc6a76/attachment.sig>
#3 lore raw

PATCH 1/1 common: env: add kconfig entry for env storage

Hello Tom,

Am 18.10.2016 um 00:55 schrieb Tom Rini:

Quoted 37 lines · Simon Glass
Quoted 25 lines

Hi Peng,

Quoted 22 lines · Peng Fan

Add Kconfig entry for ENV storage

Cc Simon Glass <[email protected]>
Cc Heiko Schocher <[email protected]>
Cc Tom Rini <[email protected]>
Cc Masahiro Yamada <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Francois Retief <[email protected]>
---
  common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 73 insertions(+)
common/Kconfig +0 -0
index c69c141..a630924 100644
@@ -158,6 +158,79 @@ config SPI_BOOT
 
  endmenu
 
Quoted 10 lines

common/Kconfig config SPI_BOOT · line 166

Quoted 6 lines
common/Kconfig +6 -0
+menu "ENV storage media"
+
+config ENV_IS_IN_DATAFLASH
+       bool "env stored in dataflash"
+       help
+         env stored in dataflash

Can you add a little more help detail on this? Also I suspect we should have CONFIG_ENV as well, to enable the actual environment (independent of where it is stored).

Quoted 7 lines

Yes, please add a bit more to the text.

Quoted 2 lines

Also, can you migrate the existing configs with moveconfig? That would be a big step forward and may inspire me to move it to linker lists.

Actually, I bet this is going to be messy enough that I'm fine running the moveconfig myself right before I merge it in.

Feel free to give me the patch for running the tbot test [1], that the patch does not change binaries ...

bye,
Heiko

[1] https://github.com/hsdenx/tbot/blob/master/src/tc/uboot/tc_uboot_check_kconfig.py

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany