Skip to contentSkip to conversation

ARM: dts: mps2: remove skeleton.dtsi include and fix unit address warnings

PATCH New Vladimir Murzin 2 participants 3 messages Oct 17, 2016 – Oct 18, 2016

Subsystems (2)
Device tree bindings Arm/versatile express platform
lore
Share & tools
lore

Vladimir Murzin

author
#0 lore raw

PATCH 1/1 ARM: dts: mps2: remove skeleton.dtsi include and fix unit address warnings

Removale of skeleton.dtsi allows us also to fix the following
warning from the dts compiler:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

by adding proper unit addresses to the memory nodes.

Signed-off-by Vladimir Murzin <[email protected]>
---
 arch/arm/boot/dts/mps2-an385.dts |    2 +-
 arch/arm/boot/dts/mps2-an399.dts |    2 +-
 arch/arm/boot/dts/mps2.dtsi      |    4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)
arch/arm/boot/dts/mps2-an385.dts +1 -1
index 31c374d..aebbebf 100644
@@ -59,7 +59,7 @@
 		stdout-path = "serial0:9600n8";
 	};
 
-	memory {
+	memory at 21000000 {
 		device_type = "memory";
 		reg = <0x21000000 0x1000000>;
 	};
arch/arm/boot/dts/mps2-an399.dts +1 -1
index 5e7e5ca..349abf7 100644
@@ -59,7 +59,7 @@
 		stdout-path = "serial0:9600n8";
 	};
 
-	memory {
+	memory at 60000000 {
 		device_type = "memory";
 		reg = <0x60000000 0x1000000>;
 	};
arch/arm/boot/dts/mps2.dtsi +3 -1
index efb8a03..2346739 100644
@@ -42,10 +42,12 @@
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "skeleton.dtsi"
 #include "armv7-m.dtsi"
 
 / {
+	#address-cells = <1>;
+	#size-cells = <1>;
+
 	oscclk0: clk-osc0 {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: dts: mps2: remove skeleton.dtsi include and fix unit address warnings

Quoted 7 lines · Vladimir Murzin

Removale of skeleton.dtsi allows us also to fix the following
warning from the dts compiler:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

by adding proper unit addresses to the memory nodes.

Signed-off-by Vladimir Murzin <[email protected]>

It's always better to cc device-tree list, anyways applied this to [1].

--
Regards,
Sudeep

[1] git.kernel.org/sudeep.holla/linux/h/vexpress-dt/for-next

author
#2 lore raw

PATCH 1/1 ARM: dts: mps2: remove skeleton.dtsi include and fix unit address warnings

Quoted 7 lines · Sudeep Holla
Quoted 4 lines · Vladimir Murzin

Removale of skeleton.dtsi allows us also to fix the following
warning from the dts compiler:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Quoted 5 lines
Quoted 3 lines

by adding proper unit addresses to the memory nodes.

Signed-off-by Vladimir Murzin <[email protected]>

It's always better to cc device-tree list, anyways applied this to [1].

Thanks!

Vladimir

Quoted 13 lines
Signature · 10 lines
-- 
Regards,
Sudeep

[1] git.kernel.org/sudeep.holla/linux/h/vexpress-dt/for-next

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel