drm/amdgpu: fix sched fence slab teardown
Subsystems (2)
PATCH 1/1 drm/amdgpu: fix sched fence slab teardown
To free fences, call_rcu() is used, which calls amd_sched_fence_free() after a grace period. During teardown, there is no guarantee all callbacks have finished, so sched_fence_slab may be destroyed before all fences have been freed. If we are lucky, this results in some slab warnings, if not, we get a crash in one of rcu threads because callback is called after amdgpu has already been unloaded.
Fix it with a rcu_barrier().
--- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c +1 -0
@@ -645,6 +645,7 @@ void amd_sched_fini(struct amd_gpu_scheduler *sched) {if (sched->thread)kthread_stop (sched->thread); +rcu_barrier ();if (atomic_dec_and_test (&sched_fence_slab_ref))kmem_cache_destroy (sched_fence_slab); }
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 20 lines · Grazvydas Ignotas
To free fences,
call_rcu()is used, which callsamd_sched_fence_free()after a grace period. During teardown, there is no guarantee all callbacks have finished, sosched_fence_slabmay be destroyed before all fences have been freed. If we are lucky, this results in some slab warnings, if not, we get a crash in one of rcu threads because callback is called after amdgpu has already been unloaded.Fix it with a
rcu_barrier().Fixes 189e0fb76304 ("drm/amdgpu: RCU protected amd_sched_fence_release")Signed-off-by Grazvydas Ignotas <[email protected]>--- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/scheduler/gpu_scheduler.c +0
-0
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c void amd_sched_fini(struct amd_gpu_scheduler *sched) · line 651
Quoted 7 lines
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c +1
-0@@ -645,6 +645,7 @@ void amd_sched_fini(struct amd_gpu_scheduler *sched) {if (sched->thread)kthread_stop (sched->thread); +rcu_barrier ();if (atomic_dec_and_test (&sched_fence_slab_ref))kmem_cache_destroy (sched_fence_slab); }
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Christian König
Reviewed-byAm 24.10.2016 um 04:34 schrieb zhoucm1:
Quoted 27 lines
Acked-by Chunming Zhou <[email protected]>Quoted 24 lines · Grazvydas Ignotas
To free fences,
call_rcu()is used, which callsamd_sched_fence_free()after a grace period. During teardown, there is no guarantee all callbacks have finished, sosched_fence_slabmay be destroyed before all fences have been freed. If we are lucky, this results in some slab warnings, if not, we get a crash in one of rcu threads because callback is called after amdgpu has already been unloaded.Fix it with a
rcu_barrier().Fixes 189e0fb76304 ("drm/amdgpu: RCU protected amd_sched_fence_release")Signed-off-by Grazvydas Ignotas <[email protected]>--- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/scheduler/gpu_scheduler.c +1
-0@@ -645,6 +645,7 @@ void amd_sched_fini(struct amd_gpu_scheduler *sched) {if (sched->thread)kthread_stop (sched->thread); +rcu_barrier ();
Quoted 8 lines
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c void amd_sched_fini(struct amd_gpu_scheduler *sched) · line 651
Quoted 3 lines
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c +0
-0if (atomic_dec_and_test (&sched_fence_slab_ref))kmem_cache_destroy (sched_fence_slab); }_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): bde776d0-0044-5742-ae1a-1de2a4cf5faa-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org
Alex Deucher
AppliedQuoted 38 lines · Christian König
Reviewed-by Christian König <[email protected]>Am 24.10.2016 um 04:34 schrieb zhoucm1:
Quoted 34 lines
Acked-by Chunming Zhou <[email protected]>Quoted 29 lines · Grazvydas Ignotas
To free fences,
call_rcu()is used, which callsamd_sched_fence_free()after a grace period. During teardown, there is no guarantee all callbacks have finished, sosched_fence_slabmay be destroyed before all fences have been freed. If we are lucky, this results in some slab warnings, if not, we get a crash in one of rcu threads because callback is called after amdgpu has already been unloaded.Fix it with a
rcu_barrier().Fixes 189e0fb76304 ("drm/amdgpu: RCU protected amd_sched_fence_release")Signed-off-by Grazvydas Ignotas <[email protected]>--- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/scheduler/gpu_scheduler.c +1
-0@@ -645,6 +645,7 @@ void amd_sched_fini(struct amd_gpu_scheduler *sched) {if (sched->thread)kthread_stop (sched->thread); +rcu_barrier ();if (atomic_dec_and_test (&sched_fence_slab_ref))kmem_cache_destroy (sched_fence_slab); }
Applied. thanks!
Alex
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx