Skip to contentSkip to conversation

Renesas ARM Based SoC Fixes for v4.3

GIT PULL New Simon Horman 4 participants 8 messages Oct 2, 2015 – Oct 16, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Olof, Hi Kevin, Hi Arnd,

Please consider these Renesas ARM based SoC fixes for v4.3.

These changes are required to restore working sound for the r8a779[01] SoCs in v4.3.

My understanding is that with the inclusion of
"drivers: sh: Disable PM runtime for multi-platform ARM with genpd" in v4.3-rc3 sound stopped working for the SoCs in question.

These patches were previously posted as part of
"Renesas ARM Based SoC DT Updates for v4.4".
I have withdrawn that pull request.

The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-fixes-for-v4.3

for you to fetch changes up to 56e86dd4bbeb66a7ad67e20fa045c6f51b4da571:

ARM: shmobile: r8a7791 dtsi: Add CPG/MSTP Clock Domain for sound (2015-09-29 09:44:13 +0900)

----------------------------------------------------------------
Renesas ARM Based SoC Fixes for v4.3

* Add Add CPG/MSTP Clock Domain for sound on r8a779[01] SoCs. This allows sound to work once again.

----------------------------------------------------------------
Geert Uytterhoeven (2):
ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain for sound
ARM: shmobile: r8a7791 dtsi: Add CPG/MSTP Clock Domain for sound

 arch/arm/boot/dts/r8a7790.dtsi | 1 +
 arch/arm/boot/dts/r8a7791.dtsi | 1 +
 2 files changed, 2 insertions(+)
#1 lore raw

PATCH 1/2 ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain for sound

From: Geert Uytterhoeven <[email protected]>

484adb005886 ("ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain") added CPG/MSTP clock-cells domain support, but it was missing sound support. This patch adds it.

[horms: Updated commit id referred to in changelog]
---
 arch/arm/boot/dts/r8a7790.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/r8a7790.dtsi +1 -0
index a0b2a79cbfbd..4624d0f2a754 100644
@@ -1627,6 +1627,7 @@
 				"mix.0", "mix.1",
 				"dvc.0", "dvc.1",
 				"clk_a", "clk_b", "clk_c", "clk_i";
+		power-domains = <&cpg_clocks>;
 
 		status = "disabled";
 
Signature · 1 line
2.1.4
#2 lore raw

PATCH 1/2 ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain for sound

Hello.

Quoted 5 lines · Simon Horman

From: Geert Uytterhoeven <[email protected]>

484adb005886 ("ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain") added CPG/MSTP clock-cells domain support, but it was missing sound support. This patch adds it.

Really? I'm only seeing "power-domains" prop added...

Quoted 13 lines
[horms: Updated commit id referred to in changelog]
---
  arch/arm/boot/dts/r8a7790.dtsi | 1 +
  1 file changed, 1 insertion(+)
arch/arm/boot/dts/r8a7790.dtsi +0 -0
index a0b2a79cbfbd..4624d0f2a754 100644

arch/arm/boot/dts/r8a7790.dtsi line 1633

Quoted 7 lines
arch/arm/boot/dts/r8a7790.dtsi +1 -0
@@ -1627,6 +1627,7 @@
  				"mix.0", "mix.1",
  				"dvc.0", "dvc.1",
  				"clk_a", "clk_b", "clk_c", "clk_i";
+		power-domains = <&cpg_clocks>;
 
  		status = "disabled";
 

MBR, Sergei

#3 lore raw

PATCH 1/2 ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain for sound

Quoted 7 lines · Sergei Shtylyov
Quoted 5 lines

From: Geert Uytterhoeven <[email protected]>

484adb005886 ("ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain") added CPG/MSTP clock-cells domain support, but it was missing sound support. This patch adds it.

Really? I'm only seeing "power-domains" prop added...

Oh, I understand now. The log seems somewhat poorly worded though...

Quoted 4 lines
Quoted 4 lines
[horms: Updated commit id referred to in changelog]

[...]

MBR, Sergei

#4 lore raw

PATCH 1/2 ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain for sound

Quoted 11 lines · On Friday 02 October 2015 14:32:49 Sergei Shtylyov wrote:
Quoted 7 lines · Sergei Shtylyov
Quoted 5 lines

From: Geert Uytterhoeven <[email protected]>

484adb005886 ("ARM: shmobile: r8a7790 dtsi: Add CPG/MSTP Clock Domain") added CPG/MSTP clock-cells domain support, but it was missing sound support. This patch adds it.

Really? I'm only seeing "power-domains" prop added...

Oh, I understand now. The log seems somewhat poorly worded though...

I understood it right and merged it as is, but I agree this could have been clearer.

Arnd

#5 lore raw

PATCH 2/2 ARM: shmobile: r8a7791 dtsi: Add CPG/MSTP Clock Domain for sound

In reply to Simon Horman

From: Geert Uytterhoeven <[email protected]>

797a0626e08c ("ARM: shmobile: r8a7791 dtsi: Add CPG/MSTP Clock Domain") added CPG/MSTP clock-cells domain support, but it was missing sound support. This patch adds it.

[horms: updated commit id referred to in changelog]
---
 arch/arm/boot/dts/r8a7791.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/r8a7791.dtsi +1 -0
index 831525dd39a6..1666c8a6b143 100644
@@ -1677,6 +1677,7 @@
 				"mix.0", "mix.1",
 				"dvc.0", "dvc.1",
 				"clk_a", "clk_b", "clk_c", "clk_i";
+		power-domains = <&cpg_clocks>;
 
 		status = "disabled";
 
Signature · 1 line
2.1.4
#6 lore raw

PATCH 2/2 ARM: shmobile: r8a7791 dtsi: Remove bogus imp_clk node

R-Car M2-W does not have an IMP core or an IMP clock.

---
 arch/arm/boot/dts/r8a7791.dtsi | 8 --------
 1 file changed, 8 deletions(-)
arch/arm/boot/dts/r8a7791.dtsi +0 -8
index 328f48bd15e711ad..76742cc6021ee0a2 100644
@@ -1163,14 +1163,6 @@
 			clock-mult = <1>;
 			clock-output-names = "m2";
 		};
-		imp_clk: imp_clk {
-			compatible = "fixed-factor-clock";
-			clocks = <&cpg_clocks R8A7791_CLK_PLL1>;
-			#clock-cells = <0>;
-			clock-div = <4>;
-			clock-mult = <1>;
-			clock-output-names = "imp";
-		};
 		rclk_clk: rclk_clk {
 			compatible = "fixed-factor-clock";
 			clocks = <&cpg_clocks R8A7791_CLK_PLL1>;
Signature · 1 line
1.9.1
#7 lore raw
In reply to Simon Horman
Quoted 6 lines · On Friday 02 October 2015 11:29:28 Simon Horman wrote:

Please consider these Renesas ARM based SoC fixes for v4.3.

These changes are required to restore working sound for the r8a779[01] SoCs in v4.3.

Quoted 9 lines

My understanding is that with the inclusion of
"drivers: sh: Disable PM runtime for multi-platform ARM with genpd" in v4.3-rc3 sound stopped working for the SoCs in question.

These patches were previously posted as part of
"Renesas ARM Based SoC DT Updates for v4.4".
I have withdrawn that pull request.

Merged into fixes, thanks!

Arnd