Skip to contentSkip to conversation

libiio: update to version 0.25

PATCH In review Marek Vasut 3 participants 7 messages Jul 12, 2023 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 libiio: update to version 0.25

The version 0.25 has been released, it has not been tagged however. Update the this version anyway.

---
Cc: Christian Eggers <[email protected]>
Cc: Khem Raj <[email protected]>
Cc: Martin Siegumfeldt <[email protected]>

---
 meta-oe/recipes-support/libiio/libiio_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/libiio/libiio_git.bb +2 -2
index ea51c19f4..b89ae29ea 100644
@@ -4,8 +4,8 @@ SECTION = "libs"
 LICENSE = "LGPL-2.1-or-later"
 LIC_FILES_CHKSUM = "file://COPYING.txt;md5=7c13b3376cea0ce68d2d2da0a1b3a72c"
 
-SRCREV = "c4498c27761d04d4ac631ec59c1613bfed079da5"
-PV = "0.24"
+SRCREV = "eee8cba6f42177a094ebe16759606a719676fda7"
+PV = "0.25"
 
 SRC_URI = "git://github.com/analogdevicesinc/libiio.git;protocol=https;branch=master"
 UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
Signature · 1 line
2.40.1
#1 lore raw

PATCH 2/2 libiio: enable c++ bindings

The C++ bindings are new in libiio 0.25 , make those available. Unlike python bindings which are gated off by PACKAGECONFIG, it seems the C++ bindings have no dependencies, the C++ compiler is always present, so the bindings can always be enabled.

---
Cc: Christian Eggers <[email protected]>
Cc: Khem Raj <[email protected]>
Cc: Martin Siegumfeldt <[email protected]>

---
 meta-oe/recipes-support/libiio/libiio_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-support/libiio/libiio_git.bb +1 -0
index b89ae29ea..ecbd2c864 100644
@@ -22,6 +22,7 @@ inherit cmake python3native systemd setuptools3 pkgconfig
 
 EXTRA_OECMAKE = " \
     -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+    -DCPP_BINDINGS=ON \
     -DFLEX_TARGET_ARG_COMPILE_FLAGS='--noline' \
     -DBISON_TARGET_ARG_COMPILE_FLAGS='--no-lines' \
     -DUDEV_RULES_INSTALL_DIR=${nonarch_base_libdir}/udev/rules.d \
Signature · 1 line
2.40.1
#2 lore raw
In reply to Marek Vasut
Quoted 3 lines · Marek Vasut

The version 0.25 has been released, it has not been tagged however. Update the this version anyway.

hmm how do we know where to peg SRCREV ? I wonder if we should wait for tag to appear.

Quoted 28 lines

---
Cc: Christian Eggers <[email protected]>
Cc: Khem Raj <[email protected]>
Cc: Martin Siegumfeldt <[email protected]>

---
 meta-oe/recipes-support/libiio/libiio_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/libiio/libiio_git.bb +2 -3
index ea51c19f4..b89ae29ea 100644
@@ -4,8 +4,8 @@ SECTION = "libs"
 LICENSE = "LGPL-2.1-or-later"
 LIC_FILES_CHKSUM = "file://COPYING.txt;md5=7c13b3376cea0ce68d2d2da0a1b3a72c"
 
-SRCREV = "c4498c27761d04d4ac631ec59c1613bfed079da5"
-PV = "0.24"
+SRCREV = "eee8cba6f42177a094ebe16759606a719676fda7"
+PV = "0.25"
 
 SRC_URI = "git://github.com/analogdevicesinc/libiio.git;protocol=https;branch=master"
 UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
--

2.40.1

#3 lore raw
Quoted 3 lines · Marek Vasut

The version 0.25 has been released, it has not been tagged however. Update the this version anyway.

hmm how do we know where to peg SRCREV ? I wonder if we should wait for tag to appear.

I agree in waiting for tag to be published.

Also, would it make sense to rename the recipe file according to the actual version rather than 'git'? In the past I think the recipe referred arbitrary git commits, however we have moved to referring actual release commits now.

Quoted 26 lines

---
Cc: Christian Eggers <[email protected]>
Cc: Khem Raj <[email protected]>
Cc: Martin Siegumfeldt <[email protected]>

---
 meta-oe/recipes-support/libiio/libiio_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/libiio/libiio_git.bb +2 -3
index ea51c19f4..b89ae29ea 100644
@@ -4,8 +4,8 @@ SECTION = "libs"
 LICENSE = "LGPL-2.1-or-later"
 LIC_FILES_CHKSUM = "file://COPYING.txt;md5=7c13b3376cea0ce68d2d2da0a1b3a72c"
 
-SRCREV = "c4498c27761d04d4ac631ec59c1613bfed079da5"
-PV = "0.24"
+SRCREV = "eee8cba6f42177a094ebe16759606a719676fda7"
+PV = "0.25"
 
 SRC_URI = "git://github.com/analogdevicesinc/libiio.git;protocol=https;branch=master"
 UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
--
Quoted 2 lines

2.40.1

________________________
This email was scanned by Bitdefender

#4 lore raw
Quoted 7 lines · Martin Siegumfeldt
Quoted 3 lines · Marek Vasut

The version 0.25 has been released, it has not been tagged however. Update the this version anyway.

hmm how do we know where to peg SRCREV ? I wonder if we should wait for tag to appear.

The 0.24 appeared on matching commit
"CMake: Bump version to v0.24"
Same for 0.23, 0.22, 0.21. 0.20 was not tagged like this 0.25. 0.19 was tagged again etc.

I think it is safe to assume the tag was just missed or not pushed, but I planned to ping Paul about it. Might as well add Paul to CC help and ask that way.

Paul, is the libiio 0.25 tag just missing ?

Quoted 1 line

I agree in waiting for tag to be published.

See above.

Quoted 1 line

Also, would it make sense to rename the recipe file according to the actual version rather than 'git'? In the past I think the recipe referred arbitrary git commits, however we have moved to referring actual release commits now.

Yes, good point, but that's a separate patch. I made a local commit so it isn't forgotten.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 25 lines · Paul Cercueil

Hi,

Le mercredi 12 juillet 2023 à 09:25 +0200, Marek Vasut a écrit :

Quoted 22 lines · Martin Siegumfeldt
Quoted 8 lines · Marek Vasut
Quoted 4 lines

The version 0.25 has been released, it has not been tagged however.
Update the this version anyway.

hmm how do we know where to peg SRCREV ? I wonder if we should wait for tag to appear.

The 0.24 appeared on matching commit
"CMake: Bump version to v0.24"
Same for 0.23, 0.22, 0.21. 0.20 was not tagged like this 0.25. 0.19 was
tagged again etc.

I think it is safe to assume the tag was just missed or not pushed, but
I planned to ping Paul about it. Might as well add Paul to CC help and
ask that way.

Quoted 6 lines
Quoted 3 lines

Paul, is the libiio 0.25 tag just missing ?

Quoted 1 line

I agree in waiting for tag to be published.

Yes, please wait for the tag. The commit that bumps the version number in the CMake script is not necesarily the top commit at each release.

Then we wait, thanks!

#7 lore raw
In reply to Martin Siegumfeldt
Quoted 6 lines · Martin Siegumfeldt
Quoted 3 lines · Marek Vasut

The version 0.25 has been released, it has not been tagged however. Update the this version anyway.

Quoted 6 lines

hmm how do we know where to peg SRCREV ? I wonder if we should wait for tag to appear.

I agree in waiting for tag to be published.

Also, would it make sense to rename the recipe file according to the actual version rather than 'git'? In the past I think the recipe referred arbitrary git commits, however we have moved to referring actual release commits now.

Yes it is preferred that PV is moved to recipe name in such cases.

Quoted 33 lines
Quoted 27 lines

---
Cc: Christian Eggers <[email protected]>
Cc: Khem Raj <[email protected]>
Cc: Martin Siegumfeldt <[email protected]>

---
 meta-oe/recipes-support/libiio/libiio_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-support/libiio/libiio_git.bb +2 -3
index ea51c19f4..b89ae29ea 100644
@@ -4,8 +4,8 @@ SECTION = "libs"
 LICENSE = "LGPL-2.1-or-later"
 LIC_FILES_CHKSUM = "file://COPYING.txt;md5=7c13b3376cea0ce68d2d2da0a1b3a72c"
 
-SRCREV = "c4498c27761d04d4ac631ec59c1613bfed079da5"
-PV = "0.24"
+SRCREV = "eee8cba6f42177a094ebe16759606a719676fda7"
+PV = "0.25"
 
 SRC_URI = "git://github.com/analogdevicesinc/libiio.git;protocol=https;branch=master"
 UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
--
Quoted 2 lines

2.40.1

________________________
This email was scanned by Bitdefender