Skip to contentSkip to conversation

network: fix bashisms + shebang

PATCH New Petr Vorel 2 participants 2 messages Nov 8, 2016 – Nov 9, 2016

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 network: fix bashisms + shebang

Signed-off-by Petr Vorel <[email protected]>
---
 testcases/network/nfs/nfs_stress/nfs_lib.sh | 1 +
 testcases/network/sockets/ltpSockets.sh     | 4 ++--
 testcases/network/virt/virt_lib.sh          | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)
testcases/network/nfs/nfs_stress/nfs_lib.sh +1 -0
index 78df4d3..0abf39d 100644
@@ -1,3 +1,4 @@
+#!/bin/sh
 # Copyright (c) 2015-2016 Oracle and/or its affiliates. All Rights Reserved.
 # Copyright (c) International Business Machines  Corp., 2001
 #
testcases/network/sockets/ltpSockets.sh +2 -2
index 48fa8c6..65b2320 100755
@@ -54,10 +54,10 @@ echo "Starting UDP, TCP and Multicast tests..."
 echo "Starting ltpServer..."
 
 ./ltpServer $hostname1 &
-sleep 5s
+sleep 5
 echo "Starting ltpClient..."
 ./ltpClient $hostname1 $hostname1 $testdata
-sleep 1s
+sleep 1
 killall -9 ltpServer
 killall -9 ltpClient
testcases/network/virt/virt_lib.sh +2 -1
index ee6488c..df453e5 100644
@@ -103,7 +103,8 @@ trap "tst_brkm TBROK 'test interrupted'" INT
 virt_add()
 {
 	local vname=$1
-	local opt="${@:2}"
+	shift
+	local opt="$*"
 
 	case $virt_type in
 	vlan|vxlan)
Signature · 1 line
2.10.2
#1 lore raw

PATCH 1/1 network: fix bashisms + shebang

Quoted 6 lines · Petr Vorel
Signed-off-by Petr Vorel <[email protected]>
---
  testcases/network/nfs/nfs_stress/nfs_lib.sh | 1 +
  testcases/network/sockets/ltpSockets.sh     | 4 ++--
  testcases/network/virt/virt_lib.sh          | 3 ++-
  3 files changed, 5 insertions(+), 3 deletions(-)

Patch applied. Thank you!

Best regards,
Alexey