Skip to contentSkip to conversation

staging: comedi: ni_670x: using the BIT(x) macro

PATCH In review Saber Rezvani 2 participants 2 messages Dec 16, 2016 – Dec 19, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: comedi: ni_670x: using the BIT(x) macro

Fix the checkpatch.pl issue:
CHECK: Prefer using the BIT macro replacing bit shifting on 1 with the BIT(x) macro.

---
 drivers/staging/comedi/drivers/ni_670x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/ni_670x.c +1 -1
index 74911db..1d3ff60 100644
@@ -141,7 +141,7 @@ static int ni_670x_dio_insn_config(struct comedi_device *dev,
 
 /* ripped from mite.h and mite_setup2() to avoid mite dependency */
 #define MITE_IODWBSR	0xc0	 /* IO Device Window Base Size Register */
-#define WENAB		(1 << 7) /* window enable */
+#define WENAB		BIT(7) /* window enable */
 
 static int ni_670x_mite_init(struct pci_dev *pcidev)
 {
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Saber Rezvani

Fix the checkpatch.pl issue:
CHECK: Prefer using the BIT macro replacing bit shifting on 1 with the BIT(x) macro.

---
  drivers/staging/comedi/drivers/ni_670x.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-